New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 599703 link

Starred by 1 user
Status: Fixed
Owner:
sorin@chromium.org
Closed: Apr 2016
Cc:
█ joenotcharles@chromium.org
waff...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Implement an API to allow passing an "ap" parameter to component updates

Project Member Reported by sorin@chromium.org, Mar 31 2016 
In the update protocol, there is a protocol element that allows the client to pass additional parameters in the update check. Please see the description of the "tag" attribute in the Omaha server protocol: https://github.com/google/omaha/blob/wiki/ServerProtocolV3.md#app-request

tag: An field for a client to transmit arbitrary update parameters in string form. Compatible clients and servers MAY use this attribute to negotiate special update rules. Alternatively, they MAY extend the protocol to represent the information more clearly in another parameter. As an example, Omaha Client uses this field to transmit whether a Google Chrome installation is on the "stable", "dev", or "beta" channel, which affects how the server issues update responses for that installation. Default: "".

The feature request is for the component updater to implement this protocol feature.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b864bc7fba289371958cfb669c4f3ddaf1183e5

commit 2b864bc7fba289371958cfb669c4f3ddaf1183e5
Author: sorin <sorin@chromium.org>
Date: Fri Apr 08 22:14:47 2016

Implement an API to allow passing an "ap" parameter to component updates.

BUG= 599703 

Review URL: https://codereview.chromium.org/1872053002

Cr-Commit-Position: refs/heads/master@{#386225}

[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/chrome/browser/component_updater/caps_installer_win.cc
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/chrome/browser/component_updater/cld_component_installer.cc
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/chrome/browser/component_updater/cld_component_installer.h
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/chrome/browser/component_updater/ev_whitelist_component_installer.cc
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/chrome/browser/component_updater/ev_whitelist_component_installer.h
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/chrome/browser/component_updater/sth_set_component_installer.cc
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/chrome/browser/component_updater/sth_set_component_installer.h
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/chrome/browser/component_updater/sw_reporter_installer_win.cc
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/chrome/browser/component_updater/widevine_cdm_component_installer.cc
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/components/component_updater/default_component_installer.h
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/components/update_client/update_checker.cc
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/components/update_client/update_client.h
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/components/update_client/utils.cc
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/components/update_client/utils.h
[modify] https://crrev.com/2b864bc7fba289371958cfb669c4f3ddaf1183e5/components/update_client/utils_unittest.cc

Comment 2 by sorin@chromium.org, Apr 11 2016

Labels: M-51
Status: Fixed (was: Started)
This made M-51.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98fc1d664ac27ba8e840abc147049279668a751a

commit 98fc1d664ac27ba8e840abc147049279668a751a
Author: sorin <sorin@chromium.org>
Date: Thu Jun 09 22:47:48 2016

Make ap effective.

The value must be propagated to the CrxInstaller for the feature
to work end to end.

Changed the order of assignments to match the order of member
declaration in CrxInstaller class.

R=waffles
BUG= 599703 

Review-Url: https://codereview.chromium.org/2056773002
Cr-Commit-Position: refs/heads/master@{#399042}

[modify] https://crrev.com/98fc1d664ac27ba8e840abc147049279668a751a/components/component_updater/default_component_installer.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98fc1d664ac27ba8e840abc147049279668a751a

commit 98fc1d664ac27ba8e840abc147049279668a751a
Author: sorin <sorin@chromium.org>
Date: Thu Jun 09 22:47:48 2016

Make ap effective.

The value must be propagated to the CrxInstaller for the feature
to work end to end.

Changed the order of assignments to match the order of member
declaration in CrxInstaller class.

R=waffles
BUG= 599703 

Review-Url: https://codereview.chromium.org/2056773002
Cr-Commit-Position: refs/heads/master@{#399042}

[modify] https://crrev.com/98fc1d664ac27ba8e840abc147049279668a751a/components/component_updater/default_component_installer.cc
Project Member

Comment 6 by bugdroid1@chromium.org, Jun 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46

commit 2adb2caddbc95ffd35cc9b2713f075d93d9b9d46
Author: sorin <sorin@chromium.org>
Date: Wed Jun 29 01:44:35 2016

This is a mechanical change.

Allow component installers to specify a map of installer attributes to be used in the update check requests.

This change extends the mechanism to specify "ap" in such a way that a map of name-value pairs can be returned by the component installer which need this capability.

R=waffles
BUG= 599703 

Review-Url: https://codereview.chromium.org/2102083002
Cr-Commit-Position: refs/heads/master@{#402632}

[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/caps_installer_win.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/ev_whitelist_component_installer.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/ev_whitelist_component_installer.h
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/file_type_policies_component_installer.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/file_type_policies_component_installer.h
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/origin_trials_component_installer.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/origin_trials_component_installer.h
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/pepper_flash_component_installer.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/sth_set_component_installer.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/sth_set_component_installer.h
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/subresource_filter_component_installer.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/subresource_filter_component_installer.h
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/supervised_user_whitelist_installer.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/sw_reporter_installer_win.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/chrome/browser/component_updater/widevine_cdm_component_installer.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/components/component_updater/default_component_installer.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/components/component_updater/default_component_installer.h
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/components/component_updater/default_component_installer_unittest.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/components/update_client/update_checker.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/components/update_client/update_checker_unittest.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/components/update_client/update_client.h
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/components/update_client/utils.cc
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/components/update_client/utils.h
[modify] https://crrev.com/2adb2caddbc95ffd35cc9b2713f075d93d9b9d46/components/update_client/utils_unittest.cc
►

Sign in to add a comment