New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599667 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

[Privacy] Site settings font-size incorrect

Project Member Reported by bettes@chromium.org, Mar 31 2016

Issue description

Site settings and associated subpagess are using ~14px and not 13px 
 
Screen Shot 2016-03-31 at 2.57.58 PM.png
29.7 KB View Download
Screen Shot 2016-03-31 at 2.58.02 PM.png
13.6 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, May 11 2016

Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1d46bf66b0983b5e71f5c08b608317c9d7d0f3d

commit b1d46bf66b0983b5e71f5c08b608317c9d7d0f3d
Author: dschuyler <dschuyler@chromium.org>
Date: Wed May 11 22:48:06 2016

[MD settings] layout of the site settings page

This CL changes the layout of the main site settings section.
It now uses settings-box styles. The order of the sections has also
been changed (per mocks).

BUG= 599667 ,  589630 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1957823002
Cr-Commit-Position: refs/heads/master@{#393092}

[modify] https://crrev.com/b1d46bf66b0983b5e71f5c08b608317c9d7d0f3d/chrome/browser/resources/settings/settings_page/settings_subpage.html
[modify] https://crrev.com/b1d46bf66b0983b5e71f5c08b608317c9d7d0f3d/chrome/browser/resources/settings/settings_shared_css.html
[modify] https://crrev.com/b1d46bf66b0983b5e71f5c08b608317c9d7d0f3d/chrome/browser/resources/settings/site_settings_page/site_settings_page.css
[modify] https://crrev.com/b1d46bf66b0983b5e71f5c08b608317c9d7d0f3d/chrome/browser/resources/settings/site_settings_page/site_settings_page.html

Labels: Hotlist-MD-Settings-Privacy-SiteSettings
Project Member

Comment 4 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acdd8952437b03d69151e183134e5268a33a1ea3

commit acdd8952437b03d69151e183134e5268a33a1ea3
Author: finnur <finnur@chromium.org>
Date: Fri May 27 01:49:12 2016

Fix icon for Site Settings Site List.

Wasn't being drawn (it was referring to the wrong package).

BUG= 599667 ,  589630 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2018683002
Cr-Commit-Position: refs/heads/master@{#396349}

[modify] https://crrev.com/acdd8952437b03d69151e183134e5268a33a1ea3/chrome/browser/resources/settings/site_settings/site_list.html

Project Member

Comment 5 by bugdroid1@chromium.org, Jun 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3cb4d9e227dfd94aea54f5a42734e136260f8a08

commit 3cb4d9e227dfd94aea54f5a42734e136260f8a08
Author: finnur <finnur@chromium.org>
Date: Wed Jun 01 00:56:12 2016

Fix font sizes on Site Details page.
(should all be 13px)

BUG= 599667 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2029463002
Cr-Commit-Position: refs/heads/master@{#397001}

[modify] https://crrev.com/3cb4d9e227dfd94aea54f5a42734e136260f8a08/chrome/browser/resources/settings/site_settings/site_details.html
[modify] https://crrev.com/3cb4d9e227dfd94aea54f5a42734e136260f8a08/chrome/browser/resources/settings/site_settings/site_details_permission.html

Status: Fixed (was: Assigned)
Should be done now.

Sign in to add a comment