New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599662 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

inspector/sources/debugger-ui/debugger-save-to-temp-var.html is crashing

Project Member Reported by rdevlin....@chromium.org, Mar 31 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/262a536f9e845f0810885c45c27de815e027e5c9

commit 262a536f9e845f0810885c45c27de815e027e5c9
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Thu Mar 31 22:25:03 2016

[Sheriff] Disable inspector/sources/debugger-ui/debugger-save-to-temp-var.html

NOTRY=True
TBR=pfeldman@chromium.org

BUG= 599662 

Review URL: https://codereview.chromium.org/1837383005

Cr-Commit-Position: refs/heads/master@{#384418}

[modify] https://crrev.com/262a536f9e845f0810885c45c27de815e027e5c9/third_party/WebKit/LayoutTests/TestExpectations

Owner: kozyatinskiy@chromium.org
Hmmm... I think we need to add a [ Crash ] expectation - this is what is happening here: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/6591/steps/webkit_tests/logs/stdio

Let me prepare a CL and send out to rdevlin.cronin@ for review.
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fa7747ecf3f1c3d848f31ed841805dcc8daec1c

commit 4fa7747ecf3f1c3d848f31ed841805dcc8daec1c
Author: lukasza <lukasza@chromium.org>
Date: Fri Apr 01 23:51:14 2016

Crash expectation for inspector/sources/debugger-ui/debugger-save-to-temp-var.html

BUG= 599662 
TBR=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1856433002

Cr-Commit-Position: refs/heads/master@{#384725}

[modify] https://crrev.com/4fa7747ecf3f1c3d848f31ed841805dcc8daec1c/third_party/WebKit/LayoutTests/TestExpectations

Cc: yangguo@chromium.org
Status: Started (was: Assigned)
https://codereview.chromium.org/1856203002/
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2e191cee8a61b80ef880c1f2469495441e6c9c86

commit 2e191cee8a61b80ef880c1f2469495441e6c9c86
Author: yangguo <yangguo@chromium.org>
Date: Tue Apr 05 12:07:43 2016

[debugger] ScopeIterator should unwrap debug-evaluate contexts.

If we use ScopeIterator inside a debug-evaluate call, we may iterate
over a debug-evaluate context that we created for the debug-evaluate
call. This may trigger assertions.

The solution is to have the ScopeIterator hide debug-evaluate contexts
by unwrapping it if it comes across any.

R=cbruni@chromium.org
BUG= chromium:599662 
LOG=N

Review URL: https://codereview.chromium.org/1859033002

Cr-Commit-Position: refs/heads/master@{#35258}

[modify] https://crrev.com/2e191cee8a61b80ef880c1f2469495441e6c9c86/src/debug/debug-evaluate.cc
[modify] https://crrev.com/2e191cee8a61b80ef880c1f2469495441e6c9c86/src/debug/debug-evaluate.h
[modify] https://crrev.com/2e191cee8a61b80ef880c1f2469495441e6c9c86/src/debug/debug-scopes.cc
[modify] https://crrev.com/2e191cee8a61b80ef880c1f2469495441e6c9c86/src/debug/debug-scopes.h
[modify] https://crrev.com/2e191cee8a61b80ef880c1f2469495441e6c9c86/src/factory.cc
[modify] https://crrev.com/2e191cee8a61b80ef880c1f2469495441e6c9c86/src/factory.h
[add] https://crrev.com/2e191cee8a61b80ef880c1f2469495441e6c9c86/test/mjsunit/debug-evaluate-nested.js

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79987c364131876e5eaf86ec95435b718ff02a7d

commit 79987c364131876e5eaf86ec95435b718ff02a7d
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Apr 07 07:00:23 2016

[DevTools] Remove crash expectation for debugger-save-to-temp-var.html

BUG= 599662 
TBR=dgozman@chromium.org

Review URL: https://codereview.chromium.org/1870593002

Cr-Commit-Position: refs/heads/master@{#385682}

[modify] https://crrev.com/79987c364131876e5eaf86ec95435b718ff02a7d/third_party/WebKit/LayoutTests/TestExpectations

Status: Fixed (was: Started)

Sign in to add a comment