Issue metadata
Sign in to add a comment
|
Shelf position keeps on changing on CROS |
||||||||||||||||||||||
Issue descriptionVersion 51.0.2688.0 dev (64-bit) Platform 8104.1.0 (Official Build) dev-channel samus Firmware Google_Samus.6300.174.0 What steps will reproduce the problem? (1) Set shelf position to left (2) Close screen on laptop to lock Pixel 2 (3) Open screen What is the expected output? Shelf should stay where it was before closing screen What do you see instead? Shelf default to bottom instead of left.
,
Apr 1 2016
,
Apr 1 2016
I am not sure why this is assigned to me, I don't work on Chrome OS UI anymore.
,
Apr 1 2016
glevin@ you mentioned that several recent regressions in the shelf were due to a recent refactoring. Do you have the CL for that?
,
Apr 1 2016
The CL I mentioned, https://codereview.chromium.org/1659283002/, only broke one thing that I'm aware of ( Issue 589194 ). Another similar problem, Issue 551712 , is unrelated, and has been around for years. I'll look into this one.
,
Apr 3 2016
#CBC-RS -TC-watchlist
,
Apr 4 2016
Also happens if you just lock the screen from the system menu. Happens on Linux desktop dev version, so probably happens on all devices.
,
Apr 5 2016
This appears to have been broken by this change to UpdateShelfVisibilityAfterLoginUIChange(): https://codereview.chromium.org/1812013003/diff/80001/ash/shelf/shelf_layout_manager.cc However, it seems to have just been fixed by a subsequent change, probably this one: https://codereview.chromium.org/1851883002/
,
Apr 5 2016
Sorry for the regression, but I'm glad that my subsequent CL fixed it. Please lmk if other issues arise; I should get pinged on UI>Shell>Shelf issues now.
,
Apr 12 2016
Verified on ChromeOS 8172.1.0, 51.0.2704.0 |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by keta...@chromium.org
, Mar 31 2016Owner: r...@chromium.org
Status: Assigned (was: Untriaged)