New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599640 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Repair job failed due to no attribute 'get_ec'

Project Member Reported by waihong@chromium.org, Mar 31 2016

Issue description

Repair job failed at:
https://pantheon.corp.google.com/storage/browser/chromeos-autotest-results/hosts/chromeos4-row3-rack8-host11/53163059-repair/debug/

03/31 07:27:02.594 ERROR|            repair:0397| Repair failed: Re-install the stable firmware
Traceback (most recent call last):
  File "/usr/local/autotest/client/common_lib/hosts/repair.py", line 395, in _repair_host
    self.repair(host)
  File "/usr/local/autotest/server/hosts/cros_repair.py", line 224, in repair
    host.firmware_install()
  File "/usr/local/autotest/server/hosts/cros_host.py", line 882, in firmware_install
    if self.get_ec():
AttributeError: 'chromeos4-row3-rack8-host11_host' object has no attribute 'get_ec'

Caused by the change:
  https://chromium-review.googlesource.com/328731

 
Labels: Infra-ChromeOS OS-Chrome
In the midst of validating the fix:

https://chromium-review.googlesource.com/#/c/336691/1
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/a328da6c1e8449e8e79564ec9d26088cd4755fec

commit a328da6c1e8449e8e79564ec9d26088cd4755fec
Author: Kevin Cheng <kevcheng@chromium.org>
Date: Thu Mar 31 17:49:04 2016

[autotest] Add back in old CrosHost label functions.

In my haste I didn't check tests were using those label methods as well.
I'm adding them back in as a quick fix (but keeping the new cros_label
methods as well).  Then I'll go back and fix up the tests to use the
label methods and then take these old cros label methods back out as
well.

BUG=chromium:599534
BUG= chromium:599640 
TEST=locally ran platform_InternalDisplay and forced a repair and both
jobs ran without hitting the errors currently encountered.

Change-Id: I5e84f690986a425029d030f15829712cdc8929d5
Reviewed-on: https://chromium-review.googlesource.com/336691
Commit-Ready: Kevin Cheng <kevcheng@chromium.org>
Tested-by: Kevin Cheng <kevcheng@chromium.org>
Reviewed-by: Kalin Stoyanov <kalin@chromium.org>
Reviewed-by: Kevin Cheng <kevcheng@chromium.org>

[modify] https://crrev.com/a328da6c1e8449e8e79564ec9d26088cd4755fec/server/hosts/cros_host.py

Status: Fixed (was: Assigned)

Comment 4 by ka...@chromium.org, Apr 5 2016

Labels: Merge-Request-50 M-51 M-50
Requesting merge to M-50.
Components: -OS>Firmware
Labels: -Merge-Request-50
No merge required.

Comment 6 by benhenry@google.com, Apr 27 2016

Components: Infra>Client>ChromeOS
Labels: -Infra-ChromeOS
Status: Verified (was: Fixed)
bulk verify (M50 clean up)

Sign in to add a comment