New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599593 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Add cookie jar mismatch state to sync commit messages

Project Member Reported by zea@chromium.org, Mar 31 2016

Issue description

If the currently signed in user does not have a valid cookie in the cookie jar, we report that on commit to denote that the user signed out of the content area.
 

Comment 1 by zea@chromium.org, Mar 31 2016

Labels: OS-All

Comment 2 by kolos@chromium.org, Apr 5 2016

Components: Privacy
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e

commit 3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e
Author: zea <zea@chromium.org>
Date: Tue Apr 05 18:21:12 2016

[Sync] Add cookie jar mismatch logging

Adds a listener to gaia cookie jar state, which plumbs that down into the
sync context. Cookie jar mismatch state is then sent up on every commit
message, which is then used server-side to ensure improve privacy.

BUG= 599593 

Review URL: https://codereview.chromium.org/1849563005

Cr-Commit-Position: refs/heads/master@{#385228}

[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/chrome/browser/sync/profile_sync_service_factory.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/components/browser_sync/browser/profile_sync_service.h
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/components/sync_driver/glue/sync_backend_host.h
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/components/sync_driver/glue/sync_backend_host_core.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/components/sync_driver/glue/sync_backend_host_core.h
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/components/sync_driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/components/sync_driver/glue/sync_backend_host_impl.h
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/components/sync_driver/glue/sync_backend_host_mock.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/components/sync_driver/glue/sync_backend_host_mock.h
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/engine/commit.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/engine/commit.h
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/engine/commit_util.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/engine/commit_util.h
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/engine/syncer.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/internal_api/public/sync_manager.h
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/internal_api/public/test/fake_sync_manager.h
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/internal_api/sync_manager_impl.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/internal_api/sync_manager_impl.h
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/internal_api/test/fake_sync_manager.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/protocol/proto_value_conversions.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/protocol/sync.proto
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/sessions/sync_session_context.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/sessions/sync_session_context.h
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/test/fake_server/fake_server.cc
[modify] https://crrev.com/3dfdc8754310e28ab5380cbdff39dc08dbc5fd4e/sync/test/fake_server/fake_server.h

Comment 4 by zea@chromium.org, Apr 5 2016

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/41ee49d233b7dd996f7322b119a22852832dd7e3

commit 41ee49d233b7dd996f7322b119a22852832dd7e3
Author: zea <zea@chromium.org>
Date: Thu May 19 01:06:51 2016

[Sync] Add histograms for cookie jar state on Sessions commit

On every SESSIONS entity commit, record whether the cookie jar matches
the signed in user. If it doesn't, record also whether the cookie jar was
empty or not.

BUG= 599593 

Review-Url: https://codereview.chromium.org/1991973002
Cr-Commit-Position: refs/heads/master@{#394624}

[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/components/browser_sync/browser/profile_sync_service.cc
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/components/sync_driver/glue/sync_backend_host.h
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/components/sync_driver/glue/sync_backend_host_core.cc
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/components/sync_driver/glue/sync_backend_host_core.h
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/components/sync_driver/glue/sync_backend_host_impl.cc
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/components/sync_driver/glue/sync_backend_host_impl.h
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/components/sync_driver/glue/sync_backend_host_mock.cc
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/components/sync_driver/glue/sync_backend_host_mock.h
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/sync/engine/commit.cc
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/sync/engine/commit.h
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/sync/engine/commit_processor.cc
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/sync/engine/commit_processor.h
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/sync/engine/syncer.cc
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/sync/internal_api/public/sync_manager.h
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/sync/internal_api/public/test/fake_sync_manager.h
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/sync/internal_api/sync_manager_impl.cc
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/sync/internal_api/sync_manager_impl.h
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/sync/internal_api/test/fake_sync_manager.cc
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/sync/sessions/sync_session_context.cc
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/sync/sessions/sync_session_context.h
[modify] https://crrev.com/41ee49d233b7dd996f7322b119a22852832dd7e3/tools/metrics/histograms/histograms.xml

Sign in to add a comment