New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599586 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Feature

Blocking:
issue 455847



Sign in to add a comment

Implement UMA log throttling for cellular connections on Android

Project Member Reported by gayane@chromium.org, Mar 31 2016

Issue description

Implement UMA log throttling for cellular connections on Android.

For enabling UMA on cellular implement throttling logic to UMA uploads for cellular connections that take into account the weekly data usage of UMA on cellular as well as the ratio of UMA data usage over overall Chrome data traffic.
 

Comment 1 by gayane@chromium.org, Mar 31 2016

Labels: -Pri-3 Pri-2
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b46091cb37b8fdd73a02675e2ab86850d51cb09

commit 0b46091cb37b8fdd73a02675e2ab86850d51cb09
Author: gayane <gayane@chromium.org>
Date: Thu Apr 07 21:01:05 2016

Implement UMA log throttling for cellular connections.

For enabling UMA on cellular, a throttling logic is implemented that takes into account the weekly data usage of UMA on cellular as well as the ratio of UMA data usage over overall Chrome data traffic.

For tracking UMA data use and overall Chrome data traffic we use DataUseMeasurement class which already collects and reports similar data.

The allowed weekly UMA quota and UMA ratio are passed through as variation param.

BUG= 599586 

Review URL: https://codereview.chromium.org/1818613002

Cr-Commit-Position: refs/heads/master@{#385845}

[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/chrome/browser/io_thread.cc
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/chrome/browser/io_thread.h
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/chrome/browser/metrics/chrome_metrics_service_client.h
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/chrome/browser/net/chrome_network_delegate.cc
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/chrome/browser/net/chrome_network_delegate.h
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/chrome/browser/net/chrome_network_delegate_unittest.cc
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/chrome/browser/profiles/profile_io_data.cc
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/components_tests.gyp
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/data_use_measurement/content/BUILD.gn
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/data_use_measurement/content/DEPS
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/data_use_measurement/content/data_use_measurement.cc
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/data_use_measurement/content/data_use_measurement.h
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/data_use_measurement/content/data_use_measurement_unittest.cc
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/metrics.gypi
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/metrics/BUILD.gn
[add] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/metrics/data_use_tracker.cc
[add] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/metrics/data_use_tracker.h
[add] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/metrics/data_use_tracker_unittest.cc
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/metrics/metrics_pref_names.cc
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/metrics/metrics_pref_names.h
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/metrics/metrics_service.cc
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/metrics/metrics_service.h
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/metrics/metrics_service_client.cc
[modify] https://crrev.com/0b46091cb37b8fdd73a02675e2ab86850d51cb09/components/metrics/metrics_service_client.h

Project Member

Comment 3 by bugdroid1@chromium.org, Apr 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0417f978064cbeda802b99b21a88d126c66ff4da

commit 0417f978064cbeda802b99b21a88d126c66ff4da
Author: gayane <gayane@chromium.org>
Date: Mon Apr 11 19:34:06 2016

Add histograms for observing UMA throttling effect.

Added a histogram for counting number of events when UMA log was not uploaded due to throttling and one more for counting number of dropped UMA logs.

Also, delete a histogram recording a connection type and actualy upload interval used to upload the previous UMA log which is not needed as we are done with the analysis of UMA logs on cellular.

BUG= 599586 

Review URL: https://codereview.chromium.org/1871733002

Cr-Commit-Position: refs/heads/master@{#386440}

[modify] https://crrev.com/0417f978064cbeda802b99b21a88d126c66ff4da/components/metrics/metrics_service.cc
[modify] https://crrev.com/0417f978064cbeda802b99b21a88d126c66ff4da/components/metrics/net/net_metrics_log_uploader.cc
[modify] https://crrev.com/0417f978064cbeda802b99b21a88d126c66ff4da/components/metrics/persisted_logs.cc
[modify] https://crrev.com/0417f978064cbeda802b99b21a88d126c66ff4da/tools/metrics/histograms/histograms.xml

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fd6ee9f61a7a9dd4d272358091b4f5dc68ee0d0

commit 2fd6ee9f61a7a9dd4d272358091b4f5dc68ee0d0
Author: gayane <gayane@chromium.org>
Date: Mon Apr 11 21:10:32 2016

Add uma_quota and uma_ratio to UMA_EnabledCelullarLogUpload fieldtrial testing

BUG= 599586 

Review URL: https://codereview.chromium.org/1875123003

Cr-Commit-Position: refs/heads/master@{#386472}

[modify] https://crrev.com/2fd6ee9f61a7a9dd4d272358091b4f5dc68ee0d0/testing/variations/fieldtrial_testing_config_android.json

Comment 5 by gayane@chromium.org, Apr 29 2016

Status: Fixed (was: Assigned)

Sign in to add a comment