New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599578 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 613033
Owner:
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

gn check //media fails

Project Member Reported by dalecur...@chromium.org, Mar 31 2016

Issue description

Per brettw@'s talk the other day we should get this passing for media. The primary failures are:
- cdm
- gles2 includes by skia, gpu mem bufs, and gpu accelerator factories.

dalecurtis@xorax /d/code/chrome/src $ gn check out/Release //media/
ERROR at //media/cdm/cdm_adapter.cc:30:11: Include not allowed.
#include "media/cdm/cdm_wrapper.h"
          ^----------------------
It is not in any dependency of
  //media:media
The include file is in the target(s):
  //media/cdm/ppapi:clearkeycdmadapter
which should somehow be reachable.
___________________
ERROR at //media/cdm/cdm_adapter.h:28:11: Include not allowed.
#include "media/cdm/api/content_decryption_module.h"
          ^----------------------------------------
It is not in any dependency of
  //media:media
The include file is in the target(s):
  //media/cdm/ppapi:clearkeycdmadapter
which should somehow be reachable.
___________________
ERROR at //media/cdm/cdm_helpers.cc:9:11: Include not allowed.
#include "ppapi/cpp/logging.h"
          ^------------------
It is not in any dependency of
  //media:media
The include file is in the target(s):
  //ppapi:ppapi_cpp_lib
  //ppapi/cpp:objects
at least one of which should somehow be reachable.
___________________
ERROR at //media/cdm/cdm_helpers.h:12:11: Include not allowed.
#include "media/cdm/api/content_decryption_module.h"
          ^----------------------------------------
It is not in any dependency of
  //media:media
The include file is in the target(s):
  //media/cdm/ppapi:clearkeycdmadapter
which should somehow be reachable.
___________________
ERROR at //media/cdm/supported_cdm_versions.cc:7:11: Include not allowed.
#include "media/cdm/api/content_decryption_module.h"
          ^----------------------------------------
It is not in any dependency of
  //media:media
The include file is in the target(s):
  //media/cdm/ppapi:clearkeycdmadapter
which should somehow be reachable.
___________________
ERROR at //media/renderers/gpu_video_accelerator_factories.h:16:11: Include not allowed.
#include "gpu/command_buffer/client/gles2_interface.h"
          ^------------------------------------------
It is not in any dependency of
  //media:media
The include file is in the target(s):
  //gpu/command_buffer/client:gles2_interface
which should somehow be reachable.
___________________
ERROR at //media/renderers/skcanvas_video_renderer.cc:11:11: Include not allowed.
#include "gpu/command_buffer/client/gles2_interface.h"
          ^------------------------------------------
It is not in any dependency of
  //media:media
The include file is in the target(s):
  //gpu/command_buffer/client:gles2_interface
which should somehow be reachable.
___________________
ERROR at //media/video/gpu_memory_buffer_video_frame_pool.cc:26:11: Include not allowed.
#include "gpu/command_buffer/client/gles2_interface.h"
          ^------------------------------------------
It is not in any dependency of
  //media:media
The include file is in the target(s):
  //gpu/command_buffer/client:gles2_interface
which should somehow be reachable.

 

Comment 1 by xhw...@chromium.org, Mar 31 2016

Cc: jrumm...@chromium.org
+jrummell for the "cdm" part. Since we don't need these files on all platforms, probably we should move them to a new source_set, and let "media" conditionally depend on it. Then in the new source_set, we should fix the missing dependencies.


If it's OK to make media depend on ui/gl, crrev.com/1848013002 should fix GL related checks.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aca7d36ab07e8e26dcc9044ec8f23883b4b322e2

commit aca7d36ab07e8e26dcc9044ec8f23883b4b322e2
Author: dcastagna <dcastagna@chromium.org>
Date: Thu Mar 31 20:56:39 2016

media: Add gles2_interface and ui/gl as explicit dependencies.

BUG= 599578 

Review URL: https://codereview.chromium.org/1848013002

Cr-Commit-Position: refs/heads/master@{#384381}

[modify] https://crrev.com/aca7d36ab07e8e26dcc9044ec8f23883b4b322e2/media/BUILD.gn

Owner: jrumm...@chromium.org
Status: Assigned (was: Available)
jrummell: Could you please take a look at the CDM part?
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1de29c2258ed6b536ebb61e4c365ef22b84d5042

commit 1de29c2258ed6b536ebb61e4c365ef22b84d5042
Author: xhwang <xhwang@chromium.org>
Date: Tue Apr 05 05:54:13 2016

media: Fix gn deps on media/mojo/ targets.

gn check out/GN media/mojo/services:* is green now.

BUG= 599578 

Review URL: https://codereview.chromium.org/1847823006

Cr-Commit-Position: refs/heads/master@{#385111}

[modify] https://crrev.com/1de29c2258ed6b536ebb61e4c365ef22b84d5042/media/mojo/services/BUILD.gn
[modify] https://crrev.com/1de29c2258ed6b536ebb61e4c365ef22b84d5042/media/mojo/services/mojo_media_application_factory.cc

Labels: Hotlist-CodeHealth
"gn check //media" now reports "Header dependency check OK". However, if I uncomment the line in src/.gn that ignores the media directory, I get 426 errors (running "gn gen out/GN --check"). So there is a lot more to go.

media/audio: 102
media/base: 157
media/capture: 21
media/cast: 128
media/cdm: 10
media/ffmpeg: 1
media/gpu: 3
media/mojo: 2
media/renderers: 1
media/test: 1



Components: Build
Labels: -Proj-GN-Migration
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d87dca61001bcad07db8e996435731b0ffe65bd

commit 6d87dca61001bcad07db8e996435731b0ffe65bd
Author: jrummell <jrummell@chromium.org>
Date: Thu Apr 21 00:16:31 2016

media: Fix gn deps on media/base/ targets

Add some needed dependencies.

BUG= 599578 

Review URL: https://codereview.chromium.org/1902493002

Cr-Commit-Position: refs/heads/master@{#388620}

[modify] https://crrev.com/6d87dca61001bcad07db8e996435731b0ffe65bd/media/base/BUILD.gn

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d

commit 37a54c0afbdd2105f0440d6dd730dfedc2f6c91d
Author: jrummell <jrummell@chromium.org>
Date: Fri Apr 22 19:54:27 2016

media: Move audio_parameters and audio_point to media/base/

These 2 files are used in lots of places and should be in media/base/
to clean up some dependency issues (as noted by gn check).

BUG= 599578 
TEST=compiles with gn and gyp

Review URL: https://codereview.chromium.org/1907973003

Cr-Commit-Position: refs/heads/master@{#389216}

[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/chrome/browser/copresence/chrome_whispernet_client.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/chrome/browser/copresence/chrome_whispernet_client_browsertest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/chrome/browser/media/webrtc_audio_quality_browsertest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/chrome/browser/media/webrtc_browsertest_audio.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/chrome/renderer/extensions/cast_streaming_native_handler.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/chrome/renderer/media/cast_receiver_audio_valve.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/chrome/renderer/media/cast_rtp_stream.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/chromecast/media/audio/cast_audio_output_stream.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/components/audio_modem/audio_player_impl.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/components/audio_modem/audio_recorder.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/components/audio_modem/audio_recorder_impl.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/browser/media/capture/audio_mirroring_manager_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/browser/media/media_internals.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/browser/media/media_internals_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/browser/renderer_host/media/audio_input_debug_writer.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/browser/renderer_host/media/audio_input_device_manager.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/browser/renderer_host/media/audio_input_sync_writer.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/browser/renderer_host/media/audio_input_sync_writer_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/browser/renderer_host/media/audio_output_device_enumerator.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/browser/renderer_host/media/audio_sync_reader.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/browser/renderer_host/media/media_stream_manager.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/browser/renderer_host/render_message_filter.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/browser/renderer_host/render_message_filter.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/common/media/audio_messages.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/common/media/media_param_traits.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/common/speech_recognition_messages.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/common/view_messages.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/public/common/DEPS
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/public/common/media_stream_request.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/audio_renderer_mixer_manager.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/audio_renderer_mixer_manager_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/audio_track_recorder.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/media_recorder_handler.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/media_stream_audio_processor.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/media_stream_audio_processor_options.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/media_stream_audio_processor_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/media_stream_audio_sink_owner.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/media_stream_audio_track_sink.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/media_stream_dispatcher.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/media_stream_dispatcher_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/media_stream_track.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/renderer_webaudiodevice_impl.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/speech_recognition_audio_sink.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/speech_recognition_audio_sink.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/speech_recognition_audio_sink_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/webaudio_capturer_source.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/webrtc/webrtc_audio_sink_adapter.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/webrtc_audio_capturer_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/webrtc_audio_device_impl.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/webrtc_audio_renderer.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/webrtc_local_audio_source_provider.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/webrtc_local_audio_source_provider_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/webrtc_local_audio_track.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/media/webrtc_local_audio_track_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/pepper/pepper_media_stream_audio_track_host.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/renderer/pepper/pepper_platform_audio_input.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/BUILD.gn
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/BUILD.gn
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/alsa/alsa_input.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/alsa/alsa_output.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/alsa/audio_manager_alsa.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/android/audio_manager_android.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/android/audio_record_input.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/android/opensles_input.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/android/opensles_output.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/audio_device_thread.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/audio_input_controller.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/audio_input_device.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/audio_input_ipc.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/audio_manager.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/audio_output_controller_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/audio_output_device.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/audio_output_dispatcher.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/audio_output_dispatcher_impl.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/audio_output_ipc.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/audio_output_proxy.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/audio_output_resampler.h
[delete] https://crrev.com/03a223eedbd93d09914166fd9997c7d50049daa0/media/audio/audio_parameters_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/cras/cras_input.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/cras/cras_unified.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/fake_audio_input_stream.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/fake_audio_output_stream.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/fake_audio_worker.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/fake_audio_worker_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/mac/audio_auhal_mac.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/mac/audio_input_mac.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/mac/audio_low_latency_input_mac.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/mac/audio_manager_mac.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/mock_audio_manager.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/pulse/audio_manager_pulse.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/pulse/pulse_input.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/pulse/pulse_output.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/pulse/pulse_util.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/simple_sources_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/sounds/audio_stream_handler.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/test_audio_input_controller_factory.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/virtual_audio_input_stream.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/virtual_audio_output_stream.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/win/audio_low_latency_input_win.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/win/audio_low_latency_output_win.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/win/audio_manager_win.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/win/core_audio_util_win.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/win/wavein_input_win.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/audio/win/waveout_output_win.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/BUILD.gn
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_buffer_converter.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_bus.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_bus_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_capturer_source.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_converter.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_hardware_config.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_hardware_config_unittest.cc
[rename] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_parameters.cc
[rename] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_parameters.h
[add] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_parameters_unittest.cc
[rename] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_point.cc
[rename] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_point.h
[rename] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_point_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_renderer_sink.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/audio_splicer.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/channel_mixer.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/channel_mixer_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/fake_audio_renderer_sink.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/mock_audio_renderer_sink.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/output_device_info.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/base/test_helpers.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/blink/webaudiosourceprovider_impl_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/cast/test/fake_media_source.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/cast/test/receiver.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/filters/audio_renderer_algorithm.h
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/media.gyp
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/muxers/webm_muxer.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/muxers/webm_muxer_unittest.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/media/shared_memory_support.gypi
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/ppapi/proxy/audio_input_resource.cc
[modify] https://crrev.com/37a54c0afbdd2105f0440d6dd730dfedc2f6c91d/ppapi/shared_impl/ppb_audio_shared.cc

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 28 2016

Cc: servolk@chromium.org
I suspect that the use of the new 'media_features' header is making it much more important to get this fixed, as we're seeing build flakes caused by missing dependencies, e.g.:

https://build.chromium.org/p/chromium/builders/Win/builds/42984

where it looks like both //media and //media/base should probably be specifying dependencies on //media:features .
Ignore comment #13, since the Win builder is using GYP and, from what I can tell, the media targets do actually specify the right dependencies.

Still, we should finishing getting --check working ;).
Project Member

Comment 15 by bugdroid1@chromium.org, May 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c18e5fe9d86ffbea6765a5bc30860cb342ef18c5

commit c18e5fe9d86ffbea6765a5bc30860cb342ef18c5
Author: jrummell <jrummell@chromium.org>
Date: Tue May 03 21:41:53 2016

media: Fix gn deps on media/base/* targets

Add some needed dependencies.

BUG= 599578 

Review-Url: https://codereview.chromium.org/1919613002
Cr-Commit-Position: refs/heads/master@{#391363}

[modify] https://crrev.com/c18e5fe9d86ffbea6765a5bc30860cb342ef18c5/media/base/BUILD.gn

Project Member

Comment 16 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/06fd5358c211fde408898e1ee9444dcf67071575

commit 06fd5358c211fde408898e1ee9444dcf67071575
Author: jrummell <jrummell@chromium.org>
Date: Thu May 05 19:01:57 2016

media: Fix gn deps on media/base/win/ targets

Add some needed dependencies.

BUG= 599578 

Review-Url: https://codereview.chromium.org/1953633002
Cr-Commit-Position: refs/heads/master@{#391862}

[modify] https://crrev.com/06fd5358c211fde408898e1ee9444dcf67071575/media/base/win/BUILD.gn

Project Member

Comment 18 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d84a72067b279a3003783c9ed884452c20ecfd29

commit d84a72067b279a3003783c9ed884452c20ecfd29
Author: jrummell <jrummell@chromium.org>
Date: Thu May 12 02:11:05 2016

media: Fix gn deps on media/audio/* targets

Add some needed dependencies.

BUG= 599578 
TEST=gn check //media/audio/* is clean

Review-Url: https://codereview.chromium.org/1965713003
Cr-Commit-Position: refs/heads/master@{#393149}

[modify] https://crrev.com/d84a72067b279a3003783c9ed884452c20ecfd29/media/audio/BUILD.gn

Project Member

Comment 19 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42b0b771604e7aacfe8518382b7fb1a0170aae58

commit 42b0b771604e7aacfe8518382b7fb1a0170aae58
Author: jrummell <jrummell@chromium.org>
Date: Thu May 12 02:32:46 2016

media: Fix gn deps on media/cdm/ppapi/* targets

Add some needed dependencies.

BUG= 599578 
TEST=gn check //media/cdm/* is clean

Review-Url: https://codereview.chromium.org/1969533002
Cr-Commit-Position: refs/heads/master@{#393155}

[modify] https://crrev.com/42b0b771604e7aacfe8518382b7fb1a0170aae58/media/cdm/ppapi/BUILD.gn

Project Member

Comment 20 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5abb1019976cd9c7e4a62fae9d61a06856388304

commit 5abb1019976cd9c7e4a62fae9d61a06856388304
Author: jrummell <jrummell@chromium.org>
Date: Fri May 13 00:20:10 2016

media: Fix gn deps on media/gpu/* targets

Add an missing dependency.

BUG= 599578 
TEST=gn check //media/gpu/* is clean

Review-Url: https://codereview.chromium.org/1973863005
Cr-Commit-Position: refs/heads/master@{#393405}

[modify] https://crrev.com/5abb1019976cd9c7e4a62fae9d61a06856388304/media/gpu/ipc/client/BUILD.gn

Project Member

Comment 21 by bugdroid1@chromium.org, May 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9864f223dead50dee4dd368c8e53b95a70cfb012

commit 9864f223dead50dee4dd368c8e53b95a70cfb012
Author: jrummell <jrummell@chromium.org>
Date: Fri May 13 00:20:42 2016

media: Fix gn deps on media/test/* targets

Add missing dependencies.

BUG= 599578 
TEST=gn check //media/test/* is clean

Review-Url: https://codereview.chromium.org/1972923003
Cr-Commit-Position: refs/heads/master@{#393406}

[modify] https://crrev.com/9864f223dead50dee4dd368c8e53b95a70cfb012/media/test/BUILD.gn

Project Member

Comment 22 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ff5345b15ad151adf2b417d45f0ec4b57fcacf5

commit 6ff5345b15ad151adf2b417d45f0ec4b57fcacf5
Author: jrummell <jrummell@chromium.org>
Date: Thu May 19 23:21:30 2016

media: Fix gn deps on media/gpu/* targets

Add more missing dependencies for Windows builds.

BUG= 599578 
TEST=gn check //media/gpu/* is clean on Windows

Review-Url: https://codereview.chromium.org/1992583002
Cr-Commit-Position: refs/heads/master@{#394901}

[modify] https://crrev.com/6ff5345b15ad151adf2b417d45f0ec4b57fcacf5/media/gpu/BUILD.gn
[modify] https://crrev.com/6ff5345b15ad151adf2b417d45f0ec4b57fcacf5/media/gpu/ipc/common/BUILD.gn

Project Member

Comment 23 by bugdroid1@chromium.org, May 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7874964a97a3545ee09995621dc964c05ea7db9f

commit 7874964a97a3545ee09995621dc964c05ea7db9f
Author: jrummell <jrummell@chromium.org>
Date: Fri May 20 02:45:07 2016

media: Fix gn deps on media/ targets

Add some needed dependencies for the files in media/filters.

BUG= 599578 
TEST=gn check //media/base/* is clean

Review-Url: https://codereview.chromium.org/1964963002
Cr-Commit-Position: refs/heads/master@{#394966}

[modify] https://crrev.com/7874964a97a3545ee09995621dc964c05ea7db9f/media/BUILD.gn
[modify] https://crrev.com/7874964a97a3545ee09995621dc964c05ea7db9f/media/base/BUILD.gn

Project Member

Comment 25 by bugdroid1@chromium.org, Jun 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/370e8f900c9d7379319a8f04b6c6bad7eae86bd2

commit 370e8f900c9d7379319a8f04b6c6bad7eae86bd2
Author: jrummell <jrummell@chromium.org>
Date: Thu Jun 02 19:16:27 2016

Enable gn check of some //media files

Now that some subdirectories are clean, prevent regressions.

BUG= 599578 

Review-Url: https://codereview.chromium.org/1983503002
Cr-Commit-Position: refs/heads/master@{#397486}

[modify] https://crrev.com/370e8f900c9d7379319a8f04b6c6bad7eae86bd2/.gn

Project Member

Comment 26 by bugdroid1@chromium.org, Oct 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5216c61da3efaa82761756b4a78fb13351f35452

commit 5216c61da3efaa82761756b4a78fb13351f35452
Author: jrummell <jrummell@chromium.org>
Date: Thu Oct 06 01:30:30 2016

media: Fix gn deps on //media/test

BUG= 599578 
TEST=gn check //media/test/* is clean

Review-Url: https://codereview.chromium.org/2387063004
Cr-Commit-Position: refs/heads/master@{#423380}

[modify] https://crrev.com/5216c61da3efaa82761756b4a78fb13351f35452/.gn
[modify] https://crrev.com/5216c61da3efaa82761756b4a78fb13351f35452/media/test/BUILD.gn

Project Member

Comment 27 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5216c61da3efaa82761756b4a78fb13351f35452

commit 5216c61da3efaa82761756b4a78fb13351f35452
Author: jrummell <jrummell@chromium.org>
Date: Thu Oct 06 01:30:30 2016

media: Fix gn deps on //media/test

BUG= 599578 
TEST=gn check //media/test/* is clean

Review-Url: https://codereview.chromium.org/2387063004
Cr-Commit-Position: refs/heads/master@{#423380}

[modify] https://crrev.com/5216c61da3efaa82761756b4a78fb13351f35452/.gn
[modify] https://crrev.com/5216c61da3efaa82761756b4a78fb13351f35452/media/test/BUILD.gn

Comment 28 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 29 by bugdroid1@chromium.org, Nov 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5efed7b22c6fd37f646333085257edc9becd9586

commit 5efed7b22c6fd37f646333085257edc9becd9586
Author: xhwang <xhwang@chromium.org>
Date: Thu Nov 10 21:18:29 2016

media: Set stricter visibility for //media/base

Target //media/base is a source set. Having targets depending on it (and
quite often depending on //media as well) could easily cause duplicated
symbols. This has been seen in multiple codereviews recently.

This CL make the visibility rule stricter to avoid this issue.

BUG= 599578 
R=watk@chromium.org

Review-Url: https://codereview.chromium.org/2491603003
Cr-Commit-Position: refs/heads/master@{#431356}

[modify] https://crrev.com/5efed7b22c6fd37f646333085257edc9becd9586/media/base/BUILD.gn

Project Member

Comment 30 by bugdroid1@chromium.org, Nov 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09f35d95e99f3284a3a483fd0356704b009ccdf1

commit 09f35d95e99f3284a3a483fd0356704b009ccdf1
Author: xhwang <xhwang@chromium.org>
Date: Fri Nov 11 18:12:18 2016

media remoting: Fix gn deps

Also enable "gn check" on //media/remoting/*

BUG= 599578 ,643964

Review-Url: https://codereview.chromium.org/2495553003
Cr-Commit-Position: refs/heads/master@{#431596}

[modify] https://crrev.com/09f35d95e99f3284a3a483fd0356704b009ccdf1/.gn
[modify] https://crrev.com/09f35d95e99f3284a3a483fd0356704b009ccdf1/media/remoting/BUILD.gn

Mergedinto: 613033
Status: Duplicate (was: Assigned)
Remaining changes have been done fixing  issue 613033 .

Sign in to add a comment