New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599558 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Last visit > 30 days ago
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocked on:
issue 548440

Blocking:
issue 580601



Sign in to add a comment

NativeWidgetMus Tooltip Support

Project Member Reported by jonr...@chromium.org, Mar 31 2016

Issue description

Once mus supports generic tooltips, NativeWidgetMus will need to provide views access to a tooltip manager.
  - GetTooltipManager

This should set the appropriate property on the mus::Window.

Either mus or the wm will be responsible for the tooltips themselves

 
Components: MUS

Comment 2 by e...@chromium.org, Sep 29 2016

Owner: e...@chromium.org
Status: Assigned (was: Available)

Comment 4 by e...@chromium.org, Oct 3 2016

Status: Fixed (was: Assigned)

Comment 5 by e...@chromium.org, Oct 3 2016

Status: Assigned (was: Fixed)

Comment 6 by sky@chromium.org, Oct 3 2016

Here's the failure I was seeing:

[ RUN      ] TooltipControllerCaptureTest.Capture
[27251:27255:1003/162912:2357809112935:INFO:child_process_host.cc(202)] Launched child process pid=27258, instance=tracing, name=mojo:tracing, user_id=b82d7844-e49\
7-460b-8b11-2a7439005581
[27251:27255:1003/162912:2357809129019:INFO:child_process_host.cc(202)] Launched child process pid=27259, instance=test_wm, name=mojo:test_wm, user_id=505C0EE9-301\
3-43C0-82B0-A84F50CF8D84
[27251:27255:1003/162912:2357809132553:INFO:child_process_host.cc(202)] Launched child process pid=27260, instance=ui, name=mojo:ui, user_id=902bfc80-d051-4650-9e8\
e-30b052629e4f
[27258:27258:1003/162912:2357809265739:ERROR:interface_registry.cc(99)] Capability spec prevented service mojo:ui from binding interface: tracing::mojom::Factory
[27251:27255:1003/162912:2357809281546:INFO:child_process_host.cc(202)] Launched child process pid=27282, instance=test_ime_driver, name=mojo:test_ime_driver, user\
_id=902bfc80-d051-4650-9e8e-30b052629e4f
[27251:27251:1003/162913:2357809300487:ERROR:screen_base.cc(59)] Not implemented reached in virtual display::Display display::ScreenBase::GetDisplayNearestWindow(g\
fx::NativeView) const
[27251:27251:1003/162913:2357809312251:ERROR:screen_base.cc(49)] Not implemented reached in virtual gfx::NativeWindow display::ScreenBase::GetWindowAtScreenPoint(c\
onst gfx::Point &)
../../ui/views/corewm/tooltip_controller_unittest.cc:526: Failure
Value of: helper_->GetTooltipText()
  Actual:
Expected: tooltip_text2
Which is: 2
[  FAILED  ] TooltipControllerCaptureTest.Capture (328 ms)

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ccdf89dbfb4278abaef1ba452984b3c3e676e22b

commit ccdf89dbfb4278abaef1ba452984b3c3e676e22b
Author: erg <erg@chromium.org>
Date: Mon Oct 03 23:38:09 2016

Revert of mus: Use TooltipManagerAura in NativeWidgetMus. (patchset #9 id:160001 of https://codereview.chromium.org/2379073003/ )

Reason for revert:
sky@ reports that TooltipControllerCaptureTest.Capture is failing on local chromeos builds.

Original issue's description:
> mus: Use TooltipManagerAura in NativeWidgetMus.
>
> mash now shows tooltips on hover over items.
>
> BUG= 599558 
>
> Committed: https://crrev.com/1b3d5f1878974c14c21a29a13a93ef630c74d1f6
> Cr-Commit-Position: refs/heads/master@{#422562}

TBR=sky@chromium.org,jonross@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 599558 

Review-Url: https://codereview.chromium.org/2384083005
Cr-Commit-Position: refs/heads/master@{#422599}

[modify] https://crrev.com/ccdf89dbfb4278abaef1ba452984b3c3e676e22b/ui/views/BUILD.gn
[modify] https://crrev.com/ccdf89dbfb4278abaef1ba452984b3c3e676e22b/ui/views/corewm/DEPS
[modify] https://crrev.com/ccdf89dbfb4278abaef1ba452984b3c3e676e22b/ui/views/corewm/tooltip_controller_unittest.cc
[modify] https://crrev.com/ccdf89dbfb4278abaef1ba452984b3c3e676e22b/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/ccdf89dbfb4278abaef1ba452984b3c3e676e22b/ui/views/mus/native_widget_mus.h
[modify] https://crrev.com/ccdf89dbfb4278abaef1ba452984b3c3e676e22b/ui/views/widget/tooltip_manager_aura.h

Components: Internals>MUS
Labels: Proj-Mustash
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636

commit c60b24dc5fe1bd688177d5a6cd53bafd36a5c636
Author: erg <erg@chromium.org>
Date: Fri Oct 07 21:29:56 2016

[reland] mus: Use TooltipManagerAura in NativeWidgetMus.

This reland fixes the implementation of NativeWidgetMus::
{Get,Set}NativeWindowProperty. corewm code assumes that properties that
get set on a Widget get set on that Widget's NativeWidget's aura content
window.

It also implements ScreenMus::GetWindowAtScreenPoint(), which is used to
resolve if a window in the current application has capture.

BUG= 599558 
First Review Url: https://codereview.chromium.org/2379073003

Review-Url: https://codereview.chromium.org/2392063003
Cr-Commit-Position: refs/heads/master@{#423970}

[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/services/ui/public/cpp/BUILD.gn
[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/BUILD.gn
[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/corewm/DEPS
[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/corewm/tooltip_controller_unittest.cc
[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/mus/BUILD.gn
[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/mus/native_widget_mus.cc
[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/mus/native_widget_mus.h
[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/mus/screen_mus.cc
[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/mus/screen_mus.h
[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/mus/screen_mus_delegate.h
[add] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/mus/test_utils.h
[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/mus/window_manager_connection.cc
[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/mus/window_manager_connection.h
[add] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/mus/window_manager_connection_unittest.cc
[modify] https://crrev.com/c60b24dc5fe1bd688177d5a6cd53bafd36a5c636/ui/views/widget/tooltip_manager_aura.h

Comment 10 by e...@chromium.org, Oct 12 2016

Status: Fixed (was: Assigned)

Comment 11 by dchan@google.com, Jan 21 2017

Labels: VerifyIn-57

Comment 12 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 13 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 14 by dchan@google.com, May 30 2017

Labels: VerifyIn-60
Labels: VerifyIn-61

Comment 16 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment