New issue
Advanced search Search tips

Issue 599552 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 580601



Sign in to add a comment

NativeWidgetMus Focus and Activation Support

Project Member Reported by jonr...@chromium.org, Mar 31 2016

Issue description

Currently NativeWidgetMus supports activation via an application of focus on mus::Window. We need to implement the remainder of activation and focus methods.
  -  Deactivate
  -  IsActive
  -  ClearNativeFocus

We plan to have activation map to focus for mus.

 

Comment 1 by sky@chromium.org, Apr 5 2016

Owner: sky@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe2dda84ac99039a639e6be859ce087474cad166

commit fe2dda84ac99039a639e6be859ce087474cad166
Author: sky <sky@chromium.org>
Date: Wed Apr 06 20:37:40 2016

Makes WindowTree::SetFocus(null) work

We need this so clients can clear focus as necessary.

BUG= 599552 
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/1862853002

Cr-Commit-Position: refs/heads/master@{#385550}

[modify] https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166/components/mus/public/cpp/lib/window_tree_client_impl.cc
[modify] https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166/components/mus/public/cpp/lib/window_tree_client_impl.h
[modify] https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166/components/mus/public/cpp/window.h
[modify] https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166/components/mus/public/cpp/window_tree_connection.h
[modify] https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166/components/mus/public/interfaces/window_tree.mojom
[modify] https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166/components/mus/ws/default_access_policy.cc
[modify] https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166/components/mus/ws/window_manager_client_unittest.cc
[modify] https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166/components/mus/ws/window_server.cc
[modify] https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166/components/mus/ws/window_server.h
[modify] https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166/components/mus/ws/window_tree.cc
[modify] https://crrev.com/fe2dda84ac99039a639e6be859ce087474cad166/ui/views/mus/native_widget_mus.cc

It looks like between #2, https://codereview.chromium.org/1968133002, & https://codereview.chromium.org/2049723002 that this issue is resolved.

Were we planning any more work here?

Comment 4 by sky@chromium.org, Jun 22 2016

Status: Fixed (was: Started)
Yes, this is done now.
Components: -MUS Internals>Services>WindowService

Sign in to add a comment