Building the remoting iOS app inside of chromium fails with the following:


[3337/4821] OBJCXX obj/third_party/webrtc/base/objc/rtc_base_objc.RTCFileLogger.o
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/webrtc/base/objc/rtc_base_objc.RTCFileLogger.o.d -DV8_DEPRECATION_WARNINGS -DCLD_VERSION=2 -DDISABLE_NACL -DCHROMIUM_BUILD -DCR_CLANG_REVISION=264334-1 -DUSE_LIBJPEG_TURBO=1 -DENABLE_WEBRTC=1 -DFIELDTRIAL_TESTING_ENABLED -DDISABLE_FTP_SUPPORT=1 -DV8_USE_EXTERNAL_STARTUP_DATA -DWEBRTC_RESTRICT_LOGGING -DEXPAT_RELATIVE_PATH -DWEBRTC_CHROMIUM_BUILD -DLOGGING_INSIDE_WEBRTC -DWEBRTC_POSIX -DWEBRTC_MAC -DWEBRTC_IOS -DFEATURE_ENABLE_SSL -DSSL_USE_OPENSSL -DHAVE_OPENSSL_SSL_H -DNO_MAIN_THREAD_WRAPPING -DUSE_LIBPCI=1 -DUSE_NSS_VERIFIER=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -Igen -I../.. -I../../third_party/webrtc_overrides -I../../third_party -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator9.2.sdk -O0 -gdwarf-2 -fvisibility=hidden -Werror -mios-simulator-version-min=7.0 -arch x86_64 -Wall -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wno-inconsistent-missing-override -Wno-shift-negative-value -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Users/nicholss/chromoting/ios/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang follow-macro-expansion -fcolor-diagnostics -fstack-protector-all -fobjc-arc -Wobjc-missing-property-synthesis -fobjc-call-cxx-cdtors -include obj/third_party/webrtc/build/rtc_base_objc.WebRTC-Prefix.pch-mm -c ../../third_party/webrtc/base/objc/RTCFileLogger.mm -o obj/third_party/webrtc/base/objc/rtc_base_objc.RTCFileLogger.o
In file included from ../../third_party/webrtc/base/objc/RTCFileLogger.mm:16:
../../third_party/webrtc/base/logsinks.h:25:36: error: expected class name
class FileRotatingLogSink : public LogSink {
                                   ^
../../third_party/webrtc/base/logsinks.h:33:26: error: only virtual member functions can be marked 'override'
  ~FileRotatingLogSink() override;
                         ^~~~~~~~
../../third_party/webrtc/base/logsinks.h:37:49: error: only virtual member functions can be marked 'override'
  void OnLogMessage(const std::string& message) override;
                                                ^~~~~~~~
../../third_party/webrtc/base/logsinks.h:60:37: error: only virtual member functions can be marked 'override'
  ~CallSessionFileRotatingLogSink() override;
                                    ^~~~~~~~
../../third_party/webrtc/base/objc/RTCFileLogger.mm:111:20: error: no member named 'LogThreads' in 'rtc::LogMessage'
  rtc::LogMessage::LogThreads(true);
  ~~~~~~~~~~~~~~~~~^
../../third_party/webrtc/base/objc/RTCFileLogger.mm:112:20: error: no member named 'LogTimestamps' in 'rtc::LogMessage'
  rtc::LogMessage::LogTimestamps(true);
  ~~~~~~~~~~~~~~~~~^
../../third_party/webrtc/base/objc/RTCFileLogger.mm:113:20: error: no member named 'AddLogToStream' in 'rtc::LogMessage'
  rtc::LogMessage::AddLogToStream(_logSink.get(), [self rtcSeverity]);
  ~~~~~~~~~~~~~~~~~^
../../third_party/webrtc/base/objc/RTCFileLogger.mm:122:20: error: no member named 'RemoveLogToStream' in 'rtc::LogMessage'
  rtc::LogMessage::RemoveLogToStream(_logSink.get());
  ~~~~~~~~~~~~~~~~~^
In file included from ../../third_party/webrtc/base/objc/RTCFileLogger.mm:14:
In file included from ../../third_party/webrtc/base/filerotatingstream.h:18:
In file included from ../../third_party/webrtc/base/stream.h:20:
In file included from ../../third_party/webrtc/base/messagehandler.h:17:
../../third_party/webrtc/base/scoped_ptr.h:125:5: error: delete called on non-final 'rtc::FileRotatingLogSink' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
    delete ptr;
    ^
../../third_party/webrtc/base/scoped_ptr.h:238:7: note: in instantiation of member function 'rtc::DefaultDeleter<rtc::FileRotatingLogSink>::operator()' requested here
      static_cast<D&>(data_)(old);
      ^
../../third_party/webrtc/base/scoped_ptr.h:379:49: note: in instantiation of member function 'rtc::internal::scoped_ptr_impl<rtc::FileRotatingLogSink, rtc::DefaultDeleter<rtc::FileRotatingLogSink> >::reset' requested here
  void reset(element_type* p = nullptr) { impl_.reset(p); }
                                                ^
../../third_party/webrtc/base/objc/RTCFileLogger.mm:90:16: note: in instantiation of member function 'rtc::scoped_ptr<rtc::FileRotatingLogSink, rtc::DefaultDeleter<rtc::FileRotatingLogSink> >::reset' requested here
      _logSink.reset(
               ^
9 errors generated.
[3337/4821] CXX obj/third_party/webrtc/modules/video_coding/webrtc_video_coding.generic_encoder.o
ninja: build stopped: subcommand failed.


Build settings target iOS and include the remoting base and remoting protocol, which in turn includes some parts of webrtc.



I can work around this issue by making the following change:

 git diff base/base.gyp
diff --git a/base/base.gyp b/base/base.gyp
index 334c1bd..eff24ac 100644
--- a/base/base.gyp
+++ b/base/base.gyp
@@ -38,12 +38,7 @@
             'objc/RTCDispatcher.m',
             'objc/RTCFieldTrials.h',
             'objc/RTCFieldTrials.mm',
-            'objc/RTCFileLogger.h',
-            'objc/RTCFileLogger.mm',
-            'objc/RTCLogging.h',
-            'objc/RTCLogging.mm',
             'objc/RTCMacros.h',
-            'objc/RTCSSLAdapter.h',
             'objc/RTCSSLAdapter.mm',
             'objc/RTCTracing.h',
             'objc/RTCTracing.mm',