New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 599491 link

Starred by 1 user
Status: Fixed
Owner:
█ avayvod@chromium.org
Last visit > 30 days ago
Closed: Mar 2016
Cc:
mfo...@chromium.org
mlamouri@chromium.org
taku...@chromium.org
powerb@chromium.org
tguilbert@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

MediaNotificationInfo.equals is broken

Project Member Reported by avayvod@chromium.org, Mar 31 2016 
Change https://codereview.chromium.org/1645943003 introduced a bug into the equals() method of MediaNotificationInfo.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81a9ebb07474ff28aee0e2c7562dde46ba8bcc2a

commit 81a9ebb07474ff28aee0e2c7562dde46ba8bcc2a
Author: avayvod <avayvod@chromium.org>
Date: Thu Mar 31 20:10:41 2016

[Android] Fixed equals() for MediaNotificationInfo

BUG= 599491 
TBR=mlamouri@chromium.org

Review URL: https://codereview.chromium.org/1850693002

Cr-Commit-Position: refs/heads/master@{#384367}

[modify] https://crrev.com/81a9ebb07474ff28aee0e2c7562dde46ba8bcc2a/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java

Comment 2 by avayvod@chromium.org, Mar 31 2016

Labels: Merge-Request-50

Comment 3 by tin...@google.com, Mar 31 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Project Member

Comment 4 by bugdroid1@chromium.org, Mar 31 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98213ffa062e4bf4235a7d06133c453ba6bd4505

commit 98213ffa062e4bf4235a7d06133c453ba6bd4505
Author: Anton Vayvod <avayvod@google.com>
Date: Thu Mar 31 20:35:41 2016

[Android] Fixed equals() for MediaNotificationInfo

BUG= 599491 
TBR=mlamouri@chromium.org

Review URL: https://codereview.chromium.org/1850693002

Cr-Commit-Position: refs/heads/master@{#384367}
(cherry picked from commit 81a9ebb07474ff28aee0e2c7562dde46ba8bcc2a)

Review URL: https://codereview.chromium.org/1852543002 .

Cr-Commit-Position: refs/branch-heads/2661@{#452}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/98213ffa062e4bf4235a7d06133c453ba6bd4505/chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationInfo.java

Comment 5 by avayvod@chromium.org, Mar 31 2016

Status: Fixed (was: Started)
►

Sign in to add a comment