New issue
Advanced search Search tips

Issue 599489 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocking:
issue 508771



Sign in to add a comment

bluetooth: Rename blink::mojom::WebBluetoothError to blink::mojom::WebBluetoothResult

Project Member Reported by ortuno@chromium.org, Mar 31 2016

Issue description

Because WebBluetoothError not only includes errors.
 

Comment 1 by dougt@chromium.org, Oct 7 2016

Owner: dougt@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Oct 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c6a577403a2221ee9cfe43aa39d4936d6ef7519

commit 4c6a577403a2221ee9cfe43aa39d4936d6ef7519
Author: dougt <dougt@chromium.org>
Date: Thu Oct 13 01:03:27 2016

bluetooth: Rename blink::mojom::WebBluetoothError

Rename WebBluetoothError to WebBluetoothResult because it returns more
than errors.

BUG= 599489 

R=ortuno@chromium.org, ochang@chromium.org

Review-Url: https://codereview.chromium.org/2394423002
Cr-Commit-Position: refs/heads/master@{#424927}

[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/content/browser/bluetooth/bluetooth_device_chooser_controller.cc
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/content/browser/bluetooth/bluetooth_device_chooser_controller.h
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/content/browser/bluetooth/cache_query_result.h
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/content/browser/bluetooth/web_bluetooth_service_impl.cc
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/content/browser/bluetooth/web_bluetooth_service_impl.h
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/content/renderer/bluetooth/web_bluetooth_impl.cc
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/content/renderer/bluetooth/web_bluetooth_impl.h
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/third_party/WebKit/Source/modules/bluetooth/BluetoothError.h
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/third_party/WebKit/public/platform/modules/bluetooth/WebBluetooth.h
[modify] https://crrev.com/4c6a577403a2221ee9cfe43aa39d4936d6ef7519/third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

Comment 3 by dougt@chromium.org, Oct 14 2016

Status: Fixed (was: Started)

Sign in to add a comment