New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599472 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocked on:
issue 600655



Sign in to add a comment

bluetooth: Replace GattServices with ServicesResolved property

Project Member Reported by fbeaufort@chromium.org, Mar 31 2016

Issue description

As discussed in https://groups.google.com/a/chromium.org/forum/#!msg/web-bluetooth/PQpZAFNlvT4/8enjsHNjIQAJ, the "GattServices" BlueZ DBus property is replaced by the "ServicesResolved" one which is more reliable when indicating whether or not service discovery has been resolved.

See http://git.kernel.org/cgit/bluetooth/bluez.git/commit/?id=4ed99044f49af9ef21c89b283399112cddfe68c0
 
 Issue 595266  has been merged into this issue.
Blockedon: 600655
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/a887ad7e1a3058bb4f0c8a0e90e498c24ca32d80

commit a887ad7e1a3058bb4f0c8a0e90e498c24ca32d80
Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Date: Wed Apr 06 10:46:26 2016

Add BlueZ D-Bus ServicesResolved property

In release 5.38 GattServices property was replaced by ServicesResolved.

BUG= chromium:599472 

Change-Id: Ie685cefda23ed1d2ec083f6bf2d0212a89fdb8d4
Reviewed-on: https://chromium-review.googlesource.com/337482
Reviewed-by: Jakub x Jakub Pawlowski <jpawlowski@chromium.org>
Trybot-Ready: Jakub x Jakub Pawlowski <jpawlowski@chromium.org>
Tested-by: Jakub x Jakub Pawlowski <jpawlowski@chromium.org>
Commit-Queue: Jakub x Jakub Pawlowski <jpawlowski@chromium.org>

[modify] https://crrev.com/a887ad7e1a3058bb4f0c8a0e90e498c24ca32d80/dbus/service_constants.h

Comment 4 by mcchou@chromium.org, Apr 18 2016

Cc: mcchou@chromium.org jleong@chromium.org snanda@chromium.org
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b15ff2842d798a28388685a6fe75b80a5b808db

commit 1b15ff2842d798a28388685a6fe75b80a5b808db
Author: beaufort.francois <beaufort.francois@gmail.com>
Date: Tue Apr 19 08:06:34 2016

Roll cros_system_api DEPS for BlueZ D-Bus ServicesResolved property

BUG= 599472 

Review URL: https://codereview.chromium.org/1890763005

Cr-Commit-Position: refs/heads/master@{#388163}

[modify] https://crrev.com/1b15ff2842d798a28388685a6fe75b80a5b808db/DEPS

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a9e2d9a44fa1de031a5ad7e905e4ca4dbdfb826

commit 3a9e2d9a44fa1de031a5ad7e905e4ca4dbdfb826
Author: ortuno <ortuno@chromium.org>
Date: Wed Apr 20 20:08:17 2016

bluetooth: Make IsGattServicesDiscoveryComplete virtual

Also makes SetServicesDiscoveryComplete virtual. This way we can have
different implementations of these functions.

Also modifies mock adapters to specify what this now virtual functions
return.

BUG= 599472 

Review URL: https://codereview.chromium.org/1908523002

Cr-Commit-Position: refs/heads/master@{#388563}

[modify] https://crrev.com/3a9e2d9a44fa1de031a5ad7e905e4ca4dbdfb826/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc
[modify] https://crrev.com/3a9e2d9a44fa1de031a5ad7e905e4ca4dbdfb826/device/bluetooth/bluetooth_device.h
[modify] https://crrev.com/3a9e2d9a44fa1de031a5ad7e905e4ca4dbdfb826/device/bluetooth/test/mock_bluetooth_device.h

Project Member

Comment 7 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f52a0e19fdb56e0ea7a511e0560afa03ed098150

commit f52a0e19fdb56e0ea7a511e0560afa03ed098150
Author: luiz.von.dentz <luiz.von.dentz@intel.com>
Date: Mon May 09 16:59:42 2016

bluetooth: replace GattServices D-Bus property with ServicesResolved

GattServices has been removed from BlueZ so ServicesResolved shall be used instead.

BUG= 599472 

Depends on: https://chromium-review.googlesource.com/#/c/337482/

Review-Url: https://codereview.chromium.org/1862093002
Cr-Commit-Position: refs/heads/master@{#392339}

[modify] https://crrev.com/f52a0e19fdb56e0ea7a511e0560afa03ed098150/AUTHORS
[modify] https://crrev.com/f52a0e19fdb56e0ea7a511e0560afa03ed098150/device/bluetooth/bluez/bluetooth_adapter_bluez.cc
[modify] https://crrev.com/f52a0e19fdb56e0ea7a511e0560afa03ed098150/device/bluetooth/bluez/bluetooth_device_bluez.cc
[modify] https://crrev.com/f52a0e19fdb56e0ea7a511e0560afa03ed098150/device/bluetooth/bluez/bluetooth_device_bluez.h
[modify] https://crrev.com/f52a0e19fdb56e0ea7a511e0560afa03ed098150/device/bluetooth/bluez/bluetooth_gatt_bluez_unittest.cc
[modify] https://crrev.com/f52a0e19fdb56e0ea7a511e0560afa03ed098150/device/bluetooth/dbus/bluetooth_device_client.cc
[modify] https://crrev.com/f52a0e19fdb56e0ea7a511e0560afa03ed098150/device/bluetooth/dbus/bluetooth_device_client.h
[modify] https://crrev.com/f52a0e19fdb56e0ea7a511e0560afa03ed098150/device/bluetooth/dbus/fake_bluetooth_device_client.cc

Status: Fixed (was: Available)
Status: Verified (was: Fixed)
bulk verify of io>bluetooth gatt server bugs

Sign in to add a comment