New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599466 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Remove SK_SUPPORT_LEGACY_XFERMODE_PTR

Project Member Reported by tomhud...@chromium.org, Mar 31 2016

Issue description

Convert Chrome over to Skia's new smart pointers.

(Follow-up to https://codereview.chromium.org/1832223002/)

 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54fdf8fba6470d68d6ba4abaf738e570c7137a04

commit 54fdf8fba6470d68d6ba4abaf738e570c7137a04
Author: tomhudson <tomhudson@google.com>
Date: Fri Apr 01 20:45:55 2016

Remove SK_SUPPORT_LEGACY_XFERMODE_PTR

Favor Skia's sk_sp smart pointers over the old raw pointer API.
Also take advantage of a few nearby sk_sp<SkImageFilter> opportunities.

R=fmalita@chromium.org,danakj@chromium.org
TBR=sky@chromium.org,junov@chromium.org
BUG= 599466 ,skia:5077
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review URL: https://codereview.chromium.org/1849213002

Cr-Commit-Position: refs/heads/master@{#384684}

[modify] https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04/cc/output/gl_renderer.cc
[modify] https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04/cc/output/software_renderer.cc
[modify] https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04/skia/config/SkUserConfig.h
[modify] https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04/skia/ext/benchmarking_canvas.cc
[modify] https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04/skia/ext/benchmarking_canvas.h
[modify] https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04/third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp
[modify] https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04/third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp
[modify] https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04/third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp
[modify] https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04/third_party/WebKit/Source/platform/graphics/filters/FEComposite.cpp
[modify] https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
[modify] https://crrev.com/54fdf8fba6470d68d6ba4abaf738e570c7137a04/ui/views/controls/button/label_button_border.cc

Status: Fixed (was: Started)

Sign in to add a comment