New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599416 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Oort Online benchmark is disabled on Windows and Mac due to flakiness

Project Member Reported by skyos...@chromium.org, Mar 31 2016

Issue description

Example failures:

https://uberchromegw.corp.google.com/i/chromium.perf/builders/Win%20Zenbook%20Perf%20(2)

https://uberchromegw.corp.google.com/i/chromium.perf/builders/Mac%2010.10%20Perf%20%282%29/builds/2678/steps/oortonline_tbm/logs/stdio

In every failure there are a number of warnings about missing blob resources:

(error) blob:http%3A//oortonline.gl/bff148c4-2399-4419-a5e9-bd3847eb1d19:0: Failed to load resource: the server responded with a status of 404 (Not Found)
(error) blob:http%3A//oortonline.gl/67401f97-7c98-4a27-a0eb-2f4c407a216b:0: Failed to load resource: the server responded with a status of 404 (Not Found)
(error) blob:http%3A//oortonline.gl/17989d07-24f2-4342-ac2f-a4e5f970606f:0: Failed to load resource: the server responded with a status of 404 (Not Found)
(error) blob:http%3A//oortonline.gl/f440a824-a6b0-41fc-b84b-6fe392836ee1:0: Failed to load resource: the server responded with a status of 404 (Not Found)

Perhaps https://chromium.googlesource.com/chromium/src/+/1fb98480c61c563587cbb01de87cfad180fec942 is related? dmurph, could you take a look please?
 
Cc: u...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3da60d44eca3814ab3172d8afc7c7e09cfc663b4

commit 3da60d44eca3814ab3172d8afc7c7e09cfc663b4
Author: skyostil <skyostil@chromium.org>
Date: Thu Mar 31 13:10:59 2016

perf: Disable Oort Online as it is failing in most runs

BUG= 599416 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1851453002

Cr-Commit-Position: refs/heads/master@{#384258}

[modify] https://crrev.com/3da60d44eca3814ab3172d8afc7c7e09cfc663b4/tools/perf/benchmarks/oortonline.py

Cc: michaeln@chromium.org
hypothesis: It looks like it creates the blob, creates a public url, and then the blob goes out of scope. I'm thinking that the blob is derefed before it's done, and we destroy it, before it's read.

Michael: I think this means we have to add a ref when a blob is registered for a public url. Does this make sense to you? or is this WAI?
Seeing this flakiness in "oortonline" as well (only "oortonline_tbm" was disabled).

Eg: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Mac%2010.10%20Perf%20%285%29/builds/2504/steps/oortonline/logs/stdio
Labels: -Pri-3 Pri-2
Summary: Oort Online benchmark is disabled on Windows and Mac due to flakiness (was: Oort Online benchmark failing flakily on Windows and Mac)
I'm waiting for this patch to go in so I have some better error reporting:
https://codereview.chromium.org/1846363002
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/235cf7de5aaf984d85c549a79b1ca9883a30b3a4

commit 235cf7de5aaf984d85c549a79b1ca9883a30b3a4
Author: rbyers <rbyers@chromium.org>
Date: Mon Apr 04 19:35:11 2016

Disable oortonline benchmark for flakiness

"oortonline_tbm" was disabled in https://codereview.chromium.org/1851453002
for this reason.  "oortonline" needs to be disabled as well.

CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
BUG= 599416 

Review URL: https://codereview.chromium.org/1855903003

Cr-Commit-Position: refs/heads/master@{#384979}

[modify] https://crrev.com/235cf7de5aaf984d85c549a79b1ca9883a30b3a4/tools/perf/benchmarks/oortonline.py

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b

commit e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b
Author: dmurph <dmurph@chromium.org>
Date: Tue Apr 05 19:27:47 2016

[BlobAsync] Adding better error reporting and some new tests.

R=michaeln@chromium.org,kinuko@chromium.org
BUG= 599416 

Review URL: https://codereview.chromium.org/1846363002

Cr-Commit-Position: refs/heads/master@{#385254}

[modify] https://crrev.com/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b/content/browser/blob_storage/blob_dispatcher_host.h
[modify] https://crrev.com/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b/content/browser/blob_storage/blob_dispatcher_host_unittest.cc
[modify] https://crrev.com/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b/storage/browser/blob/blob_async_builder_host.cc
[modify] https://crrev.com/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b/storage/browser/blob/blob_async_builder_host.h
[modify] https://crrev.com/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b/storage/browser/blob/blob_data_handle.cc
[modify] https://crrev.com/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b/storage/browser/blob/blob_data_handle.h
[modify] https://crrev.com/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b/storage/browser/blob/blob_reader.cc
[modify] https://crrev.com/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b/storage/browser/blob/blob_reader.h
[modify] https://crrev.com/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b/storage/browser/blob/blob_storage_context.cc
[modify] https://crrev.com/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b/storage/browser/blob/blob_storage_context.h
[modify] https://crrev.com/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b/storage/browser/blob/blob_storage_registry.h
[modify] https://crrev.com/e13cd7dcf1264b164c7a9e7cd463ff1885e4b68b/storage/common/blob_storage/blob_storage_constants.h

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90774e39bb24b1c531e9b3aba16c77ab96675fb3

commit 90774e39bb24b1c531e9b3aba16c77ab96675fb3
Author: dmurph <dmurph@chromium.org>
Date: Wed Apr 06 16:20:43 2016

[BlobAsync] Faster shortcuttin, make renderer controller leaky & alive.

This should fix strange memory access crashes observed in the
following bugs by doing the following things:
1. We make the controller a leaky lazy instance so it isn't destructed.
2. We make one less message loop hop before we call AddProcessRef, so
   hopefully our process won't be shutting down in the middle of a
   transfer.
3. We send the 'descriptions' as early as possible if we're below the
   IPC threshold, which should help some of the speed regressions.
4. We prevent sudden shutdowns (like tab bar closing) by using
   blink::Platform::current()->suddenTerminationChanged(false);

BUG=600462,600435, 599490 , 599416 , 375297 

Review URL: https://codereview.chromium.org/1853333003

Cr-Commit-Position: refs/heads/master@{#385472}

[modify] https://crrev.com/90774e39bb24b1c531e9b3aba16c77ab96675fb3/content/browser/blob_storage/blob_async_builder_host_unittest.cc
[modify] https://crrev.com/90774e39bb24b1c531e9b3aba16c77ab96675fb3/content/browser/blob_storage/blob_dispatcher_host.cc
[modify] https://crrev.com/90774e39bb24b1c531e9b3aba16c77ab96675fb3/content/browser/blob_storage/blob_dispatcher_host.h
[modify] https://crrev.com/90774e39bb24b1c531e9b3aba16c77ab96675fb3/content/browser/blob_storage/blob_dispatcher_host_unittest.cc
[modify] https://crrev.com/90774e39bb24b1c531e9b3aba16c77ab96675fb3/content/child/blob_storage/blob_transport_controller.cc
[modify] https://crrev.com/90774e39bb24b1c531e9b3aba16c77ab96675fb3/content/child/blob_storage/blob_transport_controller.h
[modify] https://crrev.com/90774e39bb24b1c531e9b3aba16c77ab96675fb3/content/child/blob_storage/blob_transport_controller_unittest.cc
[modify] https://crrev.com/90774e39bb24b1c531e9b3aba16c77ab96675fb3/content/child/webblobregistry_impl.cc
[modify] https://crrev.com/90774e39bb24b1c531e9b3aba16c77ab96675fb3/content/child/webblobregistry_impl.h
[modify] https://crrev.com/90774e39bb24b1c531e9b3aba16c77ab96675fb3/storage/browser/blob/blob_async_builder_host.cc
[modify] https://crrev.com/90774e39bb24b1c531e9b3aba16c77ab96675fb3/storage/browser/blob/blob_async_builder_host.h

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eef5966da78bb5b98dffc941f69d8877c8fcd41

commit 2eef5966da78bb5b98dffc941f69d8877c8fcd41
Author: dmurph <dmurph@chromium.org>
Date: Thu Apr 07 17:56:13 2016

perf: Reenable oort online perf tests.

I believe crrev.com/1853333003 fixed the issue, but if not then
crrev.com/1846363002 should produce better error reporting.

BUG= 599416 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1865003003

Cr-Commit-Position: refs/heads/master@{#385804}

[modify] https://crrev.com/2eef5966da78bb5b98dffc941f69d8877c8fcd41/tools/perf/benchmarks/oortonline.py

Status: Fixed (was: Assigned)

Sign in to add a comment