Unable to uninstall the exisiting (Files) wallpaper image in Set Wallpaper Overlay |
||||||
Issue descriptionVersion: 51.0.2693.2 (Official Build) OS: Chrome Platform: 8133.0.0 (Official Build) dev-channel Daisy, Peppy, Blaze What steps will reproduce the problem? (1) Sign in to user>> download 1,2 images,>> go to Files.app download tab>> select image>> open context menu (select and right click on the image)>> click on set wallpaper (2) go to settings>> click on set wallpaper>> observe the set wallpaper overlay Expected: one should be able to uninstall the existing (Files) wallpaper image as per the error message (Refer screenshot) Actual: 1.Instead not able to uninstall the existing wallpaper image, because its not there in Customised tab 2.Able to change another wallpaper without uninstalling the existing wallpaper This is a Non- Regression issue as set wallpaper from context menu is a new feature introduced in M50 Issue is not applicable to Linux and Windows. @xdai: Please confirm whether this is an issue or working as intended.
,
Apr 4 2016
I found it: Issue 578935
,
May 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ddd4b8e014ac5c63e4447a5f6631521bf13819e8 commit ddd4b8e014ac5c63e4447a5f6631521bf13819e8 Author: xdai <xdai@chromium.org> Date: Mon May 02 23:37:13 2016 Don't show the 'wallpaper-set-by-message' if the current wallpaper is set by the right click menu of Files App. Setting wallpaper from right click menu in 'Files' app is a feature that was implemented in crbug.com/578935 . Since 'Files' app is a built-in v1 app in ChromeOS, we should treat it slightly differently with other third party apps: the wallpaper set by the 'Files' app should still be syncable and it should not appear in the wallpaper grid in the Wallpaper Picker. But we should not display the 'wallpaper-set-by-mesage' since it might introduce confusion as shown in crbug.com/599407 . BUG= 599407 Review-Url: https://codereview.chromium.org/1931713002 Cr-Commit-Position: refs/heads/master@{#391098} [modify] https://crrev.com/ddd4b8e014ac5c63e4447a5f6631521bf13819e8/chrome/browser/chromeos/extensions/wallpaper_api.cc
,
May 4 2016
,
May 4 2016
,
May 4 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/347945a930183408d74eb6681916b39be82e6ecf commit 347945a930183408d74eb6681916b39be82e6ecf Author: xdai <xdai@chromium.org> Date: Thu May 05 17:30:02 2016 [Merge to M51] Don't show the 'wallpaper-set-by-message' if the current wallpaper is set by the right click menu of Files App. Setting wallpaper from right click menu in 'Files' app is a feature that was implemented in crbug.com/578935 . Since 'Files' app is a built-in v1 app in ChromeOS, we should treat it slightly differently with other third party apps: the wallpaper set by the 'Files' app should still be syncable and it should not appear in the wallpaper grid in the Wallpaper Picker. But we should not display the 'wallpaper-set-by-mesage' since it might introduce confusion as shown in crbug.com/599407 . BUG= 599407 TBR=bshe@chromium.org Review-Url: https://codereview.chromium.org/1931713002 Cr-Commit-Position: refs/heads/master@{#391098} (cherry picked from commit ddd4b8e014ac5c63e4447a5f6631521bf13819e8) Review URL: https://codereview.chromium.org/1947283003 . Cr-Commit-Position: refs/branch-heads/2704@{#394} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/347945a930183408d74eb6681916b39be82e6ecf/chrome/browser/chromeos/extensions/wallpaper_api.cc
,
May 13 2016
Verified on ChromeOS M51 (8172.28.0, 51.0.2704.42) and TOT (8314.0.0, 52.0.2733.0) |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by x...@chromium.org
, Apr 1 2016