New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599401 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Incorrect tooltip is seen for New Tab page on selecting Mute tab option.

Reported by vvishwak...@etouch.net, Mar 31 2016

Issue description

Version: 51.0.2695.0 (Official Build) 723dfe66b1985ff2178590b15d1cc63911300737-refs/heads/master@{#384157} (64-bit)
OS: Mac

What steps will reproduce the problem?
1) Launch chrome, open a New tab, right click on 'New Tab' button and select 'Mute tab' option.
2) Mouse hover on tab immediately after selecting 'Mute tab' option.
3) Observe the tooltip.

'New Tab' tooltip is seen on mouse hover.

'New Tab. This tab's audio is being muted' tooltip should be seen on mouse hover.

This is a Non-Regression issue seen from M-46 (Chrome version: 46.0.2480.0) 

Note: 1) Issue is not seen on Windows and Linux OS. 
      2)    
 
mute_actual.mov
5.6 MB Download
mute_expected.mp4
212 KB Download
Note: Before build no: 46.0.2480.0, Mute tab option was not available. 
Status: Untriaged (was: Unconfirmed)
Untriaging it so that it gets addressed.
Cc: rsesek@chromium.org ortuno@chromium.org
Owner: tapted@chromium.org
Status: Started (was: Untriaged)
[mac triage] this seems to fix it https://codereview.chromium.org/1855503002/
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cad10375b43638e45bb4e7630e71313b59a13842

commit cad10375b43638e45bb4e7630e71313b59a13842
Author: tapted <tapted@chromium.org>
Date: Mon Apr 18 01:14:47 2016

Mac: Update the tooltip view tooltip when a tab's title changes.

Currently, when muting a tab, the tooltip only updates when hovering off
of a tab, then hovering back on.

This is because only the tab view's tooltip updates, but there's an
optimization on mac that involves adding a separate transparent view to
handle tab tooltips. If that tooltip view is for the changed tab, ensure
its tooltip is updated as well.

BUG= 599401 
TEST=On Mac, reveal a tab's tooltip, then mute/unmute a tab and
immediately hover over it again. Ensure the tooltip is updated
appropriately.

Review URL: https://codereview.chromium.org/1855503002

Cr-Commit-Position: refs/heads/master@{#387840}

[modify] https://crrev.com/cad10375b43638e45bb4e7630e71313b59a13842/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
[modify] https://crrev.com/cad10375b43638e45bb4e7630e71313b59a13842/chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm

Comment 5 by tapted@chromium.org, Apr 18 2016

Status: Fixed (was: Started)

Sign in to add a comment