Good Build: 51.0.2694.1
Bad Build: 51.0.2695.0

Narrow Bisect: 
https://chromium.googlesource.com/chromium/src/+log/1c3b2280493caab10b498d3478078a84452e9bfe..a377c049175591928ea1507ef76242d913363011?pretty=fuller&n=100

Suspecting: r384095

Deleted: Actual_Download.mp4 440 KB

Actual_Download.mp4 440 KB Download

Deleted: Expected_Download.mp4 320 KB

Expected_Download.mp4 320 KB Download

Adding release block label, please undo if not the case.

Uploaded CL http://crrev.com/1851573003 and waiting for review.

crisper.js is generated by running Polymer's crisper tool on the Downloads sources.

This is a problem in Polymer, specifically iron-a11y-keys-behavior. I have filed a bug: https://github.com/PolymerElements/iron-a11y-keys-behavior/issues/38

To fix this in Chrome, we would have to patch the file in third_party/polymer, then re-run crisper.

 Issue 596637  has been merged into this issue.

Waiting for Polymer's fix and Chrome can re-run crisper.

Summary:
The cause is pressing ESC key will produce KeyboardEvent.key "Escape" on FF and new Chrome, but "Esc" on Edge and undefined on old Chrome and Safari. Polymer only handles "Esc" and undefined. (So it will also break on FF)

Potential other issue:
DELETE key produces "Delete" on FF and new Chrome but "Del" on Edge.

Link to spec:
[1] KeyboardEvent.key for ESC should be "Escape":
http://w3c.github.io/uievents-key/#key-Escape
[2]KeyboardEvent.key for DELETE should be "Delete":
http://w3c.github.io/uievents-key/#key-Delete

Polymer has accepted my PRs so we're updating our iron-a11y-keys-behavior now, then will re-run crisper.

 Issue 598625  has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13871d3b9ac20123bd17ecd748e55aaa476d008e

commit 13871d3b9ac20123bd17ecd748e55aaa476d008e
Author: michaelpg <michaelpg@chromium.org>
Date: Sat Apr 02 03:31:56 2016

Update PolymerElements/iron-a11y-keys-behavior for ESC key fix

This fixes the ESC key in chrome://md-settings.

It also fixes downloads.html when using -Duse_vulcanize=0. A follow-up
patch will need to re-run vulcanize/crisper.

R=dbeam@chromium.org
BUG= 599373 

Review URL: https://codereview.chromium.org/1849403002

Cr-Commit-Position: refs/heads/master@{#384791}

[modify] https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/.bower.json
[modify] https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/CONTRIBUTING.md
[modify] https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/README.md
[modify] https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/bower.json
[modify] https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/index.html
[modify] https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e/third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/iron-a11y-keys-behavior-extracted.js
[modify] https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e/third_party/polymer/v1_0/components-chromium/iron-test-helpers/.bower.json
[modify] https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e/third_party/polymer/v1_0/components-chromium/iron-test-helpers/bower.json
[delete] https://crrev.com/ee74f4be771d893bbbbafac882fbb7a96dbd171b/third_party/polymer/v1_0/components-chromium/iron-test-helpers/iron-test-helpers-extracted.js
[modify] https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e/third_party/polymer/v1_0/components-chromium/iron-test-helpers/iron-test-helpers.html
[modify] https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e/third_party/polymer/v1_0/components-chromium/iron-test-helpers/mock-interactions.js
[modify] https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e/third_party/polymer/v1_0/components-chromium/iron-test-helpers/test-helpers.js
[modify] https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e/ui/webui/resources/polymer_resources.grdp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aab97446e6551cf50a2078473e8a8c7b766cb8db

commit aab97446e6551cf50a2078473e8a8c7b766cb8db
Author: dbeam <dbeam@chromium.org>
Date: Tue Apr 05 04:13:40 2016

MD Downloads: fix vulcanize issues by excluding higher up in the dependency tree

This implicitly aligns tests and production code, and updates
tests to use the less error-prone way to import Polymer.

R=michaelpg@chromium.org
BUG= 599373 

NOPRESUBMIT=true  # crisper.js

Review URL: https://codereview.chromium.org/1846383002

Cr-Commit-Position: refs/heads/master@{#385100}

[modify] https://crrev.com/aab97446e6551cf50a2078473e8a8c7b766cb8db/chrome/browser/resources/md_downloads/crisper.js
[modify] https://crrev.com/aab97446e6551cf50a2078473e8a8c7b766cb8db/chrome/browser/resources/md_downloads/vulcanize.py
[modify] https://crrev.com/aab97446e6551cf50a2078473e8a8c7b766cb8db/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/aab97446e6551cf50a2078473e8a8c7b766cb8db/chrome/test/data/webui/polymer_browser_test_base.js

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/29033c19a19ed40edec7bba3836ce29a98de7cc4

commit 29033c19a19ed40edec7bba3836ce29a98de7cc4
Author: dbeam <dbeam@chromium.org>
Date: Tue Apr 05 07:10:12 2016

Re-vulcanize the downloads page on each Polymer roll

R=michaelpg@chromium.org
BUG= 599373 

NOTRY=true

Review URL: https://codereview.chromium.org/1855673002

Cr-Commit-Position: refs/heads/master@{#385117}

[modify] https://crrev.com/29033c19a19ed40edec7bba3836ce29a98de7cc4/third_party/polymer/v1_0/reproduce.sh

michaelpg@/chongz@: soooo, now this menu requires 2 presses of Esc to close (1 blurs, 1 closes).  is that intended?

dbeam@: I compiled&tested chrome://downloads on Linux with Chromium Version 51.0.2703.0 (64-bit) and a single press of ESC will close the menu. May I have more information on how to reproduce the issue?

Thanks!

michaelpg@/dbeam@: Ok able to reproduce the issue in chrome://downloads by hovering mouse on a dropdown item first (item will have a highlight), then it requires 2 presses of ESC. 

However not able to reproduce on the Polymer Example page because hovering mouse won't cause highlight change, any ideas?

Polymer Example page: https://elements.polymer-project.org/elements/paper-dropdown-menu?active=paper-dropdown-menu&view=demo:demo/index.html

#13: no, it's not intended.

also, right-clicking on the page after opening the menu should close the menu, but doesn't.

this fiddle uses the versions we use in the regressed downloads page, but doesn't repro the bug :-\

https://jsfiddle.net/1s42b1n0/2/

I lied!! This fiddle repros: https://jsfiddle.net/1s42b1n0/3/

this is a dupe of https://github.com/PolymerElements/iron-overlay-behavior/issues/117 and fixed in iron-overlay-behavio v1.5.0.

Yes changing iron-overlay-behavior to v1.5 fixes the ESC issue: https://jsfiddle.net/t96n5h2c/

However the dropdown will appear in the center first, not sure if it's an issue of JSFiddle...

Looks like the behavior has changed now, unable to see the option "More Actions" in the chrome://downloads

Screen-recording is attached.

@dbeam: Could you please confirm whether this is intended.

@rkote: Could you also please confirm once?

Thank you.

Deleted: 599373.mp4 962 KB

599373.mp4 962 KB Download

#20: the overflow button only appears if your width is small enough (<1024px I think). does it appear if you shrink the window?

With respect to comment 20:

Above issue is fixed in latest canary build 52.0.2706.0

Thank you.

Can this issue now be closed based on #22?

Verified the issue on Windows 7, Ubuntu 14.04 and Mac OS 10.11.4 using chrome latest canary M52-52.0.2711.0 and observed that by pressing Esc key in Chrome://Downloads the more actions overlay is getting closed as expected. Hence adding TE-Verified label.

Deleted: 599373.mp4 410 KB

599373.mp4 410 KB Download