Issue metadata
Sign in to add a comment
|
24.5% regression in v8.mobile_infinite_scroll at 383718:383744 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Mar 31 2016
=== Auto-CCing suspected CL author jdduke@chromium.org === Hi jdduke@chromium.org, the bisect results pointed to your CL below as possibly causing a regression. Please have a look at this info and see whether your CL be related. ===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : Allow continuous request dispatch below the throttle rate Author : jdduke Commit description: ResourceDispatchThrottler will throttle requests when a give threshold is reached within a given time window. However, it is overly restrictive when the requests are continuous, as the sliding time window was keyed off the most recently sent request. Fix this by tracking the flush time, rather than the last sent request time, allowing continuous request dispatch at or below the specified throttling rate. BUG= 592037 Review URL: https://codereview.chromium.org/1834853003 Cr-Commit-Position: refs/heads/master@{#383740} Commit : 46c01a93646af14072ce25fc59a9b59b29f097d7 Date : Tue Mar 29 16:34:58 2016 ===== TESTED REVISIONS ===== Revision Mean Value Std. Dev. Num Values Good? chromium@383717 560.290567 22.945955 6 good chromium@383731 556.87896 7.420437 5 good chromium@383738 561.10988 33.830574 5 good chromium@383739 580.4426 27.045648 5 good chromium@383740 687.1506 19.222313 4 bad <- chromium@383741 685.67976 31.152966 5 bad chromium@383744 701.75624 20.107712 5 bad Bisect job ran on: android_nexus5X_perf_bisect Bug ID: 599365 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --also-run-disabled-tests v8.mobile_infinite_scroll Test Metric: Scrolling-v8_gc_total/Scrolling-v8_gc_total Relative Change: 25.79% Score: 99.9 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/39 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9016693657720078144 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=599365 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
Apr 6 2016
Any regression here is likely just a side-effect of throttling working properly now (i.e., continuous requests are now "less" strictly throttled). |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by mlippautz@chromium.org
, Mar 31 2016