Issue 599364 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	toyoshim@chromium.org
Closed:	Apr 2016
Cc:	dgozman@chromium.org
Components:	Blink>Loader
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	1
Type:	Bug
Reload Hotlist-Loading

Blocking:
issue 558829

Make cache control flags consistent

Project Member Reported by toyoshim@chromium.org, Mar 31 2016

Issue description

Cache control flags are inconsistent in Chrome/Blink.

net - load_flags
LOAD_BYPASS_CACHE
LOAD_VALIDATE_CACHE
LOAD_NORMAL
LOAD_PREFERRING_CACHE
LOAD_ONLY_FROM_CACHE

blink - WebURLRequest::CachePolicy
ReloadBypassingCache
ReloadIgnoringCacheData
UseProtocolCachePolicy
ReturnCacheDataElseLoad
ReturnCacheDataDontLoad

Difference between them are not critical, but 'ignoring' is used to specify both BYPASS and VALIDATE in Chrome/Blink. We should remove confusing 'ignoring' from flags, and method arguments.

This is clean up before submitting a CL to revamp pull-to-refresh reload.

Comment 1 by toyoshim@chromium.org, Mar 31 2016

https://docs.google.com/document/d/10fV2Eszl7yKx2Od-aqKNeAqkW27gCPmI6SnCk_bgZb4/edit?usp=sharing

after this change:

blink - WebURLRequest::CachePolicy
BypassingCache
ValidatingCacheData
UseProtocolCachePolicy
ReturnCacheDataElseLoad
ReturnCacheDataDontLoad

blink - ResourceRequestCachePolicy
should be same

blink - WebFrame::reload
(bool bypassCache)

FrameMsg_Navigate_Type
RELOAD_BYPASSING_CACHE

ReloadType
RELOAD_BYPASSING_CACHE

Comment 2 by toyoshim@chromium.org, Mar 31 2016

There are three enums in blink for cache controls.
These should be merged into one class.

core/fetch/CachePolicy.h: CachePolicy
WebKit/public/platform/WebURLRequest.h: WebURLRequest::CachePolicy
webKit/Source/platform/network/ResourceRequest.h: ResourceRequestCachePolicy

Comment 3 by toyoshim@chromium.org, Mar 31 2016

Components: Blink>Loader
Labels: reload Hotlist-Loading

Comment 4 by toyoshim@chromium.org, Mar 31 2016

Cc: dgozman@chromium.org

dgozman: I'm replacing 'ignoreCache' with 'bypasCache' to be consistent with net flags, but Inspector seems to expose this as an API, right?
How difficult is it to change the name?

Project Member

Comment 5 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0688f98395f1bc84d3ccbc57380950773cc09ad

commit e0688f98395f1bc84d3ccbc57380950773cc09ad
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Apr 01 06:00:42 2016

Rename IgnoringCacheData to ValidatingCacheData

'ignoring' is very confusing in current Chromium/Blink repository.
'ignoreCache' is used to specify the strong reload in some areas, but
strong reload actually uses BYPASS_CACHE flag, and weak realod uses
IGNORE_CACHE.

This series of changes remove 'ignore' or 'ignoring' from the code base
completely, and use 'validate' and 'bypass' to be consistent with
net flags.

Also, I drop 'Reload' prefix because this does not represent the flag
behavior, but just one of use case to use the flag today.

BUG= 599364 

Review URL: https://codereview.chromium.org/1846733004

Cr-Commit-Position: refs/heads/master@{#384500}

[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/content/child/web_url_request_util.cc
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/content/renderer/image_downloader/image_downloader_impl.cc
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/third_party/WebKit/Source/core/fetch/CachePolicy.h
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/third_party/WebKit/Source/core/fetch/ImageResource.cpp
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/third_party/WebKit/Source/platform/network/ResourceRequest.h
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/e0688f98395f1bc84d3ccbc57380950773cc09ad/third_party/WebKit/public/platform/WebURLRequest.h

Comment 6 by toyoshim@chromium.org, Apr 1 2016

Note: Still content and chrome have 'ignore_cache' that should be changed.

Project Member

Comment 7 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4988d88eb8c53b454d454cc9bceb8128cacc1fab

commit 4988d88eb8c53b454d454cc9bceb8128cacc1fab
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Apr 01 09:13:00 2016

Rename WebFrameLoadType::ReloadFromOrigin to ReloadBypassingCache

Other types, e.g. CachePolicy, uses 'BypassingCache', and
WebFrameLoadType and FrameLoadType is only places to use 'FromOrigin'.

To use consistent term in chrome/blink, rename it to
ReloadBypassingCache.

There are several type conversion code between WebFrameLoadType,
FrameLoadType, CachePolicy, and boolean to specify the reload type.
This cleanup is important to avoid unnecessary confusion, and eventually
remove reload() API to migrate it to load().

Also we use a word 'ReloadOriginalRequest' in content to
express a different thing. So, 'Origin' is a bit confusing.

BUG= 599364 

Review URL: https://codereview.chromium.org/1850123002

Cr-Commit-Position: refs/heads/master@{#384526}

[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/Source/core/loader/FrameLoaderTypes.h
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/4988d88eb8c53b454d454cc9bceb8128cacc1fab/third_party/WebKit/public/web/WebFrameLoadType.h

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dad4b118fe1debab178df8df629bde20b5233fa

commit 7dad4b118fe1debab178df8df629bde20b5233fa
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Apr 01 14:28:05 2016

Rename IGNORING_CACHE to BYPASSING_CACHE

chrome and content uses IGNORE_CACHE to specify a strong reload.
But, Blink uses ReloadBypassingCache instead of ReloadIgnoringCacheData.

This is confusing and we should use consistent words in the project.

This series of changes remove 'ignore' or 'ignoring' from the code base
completely, and use 'validate' and 'bypass' to be consistent with
net flags.

BUG= 599364 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
TBR=shuchen@chromium.org

Review URL: https://codereview.chromium.org/1846653004

Cr-Commit-Position: refs/heads/master@{#384581}

[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/android_webview/browser/icon_helper.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/app/chrome_dll.rc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/app/generated_resources.grd
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/app/nibs/MainMenu.xib
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/app_mode/app_mode_utils.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/chromeos/login/ui/simple_web_view_dialog.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/favicon/content_favicon_driver_browsertest.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/referrer_policy_browsertest.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/resources/chromeos/keyboard_overlay_data.js
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/browser.h
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/browser_command_controller_unittest.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/cocoa/accelerators_cocoa.mm
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/cocoa/browser_window_command_handler.mm
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/cocoa/toolbar/reload_button_cocoa.mm
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/panels/panel.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/panels/panel_host.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/panels/panel_host.h
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/views/accelerator_table.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/views/frame/browser_view.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/views/panels/panel_view.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/views/toolbar/reload_button.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/components/favicon/content/content_favicon_driver.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/browser/frame_host/navigation_controller_android.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/browser/frame_host/navigation_controller_android.h
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/browser/frame_host/navigation_controller_impl.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/browser/frame_host/navigation_controller_impl.h
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/browser/frame_host/navigation_request.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/browser/frame_host/navigator_impl.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/browser/frame_host/navigator_impl_unittest.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/common/frame_message_enums.h
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/public/android/java/src/org/chromium/content_public/browser/NavigationController.java
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/public/browser/navigation_controller.h
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/7dad4b118fe1debab178df8df629bde20b5233fa/tools/metrics/actions/actions.xml

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 4 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab

commit fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab
Author: toyoshim <toyoshim@chromium.org>
Date: Mon Apr 04 07:17:30 2016

Change bool ignoreCache to WebFrameLoadType

Blink provided cache control flags, IgnoringCacheData and
BypassingCache. This is confusing, but when ignoreCache is true,
IgnoringCacheData isn't used, but BypassingCache is used.

In a previous change, IgnoringCacheData is renamed to
ValidatingCacheData. This patch also changes bool ignoreCache
to use WebFrameLoadType becase enum is more readable than bool,
and the WebFrameLoadType has been already used in
RemoteFrameClient::reload().

In this change, I do not touch Inspector related code
but separately start discussion with Inspector team.

BUG= 599364 

Review URL: https://codereview.chromium.org/1843663005

Cr-Commit-Position: refs/heads/master@{#384860}

[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/core/frame/FrameTypes.h
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/core/frame/History.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/core/frame/Location.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/core/loader/FrameLoadRequest.h
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/core/loader/FrameLoader.h
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/web/AssertMatchingEnums.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/web/WebViewImpl.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[add] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/public/web/WebClientRedirectPolicy.h
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/public/web/WebFrame.h
[modify] https://crrev.com/fe0fa1ace83ae2bc6170ac740d4dfa52460dfeab/third_party/WebKit/public/web/WebRemoteFrameClient.h

Comment 10 by dgozman@chromium.org, Apr 4 2016

re #c4: renaming in the code is fine, just don't rename it in protocol.json.

Comment 11 by toyoshim@chromium.org, Apr 5 2016

Thank you for information. I'll send a CL soon!

Project Member

Comment 12 by bugdroid1@chromium.org, Apr 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/24a4c7aba842ce860467501828d91a26418682dd

commit 24a4c7aba842ce860467501828d91a26418682dd
Author: toyoshim <toyoshim@chromium.org>
Date: Tue Apr 05 09:24:14 2016

Rename |ignore_cache| to |bypass_cache|

To be aligned with other flags, rename |ignore_cache| to |bypass_cache|.
After this change, only Inspector related code use the word 'ignore'
to specify Shift-Reload.

BUG= 599364 

Review URL: https://codereview.chromium.org/1854053002

Cr-Commit-Position: refs/heads/master@{#385142}

[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/chrome/browser/ui/browser.h
[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/chrome/renderer/net/net_error_helper.h
[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/components/error_page/renderer/net_error_helper_core.cc
[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/components/error_page/renderer/net_error_helper_core.h
[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/components/error_page/renderer/net_error_helper_core_unittest.cc
[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/content/common/frame_messages.h
[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/content/public/browser/web_contents.h
[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/24a4c7aba842ce860467501828d91a26418682dd/content/renderer/render_frame_impl.h

Comment 13 by toyoshim@chromium.org, Apr 6 2016

dgozman: I found that there is a DevTools API for Extensions.
https://developer.chrome.com/extensions/devtools_inspectedWindow#method-reload
And it exposes ignoreCache as a parameter of reloadOptions. I'd keep it as is too.

Project Member

Comment 14 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2262e257edc8cb45a5c1830250f740941ef9880

commit e2262e257edc8cb45a5c1830250f740941ef9880
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Apr 08 06:22:18 2016

Rename ignore_cache and ignoreCache to bypass* unless it affects API

Now ignore_cache and ignoreCache are going to be replaced with bypass*
in chromium/blink code base because there were wrong usage for the word
ignore, and it is very confusing to use.

But, DevTools exposes the word as a part of DevTools API for
Chrome Extensions and Remote Debuggers.

This change replace them as possible, but keep it as is if it affects
these APIs.

BUG= 599364 
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/1867523002

Cr-Commit-Position: refs/heads/master@{#386006}

[modify] https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880/chrome/browser/devtools/devtools_window.cc
[modify] https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880/chrome/browser/devtools/devtools_window.h
[modify] https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880/chrome/common/extensions/api/devtools/inspected_window.json
[modify] https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880/content/browser/devtools/protocol/page_handler.cc
[modify] https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880/content/browser/devtools/protocol/page_handler.h
[modify] https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880/third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp
[modify] https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h
[modify] https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
[modify] https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
[modify] https://crrev.com/e2262e257edc8cb45a5c1830250f740941ef9880/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Project Member

Comment 15 by bugdroid1@chromium.org, Apr 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3f7f688d56f5c9cf0be4c77c7052cec0419897f

commit f3f7f688d56f5c9cf0be4c77c7052cec0419897f
Author: toyoshim <toyoshim@chromium.org>
Date: Fri Apr 08 07:47:48 2016

Introduce WebCachePolicy to merge cache policy enums

- Replace blink::WebURLRequest::CachePolicy with blink::WebCachePolicy
- Merge blink::ResourceRequestCachePolicy to blink::WebCachePolicy
- Remove unnecessary cast between them
- Replace CachePolicy* with CachePolicy in RenderFrameImpl

BUG= 599364 

Review URL: https://codereview.chromium.org/1858533002

Cr-Commit-Position: refs/heads/master@{#386016}

[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/chrome/renderer/net/net_error_helper.cc
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/child/web_url_request_util.cc
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/public/renderer/resource_fetcher.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/renderer/fetchers/multi_resolution_image_resource_fetcher.cc
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/renderer/fetchers/multi_resolution_image_resource_fetcher.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/renderer/fetchers/resource_fetcher_impl.cc
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/renderer/fetchers/resource_fetcher_impl.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/renderer/history_controller.cc
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/renderer/history_controller.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/renderer/image_downloader/image_downloader_impl.cc
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/renderer/internal_document_state_data.cc
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/renderer/internal_document_state_data.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/renderer/render_frame_impl.cc
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/content/renderer/render_frame_impl.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/fetch/FetchContext.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/fetch/FetchContext.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/fetch/ImageResource.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/inspector/InspectorResourceContentLoader.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/loader/FrameFetchContext.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/loader/FrameLoader.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/loader/FrameLoader.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/loader/ImageLoader.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/core/loader/NavigationScheduler.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/platform/exported/WebURLRequest.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/platform/network/ResourceRequest.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/platform/network/ResourceRequest.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/platform/network/ResourceRequestTest.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/web/WebLocalFrameImpl.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/web/WebRemoteFrameImpl.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/web/tests/FrameTestHelpers.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/web/tests/VisualViewportTest.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/web/tests/WebFrameTest.cpp
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/Source/web/tests/WebViewTest.cpp
[add] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/public/platform/WebCachePolicy.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/public/platform/WebURLRequest.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/public/web/WebFrame.h
[modify] https://crrev.com/f3f7f688d56f5c9cf0be4c77c7052cec0419897f/third_party/WebKit/public/web/WebLocalFrame.h

Comment 16 by toyoshim@chromium.org, Apr 13 2016

Blocking: 600636

Comment 17 by toyoshim@chromium.org, Apr 13 2016

Status: Fixed (was: Started)

This is almost finished.
I file a separate bug for memory cache policy ( crbug.com/602900 ) and close this bug now.

Comment 18 by toyoshim@chromium.org, Apr 13 2016

Blocking: 558829

Comment 19 by toyoshim@chromium.org, Apr 13 2016

Blocking: -600636

►

Issue 599364 link

Issue metadata

Make cache control flags consistent

Issue description

Comment 1 by toyoshim@chromium.org, Mar 31 2016

Comment 1 Deleted

Comment 2 by toyoshim@chromium.org, Mar 31 2016

Comment 2 Deleted

Comment 3 by toyoshim@chromium.org, Mar 31 2016

Comment 3 Deleted

Comment 4 by toyoshim@chromium.org, Mar 31 2016

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Apr 1 2016

Comment 5 Deleted

Comment 6 by toyoshim@chromium.org, Apr 1 2016

Comment 6 Deleted

Comment 7 by bugdroid1@chromium.org, Apr 1 2016

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Apr 1 2016

Comment 8 Deleted

Comment 9 by bugdroid1@chromium.org, Apr 4 2016

Comment 9 Deleted

Comment 10 by dgozman@chromium.org, Apr 4 2016

Comment 10 Deleted

Comment 11 by toyoshim@chromium.org, Apr 5 2016

Comment 11 Deleted

Comment 12 by bugdroid1@chromium.org, Apr 5 2016

Comment 12 Deleted

Comment 13 by toyoshim@chromium.org, Apr 6 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Apr 8 2016

Comment 14 Deleted

Comment 15 by bugdroid1@chromium.org, Apr 8 2016

Comment 15 Deleted

Comment 16 by toyoshim@chromium.org, Apr 13 2016

Comment 16 Deleted

Comment 17 by toyoshim@chromium.org, Apr 13 2016

Comment 17 Deleted

Comment 18 by toyoshim@chromium.org, Apr 13 2016

Comment 18 Deleted

Comment 19 by toyoshim@chromium.org, Apr 13 2016

Comment 19 Deleted

Sign in to add a comment