Issue metadata
Sign in to add a comment
|
Regression: Wrong zoom icon is shown for ‘100’ percent after enabling the ‘Material design in the browser’s top chrome’ flags
Reported by
dmascare...@etouch.net,
Mar 31 2016
|
||||||||||||||||||||||
Issue descriptionChrome Version: 51.0.2694.1 (Official Build) d916c77d6610e3821101f1c7baf099f4982a1662-refs/branch-heads/2694@{#1} 64 bit OS: MAC Pre condition: Select 'Material' option for 'Material design in the browser's top chrome'. What steps will reproduce the problem? 1. Launch chrome,open NTP and press ‘Cmd++’ 2. Click on zoom icon and then click on ‘-‘ sign of the zoom bubble, till NTP zoom-in to 100% 3. Observe the ‘Zoom’ icon. Actual: Wrong zoom icon is shown (i.e. Zoom icon contain ‘+’ sign within it ) Expected: Proper zoom icon should be shown.(i.e Zoom icon should contain ‘.’/dot within it.) This is regression issue, broke in ‘M 51’ and below is narrow bisect: https://chromium.googlesource.com/chromium/src/+log/df644193ff164f1d3df85d857f2b21b5ba51f77e..e083cc6e0b6d6e0e345b553041f2e241aca5e448?pretty=fuller&n=100 Suspecting: r381567 Good build:51.0.2680.0 Bad Build:51.0.2681.0 Note: Issue is not seen on Windows and Linux OS.
,
Mar 31 2016
I believe this is working as intended for Material Design, but double-checking with sgabriel@.
,
Mar 31 2016
I'm having trouble seeing on the videos. They are too compressed. The zoom icon logic is: <100% = "-" 100% = "." >100% = "+"
,
Mar 31 2016
dmascarenhas@, can you please post screenshots instead of videos?
,
Mar 31 2016
Looking at the list of vector icons there is only ZOOM_PLUS and ZOOM_MINUS. I assume the intent for MD is there is no ZOOM_NORMAL? The Views code that draws this icon has the following comment: // The icon is hidden when the zoom level is default. Right now I am drawing the ZOOM_PLUS for the no-zoom state.
,
Apr 1 2016
You are right we changed the behavior for MD. New behavior is displaying nothing at 100%.
,
Apr 4 2016
,
Apr 5 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/031da13459459a77f602577a8d7379597c82e182 commit 031da13459459a77f602577a8d7379597c82e182 Author: shrike <shrike@chromium.org> Date: Tue Apr 05 16:36:41 2016 [Mac] Display no icon for ZOOM_NORMAL state in zoom decoration. In Material Design there is no icon displayed for the 100% zoom state. BUG= 599361 Review URL: https://codereview.chromium.org/1858823003 Cr-Commit-Position: refs/heads/master@{#385192} [modify] https://crrev.com/031da13459459a77f602577a8d7379597c82e182/chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm
,
Apr 5 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Mar 31 2016