New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599331 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Not on Chrome anymore
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Cronet bots crashing all the time

Project Member Reported by pauljensen@chromium.org, Mar 31 2016

Issue description

Looks like every test is crashing:
https://build.chromium.org/p/chromium.android/console

Call stack is something like this:
StringObject::utfLength() const+17
base::android::ConvertJavaStringToUTF8(_JNIEnv*, _jstring*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*)+16
base::android::ConvertJavaStringToUTF8(_JNIEnv*, base::android::JavaRef<_jstring*> const&)+20
Java_org_chromium_net_CronetUrlRequestContext_nativeCreateRequestContextConfig+106
Java_org_chromium_net_CronetUrlRequestContext_nativeCreateRequestContextConfig

This looks like the most recent successful run:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Data%20Reduction%20Proxy%20Builder/builds/1618
which used r383999
This looks like the first failed run:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20ARMv6%20Builder/builds/1586
which used r384013

This looks like the culprit:
https://codereview.chromium.org/1828193002

I think we should revert ASAP and investigate a fix later.
 

Comment 1 by bauerb@chromium.org, Mar 31 2016

Status: Started (was: Assigned)
Fix is up at https://codereview.chromium.org/1850573003/, but I couldn't get the test to run locally. Are there trybots for this?

Comment 2 by torne@chromium.org, Mar 31 2016

Seems like this should be on trybots if it can be broken by changes to general android code. :/
We have one trybot called android_cronet_tester.

Comment 4 by mge...@chromium.org, Mar 31 2016

Cc: jbudorick@chromium.org bauerb@chromium.org xunji...@chromium.org agrieve@chromium.org mef@chromium.org
 Issue 599506  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d9c5cae125a244f561276d2e8824dd2ec04dcdc

commit 1d9c5cae125a244f561276d2e8824dd2ec04dcdc
Author: bauerb <bauerb@chromium.org>
Date: Thu Mar 31 19:10:47 2016

CroNet: Allow null strings in config when creating a UrlRequestContextConfig.

BUG= 599331 

Review URL: https://codereview.chromium.org/1850573003

Cr-Commit-Position: refs/heads/master@{#384355}

[modify] https://crrev.com/1d9c5cae125a244f561276d2e8824dd2ec04dcdc/components/cronet/android/cronet_url_request_context_adapter.cc

Status: Fixed (was: Started)

Sign in to add a comment