New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 599328 link

Starred by 1 user
Status: Started
Owner:
█ mgiuca@chromium.org
Long OOO (go/where-is-mgiuca)
Cc:
calamity@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 1
Type: Bug



Sign in to add a comment

App list: DispatchDragEventForReparent is broken

Project Member Reported by mgiuca@chromium.org, Mar 31 2016 
Version: All
OS: All views

AppListFolderView::DispatchDragEventForReparent calculates the drag_point_in_root_grid and then ignores it, using the drag_point_in_folder_grid instead.

This turns out to work correctly at the moment but only because the root grid view and folder view are at the same space. Adding the message banner ( Issue 576531 ) will break this assumption so it needs to be fixed.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5319c96ce234793b9ae72a914ef5bb2e12ca8ca1

commit 5319c96ce234793b9ae72a914ef5bb2e12ca8ca1
Author: mgiuca <mgiuca@chromium.org>
Date: Thu Mar 31 06:06:41 2016

App list: Fixed folder reparenting calculation.

Doesn't have any visible effect but it fixes an assumption that will
soon not be true (that the root grid view and folder view are at the
same location).

BUG=599328

Review URL: https://codereview.chromium.org/1846683004

Cr-Commit-Position: refs/heads/master@{#384198}

[modify] https://crrev.com/5319c96ce234793b9ae72a914ef5bb2e12ca8ca1/ui/app_list/views/app_list_folder_view.cc

Comment 2 by vadimt@chromium.org, Oct 11 2017

Labels: Not-Touch-Friendly-Launcher
►

Sign in to add a comment