New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599322 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 599320



Sign in to add a comment

GN: add version of ios/third_party/ochamcrest/ochamcrest.gyp

Project Member Reported by sdefresne@chromium.org, Mar 31 2016

Issue description

Required by ios/web/ios_web_shell_tests.gyp.
 
Status: Started (was: Assigned)
Labels: Build-Tools-GN
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8fab21c694073ca4db23495b715770385c597e1a

commit 8fab21c694073ca4db23495b715770385c597e1a
Author: sdefresne <sdefresne@chromium.org>
Date: Wed Apr 13 10:14:18 2016

[iOS/GN] Convert //ios/third_party/ochamcrest to build a framework.

Add support for copying public headers to the ios_framework_bundle
template and use this to implement the //ios/third_party/ochamcrest
target.

Add a set_defaults for ios_framework_bundle and mac_framework_bundle
to build/config/BUILDCONFIG.gn so that overriding "configs" works as
expected.

BUG= 599322 

Review URL: https://codereview.chromium.org/1879493002

Cr-Commit-Position: refs/heads/master@{#386957}

[modify] https://crrev.com/8fab21c694073ca4db23495b715770385c597e1a/build/config/BUILDCONFIG.gn
[modify] https://crrev.com/8fab21c694073ca4db23495b715770385c597e1a/build/config/ios/rules.gni
[modify] https://crrev.com/8fab21c694073ca4db23495b715770385c597e1a/ios/third_party/ochamcrest/BUILD.gn

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/598d2cbd50dee2c81201c10f662a74c7dd7dec18

commit 598d2cbd50dee2c81201c10f662a74c7dd7dec18
Author: sdefresne <sdefresne@chromium.org>
Date: Thu Apr 14 09:46:25 2016

[iOS/GN] Add -install_name to the shared_library ldflags on iOS.

The generated dylib will be available to the application via the
framework bundle so add "-install_name @rpath/XXX.framework/XXX"
when using the "ios_framework_bundle" template.

BUG= 599321 , 599322 

Review URL: https://codereview.chromium.org/1882423002

Cr-Commit-Position: refs/heads/master@{#387273}

[modify] https://crrev.com/598d2cbd50dee2c81201c10f662a74c7dd7dec18/build/config/ios/rules.gni

Sign in to add a comment