New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599321 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 599320



Sign in to add a comment

GN: add gn version of ios/third_party/earl_grey/earl_grey.gyp

Project Member Reported by sdefresne@chromium.org, Mar 31 2016

Issue description

Required for ios/web/ios_web_shell_tests.gyp.
 
Labels: Build-Tools-GN
Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/22de3c95e286c337ebdf32e424f911d00f209350

commit 22de3c95e286c337ebdf32e424f911d00f209350
Author: sdefresne <sdefresne@chromium.org>
Date: Thu Apr 14 08:51:10 2016

[iOS/GN] Convert //ios/third_party/earl_grey to build with GN.

Fix the ios_framework_bundle template to create a new public config
so that anyone depending on the target will correctly link against
it. Change framework_bundle to use public_deps in order to make the
public config accessible.

Create //ios/third_party/earl_grey target.

BUG= 599321 

Review URL: https://codereview.chromium.org/1879003002

Cr-Commit-Position: refs/heads/master@{#387265}

[modify] https://crrev.com/22de3c95e286c337ebdf32e424f911d00f209350/BUILD.gn
[modify] https://crrev.com/22de3c95e286c337ebdf32e424f911d00f209350/build/config/ios/rules.gni
[modify] https://crrev.com/22de3c95e286c337ebdf32e424f911d00f209350/build/config/mac/rules.gni
[add] https://crrev.com/22de3c95e286c337ebdf32e424f911d00f209350/ios/third_party/earl_grey/BUILD.gn
[modify] https://crrev.com/22de3c95e286c337ebdf32e424f911d00f209350/ios/third_party/ochamcrest/BUILD.gn

Status: Fixed (was: Started)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/598d2cbd50dee2c81201c10f662a74c7dd7dec18

commit 598d2cbd50dee2c81201c10f662a74c7dd7dec18
Author: sdefresne <sdefresne@chromium.org>
Date: Thu Apr 14 09:46:25 2016

[iOS/GN] Add -install_name to the shared_library ldflags on iOS.

The generated dylib will be available to the application via the
framework bundle so add "-install_name @rpath/XXX.framework/XXX"
when using the "ios_framework_bundle" template.

BUG= 599321 , 599322 

Review URL: https://codereview.chromium.org/1882423002

Cr-Commit-Position: refs/heads/master@{#387273}

[modify] https://crrev.com/598d2cbd50dee2c81201c10f662a74c7dd7dec18/build/config/ios/rules.gni

Sign in to add a comment