New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 599286 link

Starred by 2 users
Status: Verified
Owner:
fukino@chromium.org
Closed: Mar 2016
Cc:
█ hirono@chromium.org
yawano@chromium.org
sgabr...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Files app/ gallery app press to active is no longer circular

Project Member Reported by sgabr...@chromium.org, Mar 30 2016 
How to repro:
click any toolbar button in the files app or gallery app toolbar that has an active state, e.g the menu button or the sort button. Look at the animation.

We now only display a square bouncing up and down rather than a morphing from the ripple circle to a square. I think this is a regression.

Comment 1 by fukino@chromium.org, Mar 30 2016

Cc: yawano@chromium.org
Reproduced. Thank you for pointing this out!
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f4f01ec7e01d008e69cef8f298595f8b1e61e439

commit f4f01ec7e01d008e69cef8f298595f8b1e61e439
Author: fukino <fukino@chromium.org>
Date: Thu Mar 31 06:04:32 2016

Fix morphing of files-toggle-ripple by passing proper property names to Animation API.

BUG= 599286 
TEST=manually

Review URL: https://codereview.chromium.org/1841833004

Cr-Commit-Position: refs/heads/master@{#384197}

[modify] https://crrev.com/f4f01ec7e01d008e69cef8f298595f8b1e61e439/ui/file_manager/file_manager/foreground/elements/files_toggle_ripple.js

Comment 3 by fukino@chromium.org, Mar 31 2016

Status: Fixed (was: Assigned)

Comment 4 by patricia@chromium.org, Apr 11 2016

Labels: VerifyIn-51

Comment 5 by rookrishna@chromium.org, May 3 2016

Status: Verified (was: Fixed)
Verified
►

Sign in to add a comment