New issue
Advanced search Search tips

Issue 599277 link

Starred by 1 user
Status: Untriaged
Owner: ----
Cc:
w...@chromium.org
lambroslambrou@chromium.org
rkjnsn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature



Sign in to add a comment

Make sure Chromoting GN header checks are enabled and passing

Project Member Reported by rkjnsn@chromium.org, Mar 30 2016 
GN has a feature to verify includes to make sure the corresponding dependencies are present in the build rules. There is a white list to specify what parts of the tree should have this check run. We should make sure we are included in the whitelist and address any errors that may be uncovered as a result.

Comment 1 by sergeyu@chromium.org, Mar 31 2016 

Thanks for working on this! That would help to avoid bugs like crbug.com/597559.

Comment 2 by w...@chromium.org, Jan 29 2018

Cc: w...@chromium.org rkjnsn@chromium.org
Owner: ----
Status: Untriaged (was: Assigned)
Returning this to Untriaged.  I hit an issue with this today; will upload one or two CLs to get at least some GN check coverage working. :)

Comment 3 by w...@chromium.org, Feb 12 2018 

https://chromium-review.googlesource.com/c/chromium/src/+/910730 as a workaround for the implicit //base dependencies, FWIW.

Comment 4 by w...@chromium.org, Feb 12 2018 

https://chromium-review.googlesource.com/c/chromium/src/+/910730 as a workaround for the implicit //base dependencies, FWIW.

Comment 5 by jamiewa...@chromium.org, May 15 2018

Status: WontFix (was: Untriaged)
No activity for a while, so it doesn't seem important.

Comment 6 by w...@chromium.org, May 15 2018

Status: Untriaged (was: WontFix)
Actually there have been several patch-ups to the BUILD.gn files since I filed this, each fixing individual specific instances of build breakage, without actually getting GN check working (e.g. when a new generated header was added to //base).
►

Sign in to add a comment