New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 599274 link

Starred by 1 user
Status: Verified
Owner:
█ tsergeant@chromium.org
Not on Chrome
Closed: May 2016
Cc:
calamity@chromium.org
█ tsergeant@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 425625



Sign in to add a comment

MD History: High DPI favicons displaying incorrectly

Project Member Reported by tsergeant@chromium.org, Mar 30 2016 
Chrome Version       : 51.0.2688.0
OS Version: 8104.1.0

What steps will reproduce the problem?
1. Enable MD history
2. Visit chrome://history on a device with a high DPI display

What is the expected result?
All favicons should appear correctly

What happens instead of that?
Some favicons appear in a 2x2 grid. This happens inconsistently for the same site/favicon. See attached screenshot

UserAgentString: Mozilla/5.0 (X11; CrOS x86_64 8104.1.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2688.0 Safari/537.36
Screenshot 2016-03-31 at 9.43.17 AM.png
362 KB View Download

Comment 1 by tsergeant@chromium.org, Mar 30 2016 

Here's a screenshot of the same history items in non-MD history. You can see that the ones which are tiled in MD history fallback to stretching out the low-dpi favicon in non-MD history.
Screenshot 2016-03-31 at 9.53.21 AM.png
282 KB View Download

Comment 2 by tsergeant@chromium.org, May 18 2016

Owner: tsergeant@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, May 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2eb9a83d0f53707c230eb0d6c41215001da3c0fa

commit 2eb9a83d0f53707c230eb0d6c41215001da3c0fa
Author: tsergeant <tsergeant@chromium.org>
Date: Thu May 19 03:20:45 2016

MD History: Fix favicon sizing on high DPI screens

The Chrome favicon cache will sometimes only have 16x16px favicons
available, this change ensures that these icons are displayed without
tiling in a 2x2 grid on high DPI displays which expect a 32x32px favicon.

BUG= 599274 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/1989773002
Cr-Commit-Position: refs/heads/master@{#394650}

[modify] https://crrev.com/2eb9a83d0f53707c230eb0d6c41215001da3c0fa/chrome/browser/resources/md_history/shared_style.html

Comment 4 by tsergeant@chromium.org, May 19 2016

Status: Fixed (was: Started)

Comment 5 by patricia@chromium.org, Jul 1 2016

Labels: VerifyIn-53

Comment 6 by patricia@chromium.org, Aug 29 2016

Labels: VerifyIn-54

Comment 7 by ka...@chromium.org, Aug 31 2016

Labels: Bulk-Verified
Status: Verified (was: Fixed)
►

Sign in to add a comment