Was there a recent change to the internals of the media stack on Windows? +dalecurtis

er, on Mac OS X I mean?

ccameron@ made a recent change, but I think it's been reverted. cc:liberato in case I'm forgetting something, but our work has been almost entirely on Android lately.

Yes, I changed us to decode to 4:2:0 instead of 4:2:2, which means that we can't texture out of the video as RGBA anymore, so we allocate a spare buffer.

The patch's history is:
- initial checkin: r382797
- revert: r383823
- checked in again: r385092

Chris, could you please try to reproduce the flakiness of this test locally? There's no reason it should pass sometimes but fail otherwise.

This is still flaky:

https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/215244
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/214984
https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/214961

I attempted to reproduce locally but it's not easy. It didn't fail with:

./content/test/gpu/run_gpu_test.py webgl_conformance --browser=canary --story-filter=conformance_extensions_oes_texture_float_with_video --pageset-repeat=100

Adding a suppression.

The failure mode is the same as described above:

[ RUN      ] WebglConformance.conformance_extensions_oes_texture_float_with_video
[12430:1299:0421/102929:WARNING:webmediaplayer_impl.cc(330)] Using MultibufferDataSource
[12426:97027:0421/102929:WARNING:simple_synchronous_entry.cc(929)] Could not open platform files for entry.
[12430:1299:0421/102929:WARNING:webmediaplayer_impl.cc(330)] Using MultibufferDataSource
[12426:1299:0421/102929:INFO:CONSOLE(11)] "at (4, 4) expected: 0,255,0 was 0,134,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "testing: video/mp4; codecs="avc1.42E01E, mp4a.40.2"", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Testing texImage2D with flipY=true bindingTarget=TEXTURE_2D", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "FAIL at (4, 4) expected: 0,255,0 was 0,134,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "at (4, 24) expected: 255,0,0 was 0,135,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "FAIL at (4, 24) expected: 255,0,0 was 0,135,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Testing texImage2D with flipY=false bindingTarget=TEXTURE_2D", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "at (4, 4) expected: 255,0,0 was 0,135,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "FAIL at (4, 4) expected: 255,0,0 was 0,135,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "at (4, 24) expected: 0,255,0 was 0,134,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "FAIL at (4, 24) expected: 0,255,0 was 0,134,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Testing texSubImage2D with flipY=true bindingTarget=TEXTURE_2D", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "at (4, 4) expected: 0,255,0 was 0,134,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "FAIL at (4, 4) expected: 0,255,0 was 0,134,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "at (4, 24) expected: 255,0,0 was 0,135,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "FAIL at (4, 24) expected: 255,0,0 was 0,135,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Testing texSubImage2D with flipY=false bindingTarget=TEXTURE_2D", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "at (4, 4) expected: 255,0,0 was 0,135,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "FAIL at (4, 4) expected: 255,0,0 was 0,135,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "at (4, 24) expected: 0,255,0 was 0,134,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "FAIL at (4, 24) expected: 0,255,0 was 0,134,0", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "testing: video/webm; codecs="vp8, vorbis"", source:  (11)
[12430:1299:0421/102929:WARNING:webmediaplayer_impl.cc(330)] Using MultibufferDataSource
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Testing texImage2D with flipY=true bindingTarget=TEXTURE_2D", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Testing texImage2D with flipY=false bindingTarget=TEXTURE_2D", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Testing texSubImage2D with flipY=true bindingTarget=TEXTURE_2D", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Testing texSubImage2D with flipY=false bindingTarget=TEXTURE_2D", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "", source:  (11)
[12426:1299:0421/102929:INFO:CONSOLE(11)] "testing: video/ogg; codecs="theora, vorbis"", source:  (11)
[12430:1299:0421/102930:WARNING:webmediaplayer_impl.cc(330)] Using MultibufferDataSource
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Testing texImage2D with flipY=true bindingTarget=TEXTURE_2D", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Testing texImage2D with flipY=false bindingTarget=TEXTURE_2D", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Testing texSubImage2D with flipY=true bindingTarget=TEXTURE_2D", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Testing texSubImage2D with flipY=false bindingTarget=TEXTURE_2D", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "testing: video/mp4; codecs="avc1.42E01E, mp4a.40.2"", source:  (11)
[12430:1299:0421/102930:WARNING:webmediaplayer_impl.cc(330)] Using MultibufferDataSource
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Testing texSubImage2D with flipY=true bindingTarget=TEXTURE_CUBE_MAP", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Testing texSubImage2D with flipY=false bindingTarget=TEXTURE_CUBE_MAP", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "testing: video/webm; codecs="vp8, vorbis"", source:  (11)
[12430:1299:0421/102930:WARNING:webmediaplayer_impl.cc(330)] Using MultibufferDataSource
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Testing texSubImage2D with flipY=true bindingTarget=TEXTURE_CUBE_MAP", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Testing texSubImage2D with flipY=false bindingTarget=TEXTURE_CUBE_MAP", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "", source:  (11)
[12426:1299:0421/102930:INFO:CONSOLE(11)] "testing: video/ogg; codecs="theora, vorbis"", source:  (11)
[12430:1299:0421/102930:WARNING:webmediaplayer_impl.cc(330)] Using MultibufferDataSource
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Testing texSubImage2D with flipY=true bindingTarget=TEXTURE_CUBE_MAP", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Testing texSubImage2D with flipY=false bindingTarget=TEXTURE_CUBE_MAP", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[12426:1299:0421/102931:INFO:CONSOLE(11)] "Checking upper left corner", source:  (11)
Traceback (most recent call last):
  File "/b/swarm_slave/work/isolated/run7HO6nO/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 84, in _RunStoryAndProcessErrorIfNeeded
    state.RunStory(results)
  File "/b/swarm_slave/work/isolated/run7HO6nO/content/test/gpu/gpu_tests/gpu_test_base.py", line 122, in RunStory
    RunStoryWithRetries(DesktopGpuSharedPageState, self, results)
  File "/b/swarm_slave/work/isolated/run7HO6nO/content/test/gpu/gpu_tests/gpu_test_base.py", line 72, in RunStoryWithRetries
    super(cls, shared_page_state).RunStory(results)
  File "/b/swarm_slave/work/isolated/run7HO6nO/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 326, in RunStory
    self._current_page, self._current_tab, results)
  File "/b/swarm_slave/work/isolated/run7HO6nO/content/test/gpu/gpu_tests/webgl_conformance.py", line 87, in ValidateAndMeasurePage
    raise page_test.Failure(_WebGLTestMessages(tab))
Failure: at (4, 4) expected: 0,255,0 was 0,134,0

testing: video/mp4; codecs="avc1.42E01E, mp4a.40.2"
Testing texImage2D with flipY=true bindingTarget=TEXTURE_2D
Checking lower left corner
FAIL at (4, 4) expected: 0,255,0 was 0,134,0
Checking upper left corner
at (4, 24) expected: 255,0,0 was 0,135,0
FAIL at (4, 24) expected: 255,0,0 was 0,135,0
Testing texImage2D with flipY=false bindingTarget=TEXTURE_2D
Checking lower left corner
at (4, 4) expected: 255,0,0 was 0,135,0
FAIL at (4, 4) expected: 255,0,0 was 0,135,0
Checking upper left corner
at (4, 24) expected: 0,255,0 was 0,134,0
FAIL at (4, 24) expected: 0,255,0 was 0,134,0
Testing texSubImage2D with flipY=true bindingTarget=TEXTURE_2D
Checking lower left corner
at (4, 4) expected: 0,255,0 was 0,134,0
FAIL at (4, 4) expected: 0,255,0 was 0,134,0
Checking upper left corner
at (4, 24) expected: 255,0,0 was 0,135,0
FAIL at (4, 24) expected: 255,0,0 was 0,135,0
Testing texSubImage2D with flipY=false bindingTarget=TEXTURE_2D
Checking lower left corner
at (4, 4) expected: 255,0,0 was 0,135,0
FAIL at (4, 4) expected: 255,0,0 was 0,135,0
Checking upper left corner
at (4, 24) expected: 0,255,0 was 0,134,0
FAIL at (4, 24) expected: 0,255,0 was 0,134,0

testing: video/webm; codecs="vp8, vorbis"
Testing texImage2D with flipY=true bindingTarget=TEXTURE_2D
Checking lower left corner
Checking upper left corner
Testing texImage2D with flipY=false bindingTarget=TEXTURE_2D
Checking lower left corner
Checking upper left corner
Testing texSubImage2D with flipY=true bindingTarget=TEXTURE_2D
Checking lower left corner
Checking upper left corner
Testing texSubImage2D with flipY=false bindingTarget=TEXTURE_2D
Checking lower left corner
Checking upper left corner

testing: video/ogg; codecs="theora, vorbis"
Testing texImage2D with flipY=true bindingTarget=TEXTURE_2D
Checking lower left corner
Checking upper left corner
Testing texImage2D with flipY=false bindingTarget=TEXTURE_2D
Checking lower left corner
Checking upper left corner
Testing texSubImage2D with flipY=true bindingTarget=TEXTURE_2D
Checking lower left corner
Checking upper left corner
Testing texSubImage2D with flipY=false bindingTarget=TEXTURE_2D
Checking lower left corner
Checking upper left corner

testing: video/mp4; codecs="avc1.42E01E, mp4a.40.2"
Testing texSubImage2D with flipY=true bindingTarget=TEXTURE_CUBE_MAP
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Testing texSubImage2D with flipY=false bindingTarget=TEXTURE_CUBE_MAP
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner

testing: video/webm; codecs="vp8, vorbis"
Testing texSubImage2D with flipY=true bindingTarget=TEXTURE_CUBE_MAP
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Testing texSubImage2D with flipY=false bindingTarget=TEXTURE_CUBE_MAP
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner

testing: video/ogg; codecs="theora, vorbis"
Testing texSubImage2D with flipY=true bindingTarget=TEXTURE_CUBE_MAP
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Testing texSubImage2D with flipY=false bindingTarget=TEXTURE_CUBE_MAP
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner
Checking lower left corner
Checking upper left corner


[  FAILED  ] WebglConformance.conformance_extensions_oes_texture_float_with_video (2261 ms)



There's probably a race condition in the initialization of the hardware accelerated video decoder. Is anyone available to dig deeper into this?

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ed89272f8e8bff34af8716b64a8a0e6b91c4fb4

commit 1ed89272f8e8bff34af8716b64a8a0e6b91c4fb4
Author: kbr <kbr@chromium.org>
Date: Thu Apr 21 18:52:02 2016

Suppress flaky failure of conformance_extensions_oes_texture_float_with_video.

BUG=599272
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
TBR=ccameron@chromium.org,dalecurtis@chromium.org

Review URL: https://codereview.chromium.org/1905863004

Cr-Commit-Position: refs/heads/master@{#388831}

[modify] https://crrev.com/1ed89272f8e8bff34af8716b64a8a0e6b91c4fb4/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

All of the known bugs with the h264 path have been fixed for a week or so, so I'm very surprised to see that there are still flakes.

Again, I tried reproducing this locally without success, but maybe more cycles are needed. The test is definitely still flaky though.

I tried again locally -- 200 cycles -- in the following configs
- allow dynamic switching
- force dGPU only
- force iGPU only
- mac overlays disabled (the 10.10 bots are in that config)

I realized last night that the probable reason I couldn't reproduce this is it requires one of the new MacBook Pros with AMD GPU. Chris, do you have one of those?

No, I've been trying on Intel+NV. Do you know if MTV QA has one?

We have one in our office in MTV.

Unfortunately this is still happening and has been seen on Intel GPUs too. For example:

https://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/295546

WebglConformance_conformance_extensions_oes_texture_float_with_video (gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest) ... [35732:97795:0913/135023:WARNING:simple_synchronous_entry.cc(1054)] Could not open platform files for entry.
[35732:1299:0913/135023:ERROR:interface_registry.cc(99)] Failed to locate a binder for interface: dom_distiller::mojom::DistillabilityService
[35732:1299:0913/135023:ERROR:interface_registry.cc(99)] Failed to locate a binder for interface: dom_distiller::mojom::DistillabilityService
[35732:1299:0913/135023:INFO:CONSOLE(11)] "shouldBe 0,255,0
at (4, 4) expected: 0,255,0 was 0,135,0", source:  (11)
[35732:1299:0913/135023:INFO:CONSOLE(11)] "", source:  (11)
[35732:1299:0913/135023:INFO:CONSOLE(11)] "testing: video/mp4; codecs="avc1.42E01E, mp4a.40.2"", source:  (11)
[35732:1299:0913/135023:INFO:CONSOLE(11)] "Testing texImage2D with flipY=true bindingTarget=TEXTURE_2D", source:  (11)
[35732:1299:0913/135023:INFO:CONSOLE(11)] "Checking lower left corner", source:  (11)
[35732:1299:0913/135023:INFO:CONSOLE(11)] "FAIL shouldBe 0,255,0
at (4, 4) expected: 0,255,0 was 0,135,0", source:  (11)
...

Expanding the flaky suppression.

This is surely due to some race condition in the hardware accelerated video decoding pipeline, or similar.

The main code for this test lives in the following files:
src/third_party/webgl/src/sdk/tests/conformance/extensions/oes-texture-float-with-video.html
src/third_party/webgl/src/sdk/tests/js/tests/tex-image-and-sub-image-2d-with-video.js
src/third_party/webgl/src/sdk/tests/js/webgl-test-utils.js

and the function which waits for the video element to become ready for upload is the following:

var startPlayingAndWaitForVideo = function(video, callback) {
  var gotPlaying = false;
  var gotTimeUpdate = false;

  var maybeCallCallback = function() {
    if (gotPlaying && gotTimeUpdate && callback) {
      callback(video);
      callback = undefined;
      video.removeEventListener('playing', playingListener, true);
      video.removeEventListener('timeupdate', timeupdateListener, true);
    }
  };

  var playingListener = function() {
    gotPlaying = true;
    maybeCallCallback();
  };

  var timeupdateListener = function() {
    // Checking to make sure the current time has advanced beyond
    // the start time seems to be a reliable heuristic that the
    // video element has data that can be consumed.
    if (video.currentTime > 0.0) {
      gotTimeUpdate = true;
      maybeCallCallback();
    }
  };

  video.addEventListener('playing', playingListener, true);
  video.addEventListener('timeupdate', timeupdateListener, true);
  video.loop = true;
  video.play();
};


Can anyone see anything wrong with the heuristics above? Revisiting https://html.spec.whatwg.org/multipage/embedded-content.html#the-video-element , they still seem valid.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7221605a9704f3ee9d5399948942881c4834ef4

commit c7221605a9704f3ee9d5399948942881c4834ef4
Author: kbr <kbr@chromium.org>
Date: Wed Sep 14 00:12:19 2016

Generalize suppression for oes-texture-float-with-video.html.

It's failing on multiple GPU types on macOS.

BUG=599272
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=zmo@chromium.org,ccameron@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2331363004
Cr-Commit-Position: refs/heads/master@{#418429}

[modify] https://crrev.com/c7221605a9704f3ee9d5399948942881c4834ef4/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

This is a bit of an old issue and the flakiness dashboard shows it as Skip [1]
-- shouldn't we close/archive/fix it ?

[1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webgl_conformance_tests&tests=gpu_tests%2Fwebgl_conformance_integration_test%2FWebGLConformanceIntegrationTest%2FWebglConformance_conformance_extensions_oes_texture_float_with_video

It's unfortunate that one of the basic WebGL conformance tests is marked flaky on macOS on all devices:

https://cs.chromium.org/chromium/src/content/test/gpu/gpu_tests/webgl_conformance_expectations.py?l=440

On the other hand, this test doesn't apply to WebGL 2.0, so going forward perhaps this failure is less significant.