This would affect dev right?
If not, feel free to remove release-block.

o_O

Which build exactly is that?

Looked into this, seems everything is there but somehow OFFICIAL_BUILD is 0 in the ChromeVersionConstants.java template.

//build/config/BUILD.gn does add the define here: https://code.google.com/p/chromium/codesearch#chromium/src/build/config/BUILD.gn&l=246

Will ask gn-dev for help.

version.py actually checks whether the CHROME_BUILD_TYPE environment variable is set to '_official' (https://code.google.com/p/chromium/codesearch#chromium/src/build/util/version.py&sq=package:chromium&dr=C&l=39). Do you have a link to the builder?

I'm going to change version.py to accept a flag for that as well, and have the gn build system pass in that flag when is_official_build is set to true.

WDYT? gn-dev thread: https://groups.google.com/a/chromium.org/d/topic/gn-dev/Nf25d0qiJ_k/discussion

Removing RBD as when we build dev the environment variable is set. I'll send out a CL to propagate is_official_build to the version script, that should fix it for local official builds.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eab85df0275b825e428954c4030e358ce968ecd9

commit eab85df0275b825e428954c4030e358ce968ecd9
Author: wnwen <wnwen@chromium.org>
Date: Thu Mar 31 18:33:43 2016

Propagate is_official_build to version script.

OFFICIAL_BUILD is a special variable in the version script which
takes its value from the environment variable. This means that local
builds with is_official_build will not actually result in
ChromeVersionConstants.isOfficialBuild() returning true.

This CL propagates the is_official_build truthiness to the script so
official builds no longer depend solely on the environment variable.

BUG= 599268 

Review URL: https://codereview.chromium.org/1838173005

Cr-Commit-Position: refs/heads/master@{#384340}

[modify] https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9/build/util/version.py
[modify] https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9/chrome/version.gni

Verified by hzl@.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/756e9b934bf1d706dd59ab39bed2af842b67063b

commit 756e9b934bf1d706dd59ab39bed2af842b67063b
Author: skyostil <skyostil@chromium.org>
Date: Fri Apr 01 16:56:10 2016

Revert of Propagate is_official_build to version script. (patchset #1 id:1 of https://codereview.chromium.org/1838173005/ )

Reason for revert:
Made all the Android perf bots red: https://bugs.chromium.org/p/chromium/issues/detail?id=599830

Original issue's description:
> Propagate is_official_build to version script.
>
> OFFICIAL_BUILD is a special variable in the version script which
> takes its value from the environment variable. This means that local
> builds with is_official_build will not actually result in
> ChromeVersionConstants.isOfficialBuild() returning true.
>
> This CL propagates the is_official_build truthiness to the script so
> official builds no longer depend solely on the environment variable.
>
> BUG= 599268 
>
> Committed: https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9
> Cr-Commit-Position: refs/heads/master@{#384340}

TBR=agrieve@chromium.org,thestig@chromium.org,wnwen@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 599268 

Review URL: https://codereview.chromium.org/1851843002

Cr-Commit-Position: refs/heads/master@{#384610}

[modify] https://crrev.com/756e9b934bf1d706dd59ab39bed2af842b67063b/build/util/version.py
[modify] https://crrev.com/756e9b934bf1d706dd59ab39bed2af842b67063b/chrome/version.gni

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87d01a7e475b0785364328af5b22b15b28a40e66

commit 87d01a7e475b0785364328af5b22b15b28a40e66
Author: wnwen <wnwen@chromium.org>
Date: Mon Apr 04 21:15:38 2016

Reland of Propagate is_official_build to version script. (patchset #1 id:1 of https://codereview.chromium.org/1851843002/ )

Reason for revert:
The actual crash was in OmahaClient, which is fixed in: http://crrev.com/1856823002

Original issue's description:
> Revert of Propagate is_official_build to version script. (patchset #1 id:1 of https://codereview.chromium.org/1838173005/ )
>
> Reason for revert:
> Made all the Android perf bots red: https://bugs.chromium.org/p/chromium/issues/detail?id=599830
>
> Original issue's description:
> > Propagate is_official_build to version script.
> >
> > OFFICIAL_BUILD is a special variable in the version script which
> > takes its value from the environment variable. This means that local
> > builds with is_official_build will not actually result in
> > ChromeVersionConstants.isOfficialBuild() returning true.
> >
> > This CL propagates the is_official_build truthiness to the script so
> > official builds no longer depend solely on the environment variable.
> >
> > BUG= 599268 
> >
> > Committed: https://crrev.com/eab85df0275b825e428954c4030e358ce968ecd9
> > Cr-Commit-Position: refs/heads/master@{#384340}
>
> TBR=agrieve@chromium.org,thestig@chromium.org,wnwen@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 599268 
>
> Committed: https://crrev.com/756e9b934bf1d706dd59ab39bed2af842b67063b
> Cr-Commit-Position: refs/heads/master@{#384610}

TBR=agrieve@chromium.org,thestig@chromium.org,skyostil@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 599268 

Review URL: https://codereview.chromium.org/1856843002

Cr-Commit-Position: refs/heads/master@{#385007}

[modify] https://crrev.com/87d01a7e475b0785364328af5b22b15b28a40e66/build/util/version.py
[modify] https://crrev.com/87d01a7e475b0785364328af5b22b15b28a40e66/chrome/version.gni

#11, did this CL fix the bug? I check out that commit but looks like it still has the problem

@mlliu - That should have fixed it, are you building with the gn args in the description? You need is_official_build set to true.

@wnwen, it's fixed if building in gn. Thanks!

Excellent, thanks for confirming! Will ignore gyp, heh.