New issue
Advanced search Search tips

Issue 599264 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug

Blocked on:
issue 596128

Blocking:
issue 547071



Sign in to add a comment

Mac: deprecated methods in third_party/mozilla/mozilla.NSURL+Utils.m for -URLFromInetloc:

Project Member Reported by tapted@chromium.org, Mar 30 2016

Issue description

Chrome Version       : 49.0.2623.110
OS Version: OS X 10.11.4

Building with a 10.9 deployment target emits

OBJC obj/third_party/mozilla/mozilla.NSURL+Utils.o
../../third_party/mozilla/NSURL+Utils.m:70:17: warning: 'FSPathMakeRef' is deprecated: first deprecated in OS X 10.8 [-Wdeprecated-declarations]
  if (inFile && FSPathMakeRef((UInt8 *)[inFile fileSystemRepresentation], &ref, NULL) == noErr) {
Also in NSURL+Utils.mm:
 FSOpenResFile
 Get1Resource
 GetMaxResourceSize
 CloseResFile

These are all deprecated. All used in +(NSURL*)URLFromInetloc:(NSString*)inFile
Which is used via NSPasteboard+Utils’ -getURLs:.. by cocoa_dnd_util’s ui::PopulateURLAndTitleFromPasteboard()

Alternatives might be: https://opensource.apple.com/source/WebKit/WebKit-7600.1.25/mac/History/WebURLsWithTitles.h

or methods in components/bookmarks/browser/bookmark_pasteboard_helper_mac.h which appear to do similar things.

But altering PopulateURLAndTitleFromPasteboard looks kinda scary and nontrivial.
 
Blockedon: 596128
Owner: eugene...@chromium.org
Status: Fixed (was: Available)
Fixed by: https://chromium.googlesource.com/chromium/src/+/a1b9e0379d00e4d1711aaf97581c0dd0ac9c21c6

Sign in to add a comment