Lazy instantiate Clear Browsing Data dialog |
||||
Issue descriptionCurrently the Clear Browsing Data dialog is added to the DOM even if the user never clicks on the "Clear Browsing Data" button. Given that this dialog is fairly complex (see screenshot), I think is better to use dom-if and only add the dialog to the DOM once user requests to see it, for performance reasons.
,
Apr 25 2016
,
Apr 26 2016
,
Apr 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b9f313d3f951b3ed38ca76eb4acface40a064d5 commit 1b9f313d3f951b3ed38ca76eb4acface40a064d5 Author: dpapad <dpapad@chromium.org> Date: Wed Apr 27 22:42:21 2016 MD Settings; Lazy instantiate Clear Browsing Data dialog. BUG= 599245 Review-Url: https://codereview.chromium.org/1921913002 Cr-Commit-Position: refs/heads/master@{#390221} [modify] https://crrev.com/1b9f313d3f951b3ed38ca76eb4acface40a064d5/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js [modify] https://crrev.com/1b9f313d3f951b3ed38ca76eb4acface40a064d5/chrome/browser/resources/settings/privacy_page/privacy_page.html [modify] https://crrev.com/1b9f313d3f951b3ed38ca76eb4acface40a064d5/chrome/browser/resources/settings/privacy_page/privacy_page.js [modify] https://crrev.com/1b9f313d3f951b3ed38ca76eb4acface40a064d5/chrome/test/data/webui/settings/privacy_page_test.js
,
Apr 27 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tbuck...@chromium.org
, Apr 12 2016Status: Available (was: Untriaged)