New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599235 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Migrate to a SQLite version of offline storage

Reported by bburns@chromium.org, Mar 30 2016

Issue description

To support larger scale use, as well as more robust search/querying, we need to move to a SQLite implementation of the offline store.

This is a tracking bug for that implementation.

 
Components: UI>Browser>Offline
Labels: -OS-All OS-Android
Project Member

Comment 3 by bugdroid1@chromium.org, May 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f0196c9b2ed667181738cabd2eb6170f889f0c9

commit 8f0196c9b2ed667181738cabd2eb6170f889f0c9
Author: bburns <bburns@chromium.org>
Date: Thu May 05 23:56:06 2016

switch to SQL for metadata storage.

BUG= 599235 

Review-Url: https://codereview.chromium.org/1953203002
Cr-Commit-Position: refs/heads/master@{#391956}

[modify] https://crrev.com/8f0196c9b2ed667181738cabd2eb6170f889f0c9/chrome/browser/android/offline_pages/offline_page_model_factory.cc

Project Member

Comment 4 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8320b11dda9a017c2a7fe98dd0fb4480c5badb41

commit 8320b11dda9a017c2a7fe98dd0fb4480c5badb41
Author: bburns <bburns@chromium.org>
Date: Tue May 24 00:19:20 2016

delete the levelDB storage implementation.

This is a revert of the revert of https://codereview.chromium.org/1999443003/

BUG= 599235 

Review-Url: https://codereview.chromium.org/2001333002
Cr-Commit-Position: refs/heads/master@{#395477}

[modify] https://crrev.com/8320b11dda9a017c2a7fe98dd0fb4480c5badb41/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/8320b11dda9a017c2a7fe98dd0fb4480c5badb41/chrome/browser/android/offline_pages/offline_page_model_factory.cc
[modify] https://crrev.com/8320b11dda9a017c2a7fe98dd0fb4480c5badb41/components/offline_pages.gypi
[modify] https://crrev.com/8320b11dda9a017c2a7fe98dd0fb4480c5badb41/components/offline_pages/BUILD.gn
[modify] https://crrev.com/8320b11dda9a017c2a7fe98dd0fb4480c5badb41/components/offline_pages/DEPS
[modify] https://crrev.com/8320b11dda9a017c2a7fe98dd0fb4480c5badb41/components/offline_pages/offline_page_item.cc
[delete] https://crrev.com/43e876f3dace08f9ff9f5c7d16888117ed3187e6/components/offline_pages/offline_page_metadata_store_impl.cc
[delete] https://crrev.com/43e876f3dace08f9ff9f5c7d16888117ed3187e6/components/offline_pages/offline_page_metadata_store_impl.h
[modify] https://crrev.com/8320b11dda9a017c2a7fe98dd0fb4480c5badb41/components/offline_pages/offline_page_metadata_store_impl_unittest.cc
[modify] https://crrev.com/8320b11dda9a017c2a7fe98dd0fb4480c5badb41/components/offline_pages/offline_page_model.cc
[delete] https://crrev.com/43e876f3dace08f9ff9f5c7d16888117ed3187e6/components/offline_pages/proto/BUILD.gn
[delete] https://crrev.com/43e876f3dace08f9ff9f5c7d16888117ed3187e6/components/offline_pages/proto/offline_pages.proto

Status: Fixed (was: Assigned)

Sign in to add a comment