New issue
Advanced search Search tips

Issue 599213 link

Starred by 1 user
Status: Fixed
Owner:
lazyboy@chromium.org
Closed: Mar 2016
Cc:
rdevlin....@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

ExtensionApiTest.ChromeRuntimeOpenOptionsPage is flaky

Project Member Reported by rdevlin....@chromium.org, Mar 30 2016 
Log: https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/18749/steps/browser_tests%20on%20Mac-10.9/logs/ExtensionApiTest.ChromeRuntimeOpenOptionsPage

Snippet:

[60120:1287:0330/120319:INFO:CONSOLE(0)] "[SUCCESS] testNewOptionsPage", source: chrome-extension://dojmognfallamkpagcecbobidhpkggic/_generated_background_page.html (0)
[60120:1287:0330/120319:INFO:CONSOLE(0)] "[FAIL] testRefocusExistingOptionsPage: API Test Error in testRefocusExistingOptionsPage
Actual: chrome://chrome/
Expected: chrome://extensions/?options=dojmognfallamkpagcecbobidhpkggic
Error
    at Object.<anonymous> (extensions::test:106:11)
    at Object.handleRequest (extensions::binding:57:27)
    at Object.<anonymous> (extensions::binding:385:32)
    at Object.<anonymous> (extensions::test:213:18)
    at Object.handleRequest (extensions::binding:57:27)
    at Object.<anonymous> (extensions::binding:385:32)
    at chrome-extension://dojmognfallamkpagcecbobidhpkggic/test.js:61:11
    at chrome-extension://dojmognfallamkpagcecbobidhpkggic/test.js:42:5
    at safeFunctionApply (extensions::test:258:26)
    at Object.callback (extensions::test:282:18)", source: chrome-extension://dojmognfallamkpagcecbobidhpkggic/_generated_background_page.html (0)
[60120:1287:0330/120319:INFO:CONSOLE(0)] "[FAIL] testRefocusExistingOptionsPage: uncaught exception chrome.test.failure


Istiaque, can you look into this?  I've been able to repro the failure using a release build on my mac.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b18cf98e77b2fb6ff7701b01b8d0c2c9ab6ec4e1

commit b18cf98e77b2fb6ff7701b01b8d0c2c9ab6ec4e1
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Wed Mar 30 21:44:43 2016

[Sheriff] Disable ExtensionApiTest.ChromeRuntimeOpenOptionsPage

TBR=lazyboy@chromium.org
BUG= 599213 
NOTRY=true

Review URL: https://codereview.chromium.org/1839363003

Cr-Commit-Position: refs/heads/master@{#384101}

[modify] https://crrev.com/b18cf98e77b2fb6ff7701b01b8d0c2c9ab6ec4e1/extensions/browser/api/runtime/runtime_apitest.cc
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 31 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fad9cf0f060000c0ac5a65133b3254cf54c6b96e

commit fad9cf0f060000c0ac5a65133b3254cf54c6b96e
Author: lazyboy <lazyboy@chromium.org>
Date: Thu Mar 31 20:35:51 2016

Enable ExtensionApiTest.ChromeRuntimeOpenOptionsPage.

Couple of issues fixed:
  1) Make the test wait for chrome.runtime.openOptionsPage to finish.
  2) The test tab opening 'chrome://chrome' is problematic because, without
    this change, the chrome://chrome tab would be overwritten by
    chrome://extensions (and you'd end up with two chrome://extensions tab!).
    This is because BrowserURLHandlerImpl::RewriteURLIfNecessary() has
    chrome://chrome/extension <-> chrome://chrome association in its handlers
    and singleton_tabs.cc's GetIndexOfSingletonTab() for chrome://extension
    would return the tab with chrome://chrome URL.
    Make the test use 'about:blank' for test URL instead.

BUG= 599213 

Review URL: https://codereview.chromium.org/1850593002

Cr-Commit-Position: refs/heads/master@{#384372}

[modify] https://crrev.com/fad9cf0f060000c0ac5a65133b3254cf54c6b96e/chrome/test/data/extensions/api_test/runtime/open_options_page/test.js
[modify] https://crrev.com/fad9cf0f060000c0ac5a65133b3254cf54c6b96e/extensions/browser/api/runtime/runtime_apitest.cc

Comment 3 by lazyboy@chromium.org, Mar 31 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment