New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599184 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature



Sign in to add a comment

Build a simple "headless" Client+Engine test base for Engine-focused integration tests.

Project Member Reported by w...@chromium.org, Mar 30 2016

Issue description

We can do a lot of testing of Engine functionality with a "headless" Client that is driven by test-cases, to verify protocol & web-rendering properties.

Note that these won't replace true end-to-end tests.
 

Comment 1 by dah...@chromium.org, Mar 31 2016

Labels: -Type-Bug Type-Feature
Status: Available (was: Untriaged)
Cc: w...@chromium.org
wez@, if this is in scope for M52, can we please find an owner?

Comment 3 by w...@chromium.org, Apr 12 2016

Owner: haibinlu@chromium.org
Status: Assigned (was: Available)
Tentatively assigning to haibinlu@ - will discuss w/ him when he is back.
Labels: Blimp-M52-Proj-Scope
Project Member

Comment 5 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c

commit d4f2c05f5d5d332f440d4ba46156a35228f2ed0c
Author: haibinlu <haibinlu@chromium.org>
Date: Fri May 06 01:03:37 2016

[Blimp] Adds blimp engine browser test framework and LoadUrl test.

It uses a headless Client (client_session with all features and mock feature delegates) to work with a full Engine listening on a local tcp port.

It expects certain messages received via these mock delegates when it sends messages to Engine.

other changes:
1. consolidate client's mock feature delegates with existing unit tests.
2. pull common engine command line configs into blimp::engine::SetUpCommandLine.

BUG= 599184 

Review-Url: https://codereview.chromium.org/1929723002
Cr-Commit-Position: refs/heads/master@{#391974}

[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/BUILD.gn
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/BUILD.gn
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/app/android/toolbar.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/app/android/web_input_box.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/app/linux/blimp_client_session_linux.cc
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/feature/ime_feature.cc
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/feature/ime_feature.h
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/feature/mock_ime_feature_delegate.cc
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/feature/mock_ime_feature_delegate.h
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/feature/mock_navigation_feature_delegate.cc
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/feature/mock_navigation_feature_delegate.h
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/feature/mock_render_widget_feature_delegate.cc
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/feature/mock_render_widget_feature_delegate.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/feature/navigation_feature.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/feature/navigation_feature_unittest.cc
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/feature/render_widget_feature.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/feature/render_widget_feature_unittest.cc
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/session/test_client_session.cc
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/client/session/test_client_session.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/BUILD.gn
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/DEPS
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/app/blimp_browser_main_parts.cc
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/app/blimp_browser_main_parts.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/app/blimp_content_browser_client.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/app/blimp_content_main_delegate.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/app/blimp_engine_config.cc
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/app/blimp_engine_config.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/app/blimp_main.cc
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/app/test_content_main_delegate.cc
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/app/test_content_main_delegate.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/session/blimp_engine_session.cc
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/engine/session/blimp_engine_session.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/net/tcp_engine_transport.cc
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/net/tcp_engine_transport.h
[modify] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/net/tcp_transport_unittest.cc
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/test/BUILD.gn
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/test/DEPS
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/test/browser_tests/blimp_browser_test.cc
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/test/browser_tests/blimp_browser_test.h
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/test/browser_tests/blimp_test_launcher.cc
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/test/browser_tests/engine_browsertest.cc
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/test/data/hello.html
[add] https://crrev.com/d4f2c05f5d5d332f440d4ba46156a35228f2ed0c/blimp/test/data/test_client_token

Status: Fixed (was: Assigned)
Labels: Archive-Blimp

Sign in to add a comment