Still able to access deleted WebRTC manual test pages via https://src.chromium.org/svn/trunk/src/chrome/test/data/webrtc/manual/ |
||||||||||||
Issue descriptionhttps://bugs.chromium.org/p/chromium/issues/detail?id=598272#c2, filed a couple days ago, referenced a really old WebRTC manual test page: https://src.chromium.org/svn/trunk/src/chrome/test/data/webrtc/manual/constraints.html However, that page was deleted in 2014 in https://codereview.chromium.org/609733002 Is there a way to break svn links to deleted WebRTC test pages? If chromium really wants to keep the svn archives around, can the archive at least be configured to force users to append an svn revision number? Otherwise, the current behavior kind of gives the impression that those old test pages are still supported/maintained. (And yes, this most likely isn't a WebRTC issue per se, but I'm adding the WebRTC component so that it still shows up in our usual triage search queries.)
,
Mar 30 2016
I'm marking it as Infra-Git since it's a VCS-related issue. cc'ing mmoss in case he knows more.
,
Mar 31 2016
I gather at some point git became the source of truth for this repo, but the svn repo was never deleted: https://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/webrtc/manual/ I think the only fix here is to actually delete the old svn repo.
,
Mar 31 2016
Right, can we please do that? Enough time must have passed to ensure this doesn't break old users of it. You could eventually just drop everything and check in a README file instead. Even better would be if it's possible to just redirect the viewvc-URLs to some landing page explaining that the SVN repo is now replaced by Git. The over-ambitious solution would be to URL-rewrite the old links to map to Gitiles, but AFAIK it's not possible to serve the content directly from Gitiles (one would end up at viewing the actual HTML source in this case, which of course is fine).
,
Mar 31 2016
Renaming to something more generic since this is not specific to WebRTC. I wasn't able to find any old cleanup bug to reference for this.
,
Mar 31 2016
I don't think shutting down any of those things is an option, since svn is still the source of truth for a bunch of chrome-internal repos. And I have no idea about redirects. That might be an infra-labs thing, something done at the networking level.
,
Mar 31 2016
Ah, I forgot all the repos are using the same Subversion server (reverting topic change). So, is it possible for us to perform a Subversion commit that removes everything below https://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/webrtc/ ? I'm suspecting that repo is read-only? In that case I guess we need to get assistance from Infra-Labs setting up some networking redirect based on the URL.
,
Mar 31 2016
Oh, yeah, it probably is read-only. I've never really dealt with the svn servers, so I don't know how to work around that. Maybe vadimsh? (removing infra-git, since this is nothing to do with git repos at this point, and vcs issues don't generalize to infra-git issues)
,
Apr 1 2016
Sounds like this is now in labs' hands. See comment #7.
,
Apr 5 2016
Labs: any comment on if this is doable?
,
Apr 5 2016
No, we can't serve redirects from src.chromium.org (nor would we want to, it would get messy fast).
,
Apr 12 2016
So in other words there is no way to get around this problem of us having old stuff show up in Google searches like https://www.google.se/search?sourceid=chrome-psyapi2&ion=1&espv=2&ie=UTF-8&q=webrtc%20manual%20constraints.html&oq=webrtc%20manual%20constraints.html&aqs=chrome..69i57j69i64.3600j0j7 Maybe src.chromium.org could at least put a robots.txt in the root?
,
Apr 27 2016
,
Jul 14 2016
+dba to help answer question on comment #7
,
Jul 14 2016
This will be "fixed" once https://bugs.chromium.org/p/chromium/issues/detail?id=600451 is completed (which should be soon)
,
Jul 18 2016
,
Jul 18 2016
I believe this is because we left it as RO for now.
,
Jul 18 2016
Oh, somehow I was never CC'd on this before. Yeah, we can trivially remove the read-only restriction, land a sentinel commit saying "go look for these files in Git", and then re-add the read-only restriction. https://src.chromium.org/svn/trunk/src/chrome/test/data/webrtc/manual/ |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by cbiesin...@chromium.org
, Mar 30 2016