All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=599174

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg8Kv8swkM


Bot(s) for this bug's original alert(s):

chromium-rel-win8-dual

Probably black allocation.

 Issue 599477  has been merged into this issue.

 Issue 600651  has been merged into this issue.

 Issue 586168  has been merged into this issue.

Black allocation should reduce memory usage. In some cases this is currently not the case.
2 fixes in flight:
1) Don't use black pages for map and code space. Just mark objects directly, which avoids fragmentation introduced by black pages.
2) Address TODO of sweeping remaining memory of black pages.

Issue 600269 has been merged into this issue.

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d0151bfb137fac378a93703f86f2ac0c4f68cf3a

commit d0151bfb137fac378a93703f86f2ac0c4f68cf3a
Author: hpayer <hpayer@chromium.org>
Date: Wed Apr 06 21:51:38 2016

[heap] Don't use black pages for map, code and, lo space. Instead color objects black.

This reduced fragmentation in spaces where black pages are not a requirement. The only spaces where we need black pages is old space, because of allocation folding and fast inline allocation in generated code.

BUG= chromium:599174 
LOG=n

Review URL: https://codereview.chromium.org/1862063002

Cr-Commit-Position: refs/heads/master@{#35315}

[modify] https://crrev.com/d0151bfb137fac378a93703f86f2ac0c4f68cf3a/src/heap/heap-inl.h
[modify] https://crrev.com/d0151bfb137fac378a93703f86f2ac0c4f68cf3a/src/heap/heap.cc
[modify] https://crrev.com/d0151bfb137fac378a93703f86f2ac0c4f68cf3a/src/heap/incremental-marking.cc
[modify] https://crrev.com/d0151bfb137fac378a93703f86f2ac0c4f68cf3a/src/heap/spaces.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/a81c47f35886d88d646d0cf0f4892271a9288389

commit a81c47f35886d88d646d0cf0f4892271a9288389
Author: hpayer <hpayer@chromium.org>
Date: Mon Apr 11 09:21:27 2016

[heap] Do not perform black allocation in memory reducing mode.

Black allocation discards all old-space free-lists, which may be quite full when we perform memory reducing GCs.

BUG= chromium:599174 
LOG=n

Review URL: https://codereview.chromium.org/1869493002

Cr-Commit-Position: refs/heads/master@{#35374}

[modify] https://crrev.com/a81c47f35886d88d646d0cf0f4892271a9288389/src/heap/incremental-marking.cc

should (can) we cherry pick #9 in M51?

Yeah, no problem. Is #9 good enough for you?

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/413ea9261716511cf09489fcbbec61c9fb65f9a8

commit 413ea9261716511cf09489fcbbec61c9fb65f9a8
Author: hpayer <hpayer@chromium.org>
Date: Thu Apr 14 17:35:58 2016

[heap] Turn on black allocation during marking finalization to avoid floating garbage.

We will move this back to start of incremental marking when we make faster progress.

Perf sheriffs: This CL may cause a regression on benchmarks that improved earlier by enabling black allocation.

BUG= chromium:599174 
LOG=n

Review URL: https://codereview.chromium.org/1889853002

Cr-Commit-Position: refs/heads/master@{#35500}

[modify] https://crrev.com/413ea9261716511cf09489fcbbec61c9fb65f9a8/src/heap/incremental-marking.cc

To play safe for now, we should merge back #12.

Hmm it looks like the benchmark never actually went down after the change. It actually went up.
#8 rolled in chrome in #386020 (but was reverted soon after due to flaky GPU tests).

https://chromeperf.appspot.com/report?sid=d83d05c9665592cdf04f883113d11939f9cf37386bac7bc977eb64f3f1f57a8a&start_rev=385831&end_rev=387557

Your change meets the bar and is auto-approved for M51 (branch: 2704)

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7f8e66e8690674d8b6511b3427c3ccfa8a2949a3

commit 7f8e66e8690674d8b6511b3427c3ccfa8a2949a3
Author: Hannes Payer <hpayer@chromium.org>
Date: Wed Apr 20 15:03:34 2016

Version 5.1.281.9 (cherry-pick)

Merged d0151bfb137fac378a93703f86f2ac0c4f68cf3a

[heap] Don't use black pages for map, code and, lo space. Instead color objects black.

BUG= chromium:599174 
LOG=N
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/1899193005 .

Cr-Commit-Position: refs/branch-heads/5.1@{#12}
Cr-Branched-From: 167dc63b4c9a1d0f0fe1b19af93644ac9a561e83-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f52bd4a184983a551927c406be6489ef89b-refs/heads/master@{#35282}

[modify] https://crrev.com/7f8e66e8690674d8b6511b3427c3ccfa8a2949a3/include/v8-version.h
[modify] https://crrev.com/7f8e66e8690674d8b6511b3427c3ccfa8a2949a3/src/heap/heap-inl.h
[modify] https://crrev.com/7f8e66e8690674d8b6511b3427c3ccfa8a2949a3/src/heap/heap.cc
[modify] https://crrev.com/7f8e66e8690674d8b6511b3427c3ccfa8a2949a3/src/heap/incremental-marking.cc
[modify] https://crrev.com/7f8e66e8690674d8b6511b3427c3ccfa8a2949a3/src/heap/spaces.cc

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

hpayer@ : Could you please take a look into this and update further if its fixed.

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5be0f7d939e664c054c9a11b2eb4ed106e3e13ad

commit 5be0f7d939e664c054c9a11b2eb4ed106e3e13ad
Author: Hannes Payer <hpayer@chromium.org>
Date: Mon May 30 09:25:42 2016

Version 5.1.281.54 (cherry-pick)

Merged a81c47f35886d88d646d0cf0f4892271a9288389

[heap] Do not perform black allocation in memory reducing mode.

BUG= chromium:599174 
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/2024613002 .

Cr-Commit-Position: refs/branch-heads/5.1@{#65}
Cr-Branched-From: 167dc63b4c9a1d0f0fe1b19af93644ac9a561e83-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f52bd4a184983a551927c406be6489ef89b-refs/heads/master@{#35282}

[modify] https://crrev.com/5be0f7d939e664c054c9a11b2eb4ed106e3e13ad/include/v8-version.h
[modify] https://crrev.com/5be0f7d939e664c054c9a11b2eb4ed106e3e13ad/src/heap/incremental-marking.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0f2e83554925da270cf42d900a695d91aa699e9c

commit 0f2e83554925da270cf42d900a695d91aa699e9c
Author: Hannes Payer <hpayer@chromium.org>
Date: Mon May 30 09:31:16 2016

Version 5.1.281.55 (cherry-pick)

Merged 413ea9261716511cf09489fcbbec61c9fb65f9a8

[heap] Turn on black allocation during marking finalization to avoid floating garbage.

BUG= chromium:599174 
LOG=N
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/2020003002 .

Cr-Commit-Position: refs/branch-heads/5.1@{#66}
Cr-Branched-From: 167dc63b4c9a1d0f0fe1b19af93644ac9a561e83-refs/heads/5.1.281@{#1}
Cr-Branched-From: 03953f52bd4a184983a551927c406be6489ef89b-refs/heads/master@{#35282}

[modify] https://crrev.com/0f2e83554925da270cf42d900a695d91aa699e9c/include/v8-version.h
[modify] https://crrev.com/0f2e83554925da270cf42d900a695d91aa699e9c/src/heap/incremental-marking.cc

Most of the graphs I'm seeing look recovered. Primiano, what caused you to make the comment in #14?

If this does seem recovered, is there anything else we need to do here?

No idea, the graphs I linked seem to have gone. Given the situation ignore my comment.

Graphs recovered, marking WontFix. (Based on comments, the dashboard is just giving me an http 500 error for this set of graphs)