Issue metadata
Sign in to add a comment
|
Fix flaky test in monitoring for go |
||||||||||||||||||||||
Issue descriptionExample: https://build.chromium.org/p/chromium.infra/builders/infra-continuous-mac-10.9-64/builds/1753/steps/infra%20go%20tests/logs/stdio -------------------------------------------------------------------------------- PACKAGE: infra/monitoring/proxy -------------------------------------------------------------------------------- ..... 5 total assertions ......................................................... 62 total assertions ....................... 85 total assertions ....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... 939 total assertions ........................................................................................................................................................................................x Failures: * /b/build/slave/infra-continuous/build/infra/go/src/infra/monitoring/proxy/main_test.go Line 87: Error during mock: No registered mock matching send(context.Background.WithValue(0, (func() retry.Iterator)(0x9a200)).WithCancel.WithValue(1, logging.Fields{"worker":8}).WithValue(1, logging.Fields{"messageID":"msg-3", "worker":8, "size":1}), [3]). Error during mock: Result count (0) differs from bound args (1). Unused mock was registered: send(&{}, [3]) 1125 total assertions --- FAIL: TestMain (0.04s) FAIL coverage: 57.5% of statements FAIL infra/monitoring/proxy 0.073s -------------------------------------------------------------------------------- step returned non-zero exit code: 1
,
Mar 31 2016
,
Apr 13 2016
I receive 1 email daily from our CI about the flakes. I don't think this flake should be ignored any more: https://build.chromium.org/p/chromium.infra/builders/infra-continuous-trusty-64/builds/1952/steps/infra%20go%20tests/logs/stdio
,
Apr 13 2016
sergeyberezin@ has wanted to update this script to use newer LUCI code for a while now. Most of the testing and complications will be deleted when this happens.
,
Apr 13 2016
Also: Getting annoying e-mails doesn't make things P1.
,
Apr 13 2016
Sure, but having builds failing randomly and thus preventing building cipd packages (and hence causing pain down the road) does.
,
Apr 13 2016
There is no intention of healing this component, since it is destined to be replaced by a better one in "luci-go". Therefore, let's kill it. Change the test from Convey to SkipConvey.
,
Apr 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/3a43e54a34e956bdd06deac0d07ae266cf3ccd8c commit 3a43e54a34e956bdd06deac0d07ae266cf3ccd8c Author: sergeyberezin <sergeyberezin@chromium.org> Date: Thu Apr 14 17:47:30 2016 Skip the flaky monitorig proxy test. BUG= 599171 R=pgervais@chromium.org, dnj@chromium.org Review URL: https://codereview.chromium.org/1886933002 [modify] https://crrev.com/3a43e54a34e956bdd06deac0d07ae266cf3ccd8c/go/src/infra/monitoring/proxy/main_test.go [modify] https://crrev.com/3a43e54a34e956bdd06deac0d07ae266cf3ccd8c/go/src/infra/monitoring/proxy/proxy.infra_testing
,
Apr 14 2016
The most annoying test is now disabled. There is still one flaky test remaining, but hopefully it's tolerable until we rewrite the proxy: -------------------------------------------------------------------------------- PACKAGE: infra/monitoring/looper -------------------------------------------------------------------------------- --- FAIL: TestLoopOverrunSome (0.00s) looper_test.go:114: Want 5 Overruns got 6
,
Apr 14 2016
That failure is not part of the proxy, and will not be affected by the monitoring proxy rewrite.
,
Apr 18 2016
More reports about flaky tests in infra/monitoring/looper: https://groups.google.com/a/google.com/forum/#!topic/chrome-infrastructure-team/xiI0Ny0bZuE
,
Apr 18 2016
Yeah, it's the second most frequent one. I'll fix it.
,
Apr 18 2016
Re #5: > Also: Getting annoying e-mails doesn't make things P1. Yep. Sorry, I should have been clear: I receive email on every tree closing build failure as self-appointed-gardener, and i'd say 20% of time the person on the blamelist replies saying "nope, no my CL". So, it's annoying not to me, but to others who waste their time looking into these failurse.
,
Apr 19 2016
,
Apr 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra.git/+/cd857b9571bf1ad306f3513b8259915869b3db8d commit cd857b9571bf1ad306f3513b8259915869b3db8d Author: sergeyberezin <sergeyberezin@chromium.org> Date: Tue Apr 19 21:25:38 2016 Fixed flaky go tests in looper R=dnj@chromium.org, seanmccullough@chromium.org BUG= 599171 Review URL: https://codereview.chromium.org/1896213002 [modify] https://crrev.com/cd857b9571bf1ad306f3513b8259915869b3db8d/go/src/infra/monitoring/looper/looper_test.go
,
Apr 19 2016
This should now be fixed (again). Hopefully this time for good.
,
Apr 27 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by pgervais@chromium.org
, Mar 30 2016Status: Assigned (was: Untriaged)