New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 599163 link

Starred by 2 users
Status: Fixed
Owner:
█ rtenneti@chromium.org
Last visit > 30 days ago
Closed: Apr 2016
Cc:
rch@chromium.org
█ ianswett@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

When 0RTT fails with outstanding requests, we wait to declare them lost to send them again

Project Member Reported by rtenneti@chromium.org, Mar 30 2016 
From Inaswett: internal bug 27894838

Based on my reading of this net-internals for a connection to a googlevideo host(type:QUIC_SESSION 16150617265330971652), it appears we wait for the 0RTT requests to be nacked before retransmitting them.  This typically occurs after the SHLO is received, which is an extra RTT after they could be retransmitted.

In this case, it takes a full 2 RTTs until we can send data, which is not significantly faster than SSL.

Now that 0RTT is disabled on bandaid temporarily, this is very easy to reproduce.
Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edd3962e6c1e8f3b3db8ee2dd399b9f0150e58e4

commit edd3962e6c1e8f3b3db8ee2dd399b9f0150e58e4
Author: rtenneti <rtenneti@chromium.org>
Date: Wed Mar 30 21:49:40 2016

relnote: Retransmit initially encrypted packets when a reject is
received with enough information to re-establish encryption. Protected
by FLAGS_quic_reply_to_rej.

Merge internal change: 118574673

R=jri@chromium.org, rch@chromium.org
BUG= 599163 

Review URL: https://codereview.chromium.org/1842133002

Cr-Commit-Position: refs/heads/master@{#384103}

[modify] https://crrev.com/edd3962e6c1e8f3b3db8ee2dd399b9f0150e58e4/net/quic/quic_crypto_client_stream.cc
[modify] https://crrev.com/edd3962e6c1e8f3b3db8ee2dd399b9f0150e58e4/net/quic/quic_flags.cc
[modify] https://crrev.com/edd3962e6c1e8f3b3db8ee2dd399b9f0150e58e4/net/quic/quic_flags.h
[modify] https://crrev.com/edd3962e6c1e8f3b3db8ee2dd399b9f0150e58e4/net/tools/quic/end_to_end_test.cc

Comment 2 by mef@chromium.org, Mar 30 2016

Components: Internals>Network>Library

Comment 3 by rtenneti@chromium.org, Mar 30 2016

Labels: -Pri-3 Merge-Request-50 M-50 Pri-1
This CL is from internal code. Would like to merge this for next week's M50 release. Will merge tomorrow after patch in Comment 1 goes live in Canary.

Comment 4 by tin...@google.com, Mar 31 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)

Comment 5 by rch@chromium.org, Apr 4 2016

Cc: rch@chromium.org
Raman: Looks like this has m50 merge approval. Is it ready to land?

Comment 6 by rtenneti@chromium.org, Apr 4 2016 

In the process of landing it (sorry for the delay).

Comment 7 by rch@chromium.org, Apr 4 2016 

Thanks, Raman!
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 4 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be27310f391c56a8d01bcc560a964074fd00500c

commit be27310f391c56a8d01bcc560a964074fd00500c
Author: Raman Tenneti <rtenneti@google.com>
Date: Mon Apr 04 16:47:51 2016

relnote: Retransmit initially encrypted packets when a reject is
received with enough information to re-establish encryption.

Protected by FLAGS_quic_reply_to_rej.

Merge internal change: 118574673

R=jri@chromium.org, rch@chromium.org
BUG= 599163 

Review URL: https://codereview.chromium.org/1842133002

Cr-Commit-Position: refs/heads/master@{#384103}
(cherry picked from commit edd3962e6c1e8f3b3db8ee2dd399b9f0150e58e4)

Review URL: https://codereview.chromium.org/1852313002 .

Cr-Commit-Position: refs/branch-heads/2661@{#473}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/be27310f391c56a8d01bcc560a964074fd00500c/net/quic/quic_crypto_client_stream.cc
[modify] https://crrev.com/be27310f391c56a8d01bcc560a964074fd00500c/net/quic/quic_flags.cc
[modify] https://crrev.com/be27310f391c56a8d01bcc560a964074fd00500c/net/quic/quic_flags.h
[modify] https://crrev.com/be27310f391c56a8d01bcc560a964074fd00500c/net/tools/quic/end_to_end_test.cc

Comment 9 by rtenneti@chromium.org, Apr 4 2016

Status: Fixed (was: Started)
►

Sign in to add a comment