New issue
Advanced search Search tips

Issue 599153 link

Starred by 2 users
Status: Fixed
Owner:
dtapu...@chromium.org
Closed: Apr 2016
Cc:
jochen@chromium.org
dtapu...@chromium.org
haraken@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Automatic historyBack on Mac is triggered when it should scroll instead

Project Member Reported by hablich@chromium.org, Mar 30 2016 
Version: Version 51.0.2694.1 canary (64-bit)
OS: Mac
Hardware: MacBook Pro

Cannot reproduce this on Version 49.0.2623.87 (64-bit) stable.

What steps will reproduce the problem?
(1) open www.google.com
(2) open https://kangax.github.io/compat-table/es6/ in the same tab
(3) Wait until page is loaded
(4) Scroll with mousepad to the right
(5) Remove your fingers from the mousepad
(6) Fingers on mousepad again and scroll to the left
(7) historyBack is triggered instead of scrolling to the left and www.google.com is loaded again

What is the expected output?
Should scroll to the left

What do you see instead?
Previous page is loaded

Comment 1 by hablich@chromium.org, Mar 30 2016 

See screencast for repro.
historyBack.mov
12.2 MB Download

Comment 2 by dtapu...@chromium.org, Mar 30 2016

Cc: dtapu...@chromium.org
This could be me with wheel gestures; does it function fine with --disable-wheel-gestures ?

Comment 3 by kavvaru@chromium.org, Mar 31 2016

Labels: -Type-Bug -Needs-Bisect M-51 hasbisect Type-Bug-Regression
Owner: dtapu...@chromium.org
Status: Assigned (was: Untriaged)
Able to reproduce the issue on Mac 10.11.3 using chrome version 51.0.2694.1.
This is regression issue broken in M51. Please find the bisect information as below

Narrow Bisect:
Good:: 51.0.2686.0 
Bad:: 51.0.2687.0

CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/6bebadddb399ad1c1f91592efed410040617e708..5840ac85a7c912d9ddb764007b6a9ec65a26ad22

Possible suspect : https://chromium.googlesource.com/chromium/src/+/ca4feba9a31e10d1baab5813650c192e06cfd643

Comment 4 by hablich@chromium.org, Mar 31 2016 

With --disable-wheel-gestures the problem goes away.

Comment 5 by dtapu...@chromium.org, Mar 31 2016

Components: -Blink Blink>Input
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b2c5c9d8120abd6dd8605ab430ad557857f75bda

commit b2c5c9d8120abd6dd8605ab430ad557857f75bda
Author: dtapuska <dtapuska@chromium.org>
Date: Sat Apr 02 01:22:52 2016

Fix page navigation being incorrectly fired on Mac OSX.

With wheel gestures being enabled the wheel event goes
unhandled most of the time. There was specific code for Mac
to handle the not handled mouse wheel event that would
fire. Instead base it off gestures when we are using this
setting.

Update unit test to ensure this fires for gestures
correctly.

BUG= 599153 
TBR=thestig@chromium.org

Review URL: https://codereview.chromium.org/1848063002

Cr-Commit-Position: refs/heads/master@{#384770}

[modify] https://crrev.com/b2c5c9d8120abd6dd8605ab430ad557857f75bda/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_delegate.mm
[modify] https://crrev.com/b2c5c9d8120abd6dd8605ab430ad557857f75bda/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.h
[modify] https://crrev.com/b2c5c9d8120abd6dd8605ab430ad557857f75bda/chrome/browser/renderer_host/chrome_render_widget_host_view_mac_history_swiper.mm
[modify] https://crrev.com/b2c5c9d8120abd6dd8605ab430ad557857f75bda/content/browser/renderer_host/render_widget_host_view_mac.h
[modify] https://crrev.com/b2c5c9d8120abd6dd8605ab430ad557857f75bda/content/browser/renderer_host/render_widget_host_view_mac.mm
[modify] https://crrev.com/b2c5c9d8120abd6dd8605ab430ad557857f75bda/content/browser/renderer_host/render_widget_host_view_mac_unittest.mm
[modify] https://crrev.com/b2c5c9d8120abd6dd8605ab430ad557857f75bda/content/public/browser/render_widget_host_view_mac_delegate.h

Comment 8 by dtapu...@chromium.org, Apr 4 2016

Status: Fixed (was: Assigned)

Comment 9 by dtapu...@chromium.org, Jun 21 2016

Labels: Hotlist-Input-Dev
►

Sign in to add a comment