Issue 599131 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	se...@chromium.org
Closed:	Mar 2016
Components:	UI>Browser>Autofill
EstimatedDays:	----
NextAction:	----
OS:	All
Pri:	2
Type:	Bug

Autofill should fill fields where the value is the same as the placeholder attribute.

Project Member Reported by se...@chromium.org, Mar 30 2016

Issue description

On some sites there are fields where the placeholder value is set as the value of the field by the javascript.

Autofill should detect that this value is the default value and fill these fields.

An example of a site would be Ticketfly.com.

Project Member

Comment 1 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bc61f8f605564730b06f14e243681e930c7cb88

commit 5bc61f8f605564730b06f14e243681e930c7cb88
Author: sebsg <sebsg@chromium.org>
Date: Wed Mar 30 19:28:28 2016

If the value of the field is the same as the placeholder attribute value, it is safe to overwrite this field with autofill values.

BUG= 599131 
TEST=FormAutofillBrowserTest, AutofillManagerTest

Review URL: https://codereview.chromium.org/1842693003

Cr-Commit-Position: refs/heads/master@{#384053}

[modify] https://crrev.com/5bc61f8f605564730b06f14e243681e930c7cb88/chrome/renderer/autofill/form_autofill_browsertest.cc
[modify] https://crrev.com/5bc61f8f605564730b06f14e243681e930c7cb88/components/autofill/content/common/autofill_messages.h
[modify] https://crrev.com/5bc61f8f605564730b06f14e243681e930c7cb88/components/autofill/content/renderer/form_autofill_util.cc
[modify] https://crrev.com/5bc61f8f605564730b06f14e243681e930c7cb88/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/5bc61f8f605564730b06f14e243681e930c7cb88/components/autofill/core/common/form_field_data.cc
[modify] https://crrev.com/5bc61f8f605564730b06f14e243681e930c7cb88/components/autofill/core/common/form_field_data.h
[modify] https://crrev.com/5bc61f8f605564730b06f14e243681e930c7cb88/components/autofill/core/common/form_field_data_unittest.cc

Comment 2 by se...@chromium.org, Mar 30 2016

Status: Fixed (was: Started)

►

Issue 599131 link

Issue metadata

Autofill should fill fields where the value is the same as the placeholder attribute.

Issue description

Comment 1 by bugdroid1@chromium.org, Mar 30 2016

Comment 1 Deleted

Comment 2 by se...@chromium.org, Mar 30 2016

Comment 2 Deleted

Sign in to add a comment