USB Vendor IDs incorrectly parsed on Windows
Reported by
ger...@tidepool.org,
Mar 30 2016
|
||||||||
Issue description
UserAgent: Mozilla/5.0 (Windows NT 6.3; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2693.2 Safari/537.36
Steps to reproduce the problem:
Use chrome.serial.getDevices() to retrieve USB vendor ID and product ID on Windows
What is the expected behavior?
1. Device with Hardware IDs "USB\VID_22A3&PID_0047&REV_0100" and "USB\VID_22A3&PID_0047" should return {productId: 71, vendorId: 8867}
2. Device with Hardware IDs "USB\VID_1A61&PID_3410&REV_0101" and "USB\VID_1A61&PID_3410" should return {productId: 13328, vendorId: 6753}
What went wrong?
- For (1), {productId: 71, vendorId: 34} is returned.
- For (2), {productId: 13328, vendorId: 1} is returned.
WebStore page:
Did this work before? Yes Chrome 44 (and it still works on OS X)
Chrome version: 51.0.2693.2 Channel: dev
OS Version: 6.3
Flash Version: Shockwave Flash 21.0 r0
It was suggested in issue #522217 that this be reported as a new bug. Another related bug report is #529307.
,
Mar 31 2016
,
Mar 31 2016
Please try to merge this into M-50 as the patch is trivial and it's a serious regression for apps depending on this information.
,
Mar 31 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/66ecade99de4820622281ce4a17e511a4b6aa404 commit 66ecade99de4820622281ce4a17e511a4b6aa404 Author: juncai <juncai@chromium.org> Date: Thu Mar 31 22:14:54 2016 Fix serial device PID and VID parsing Serial device's PID and VID contain hex digits, this patch fixed the code which parses it by adding "a-fA-F" to the regular expression. BUG= 599101 Review URL: https://codereview.chromium.org/1848963002 Cr-Commit-Position: refs/heads/master@{#384414} [modify] https://crrev.com/66ecade99de4820622281ce4a17e511a4b6aa404/device/serial/serial_device_enumerator_win.cc
,
Mar 31 2016
,
Mar 31 2016
Keep the milestone label.
,
Apr 1 2016
_Thank you_ for fixing this!
,
Apr 1 2016
Your change meets the bar and is auto-approved for M50 (branch: 2661)
,
Apr 1 2016
Please merge your change to M50 branch 2661 by 5:00 PM on Monday, 04/04/16 so we can take it for next week beta. Thank you.
,
Apr 1 2016
Hi, I used the following command line to merge this patch to M50 branch: git drover --branch 2661 --cherry-pick 66ecade99de4820622281ce4a17e511a4b6aa404 It asked: Username for 'https://chromium.googlesource.com': I typed: juncai Then it asked: Password for 'https://juncai@chromium.googlesource.com': I tried both chromium and google accounts, but not working, any suggestion? Thanks!
,
Apr 1 2016
Use https://chromium.googlesource.com/new-password to generate Git credentials.
,
Apr 1 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad10ef75e16235786db5f9d5346523870a6b8777 commit ad10ef75e16235786db5f9d5346523870a6b8777 Author: Jun Cai <juncai@chromium.org> Date: Fri Apr 01 22:58:57 2016 Fix serial device PID and VID parsing Serial device's PID and VID contain hex digits, this patch fixed the code which parses it by adding "a-fA-F" to the regular expression. BUG= 599101 Review URL: https://codereview.chromium.org/1848963002 Cr-Commit-Position: refs/heads/master@{#384414} (cherry picked from commit 66ecade99de4820622281ce4a17e511a4b6aa404) Review URL: https://codereview.chromium.org/1851673006 . Cr-Commit-Position: refs/branch-heads/2661@{#464} Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081} [modify] https://crrev.com/ad10ef75e16235786db5f9d5346523870a6b8777/device/serial/serial_device_enumerator_win.cc
,
Apr 15 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by reillyg@chromium.org
, Mar 30 2016Components: -Platform>Apps Platform>Apps>API
Status: Available (was: Unconfirmed)