New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599060 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Compat



Sign in to add a comment

[67373:1295:0330/131614:FATAL:permission_manager.cc(94)] Check failed: false. Unknown content setting for permission 6

Reported by alshaba...@yandex-team.ru, Mar 30 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_3) AppleWebKit/601.4.4 (KHTML, like Gecko) Version/9.0.3 Safari/601.4.4

Example URL:
http://googlechrome.github.io/samples/permissions/

Steps to reproduce the problem:
1. Navigate to http://googlechrome.github.io/samples/permissions/
2. Click on any request
3. Click Allow in the bubble

What is the expected behavior?

What went wrong?
NOTREACHED() is reached in permission_manager.cc(94).

Snippet of debug output:

[69942:1295:0330/132450:FATAL:permission_manager.cc(94)] Check failed: false. Unknown content setting for permission 6
0   libbase.dylib                       0x0000000111b35dbf _ZN4base5debug10StackTraceC2Ev + 47
1   libbase.dylib                       0x0000000111b35f63 _ZN4base5debug10StackTraceC1Ev + 35
2   libbase.dylib                       0x0000000111bc2700 _ZN7logging10LogMessageD2Ev + 80
3   libbase.dylib                       0x0000000111bc0033 _ZN7logging10LogMessageD1Ev + 35
4   libchrome_main_dll.dylib            0x0000000102fe7878 _ZN12_GLOBAL__N_130PermissionTypeToContentSettingEN7content14PermissionTypeE + 504
5   libchrome_main_dll.dylib            0x0000000102fe8b6f _ZN17PermissionManager23OnContentSettingChangedERK22ContentSettingsPatternS2_19ContentSettingsTypeNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEE + 479
6   libchrome_main_dll.dylib            0x0000000102fe9e30 _ZThn16_N17PermissionManager23OnContentSettingChangedERK22ContentSettingsPatternS2_19ContentSettingsTypeNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEE + 64
7   libchrome_main_dll.dylib            0x0000000106a4c86b _ZN22HostContentSettingsMap23OnContentSettingChangedERK22ContentSettingsPatternS2_19ContentSettingsTypeNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEE + 235
8   libchrome_main_dll.dylib            0x0000000106a14467 _ZN16content_settings18ObservableProvider15NotifyObserversERK22ContentSettingsPatternS3_19ContentSettingsTypeRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEE + 231
9   libchrome_main_dll.dylib            0x0000000106a2c394 _ZN16content_settings12PrefProvider6NotifyERK22ContentSettingsPatternS3_19ContentSettingsTypeRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEE + 68
10  libchrome_main_dll.dylib            0x0000000106a2eda9 _ZN4base8internal15RunnableAdapterIMN16content_settings12PrefProviderEFvRK22ContentSettingsPatternS6_19ContentSettingsTypeRKNSt3__112basic_stringIcNS8_11char_traitsIcEENS8_9allocatorIcEEEEEE3RunIJS6_S6_S7_SG_EEEvPS3_DpOT_ + 185
11  libchrome_main_dll.dylib            0x0000000106a2ec81 _ZN4base8internal12InvokeHelperILb0EvNS0_15RunnableAdapterIMN16content_settings12PrefProviderEFvRK22ContentSettingsPatternS7_19ContentSettingsTypeRKNSt3__112basic_stringIcNS9_11char_traitsIcEENS9_9allocatorIcEEEEEEEE8MakeItSoIJPS4_S7_S7_S8_SH_EEEvSK_DpOT_ + 129
12  libchrome_main_dll.dylib            0x0000000106a2ebd3 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0EEEENS0_9BindStateINS0_15RunnableAdapterIMN16content_settings12PrefProviderEFvRK22ContentSettingsPatternSA_19ContentSettingsTypeRKNSt3__112basic_stringIcNSC_11char_traitsIcEENSC_9allocatorIcEEEEEEEFvPS7_SA_SA_SB_SK_EJNS0_17UnretainedWrapperIS7_EEEEENS0_12InvokeHelperILb0EvSN_EEFvSA_SA_SB_SK_EE3RunEPNS0_13BindStateBaseESA_SA_OSB_SK_ + 195
13  libchrome_main_dll.dylib            0x0000000106a281d6 _ZNK4base8CallbackIFvRK22ContentSettingsPatternS3_19ContentSettingsTypeRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEEELNS_8internal8CopyModeE1EE3RunES3_S3_S4_SD_ + 134
14  libchrome_main_dll.dylib            0x0000000106a2757f _ZN16content_settings19ContentSettingsPref17SetWebsiteSettingERK22ContentSettingsPatternS3_RKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEEPN4base5ValueE + 2015
15  libchrome_main_dll.dylib            0x0000000106a2d2da _ZN16content_settings12PrefProvider17SetWebsiteSettingERK22ContentSettingsPatternS3_19ContentSettingsTypeRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEEPN4base5ValueE + 1002
16  libchrome_main_dll.dylib            0x0000000106a4893d _ZN22HostContentSettingsMap28SetWebsiteSettingCustomScopeERK22ContentSettingsPatternS2_19ContentSettingsTypeRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEENS4_10unique_ptrIN4base5ValueENS4_14default_deleteISF_EEEE + 1373
17  libchrome_main_dll.dylib            0x0000000106a4aa98 _ZN22HostContentSettingsMap17SetContentSettingERK22ContentSettingsPatternS2_19ContentSettingsTypeRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEE14ContentSetting + 1448
18  libchrome_main_dll.dylib            0x0000000106a4af2f _ZN22HostContentSettingsMap29SetContentSettingDefaultScopeERK4GURLS2_19ContentSettingsTypeRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEE14ContentSetting + 495
19  libchrome_main_dll.dylib            0x00000001038bc840 _ZN30DesktopNotificationProfileUtil15GrantPermissionEP7ProfileRK4GURL + 352
20  libchrome_main_dll.dylib            0x00000001038bf571 _ZN29NotificationPermissionContext20UpdateContentSettingERK4GURLS2_14ContentSetting + 305
21  libchrome_main_dll.dylib            0x0000000102fdd393 _ZN21PermissionContextBase19NotifyPermissionSetERK19PermissionRequestIDRK4GURLS5_RKN4base8CallbackIFv14ContentSettingELNS6_8internal8CopyModeE1EEEbS8_ + 451
22  libchrome_main_dll.dylib            0x0000000102fdb44f _ZN21PermissionContextBase17PermissionDecidedERK19PermissionRequestIDRK4GURLS5_RKN4base8CallbackIFv14ContentSettingELNS6_8internal8CopyModeE1EEEbS8_ + 655
23  libchrome_main_dll.dylib            0x0000000102fe04b6 _ZN4base8internal15RunnableAdapterIM21PermissionContextBaseFvRK19PermissionRequestIDRK4GURLS8_RKNS_8CallbackIFv14ContentSettingELNS0_8CopyModeE1EEEbSA_EE3RunIJS5_S8_S8_SF_bSA_EEEvPS2_DpOT_ + 262
24  libchrome_main_dll.dylib            0x0000000102fe027b _ZN4base8internal12InvokeHelperILb1EvNS0_15RunnableAdapterIM21PermissionContextBaseFvRK19PermissionRequestIDRK4GURLS9_RKNS_8CallbackIFv14ContentSettingELNS0_8CopyModeE1EEEbSB_EEEE8MakeItSoINS_7WeakPtrIS3_EEJS6_S9_S9_SG_bSB_EEEvSJ_T_DpOT0_ + 219
25  libchrome_main_dll.dylib            0x0000000102fe0174 _ZN4base8internal7InvokerINS_13IndexSequenceIJLm0ELm1ELm2ELm3ELm4EEEENS0_9BindStateINS0_15RunnableAdapterIM21PermissionContextBaseFvRK19PermissionRequestIDRK4GURLSC_RKNS_8CallbackIFv14ContentSettingELNS0_8CopyModeE1EEEbSE_EEEFvPS6_S9_SC_SC_SJ_bSE_EJNS_7WeakPtrIS6_EES9_SC_SC_SJ_EEENS0_12InvokeHelperILb1EvSM_EEFvbSE_EE3RunEPNS0_13BindStateBaseEObOSE_ + 420
26  libchrome_main_dll.dylib            0x0000000103c047b2 _ZNK4base8CallbackIFvb14ContentSettingELNS_8internal8CopyModeE1EE3RunEbS1_ + 98
27  libchrome_main_dll.dylib            0x0000000103c046e5 _ZN27PermissionBubbleRequestImpl17PermissionGrantedEv + 69
28  libchrome_main_dll.dylib            0x00000001061dbd2f _ZN23PermissionBubbleManager36PermissionGrantedIncludingDuplicatesEP23PermissionBubbleRequest + 255
29  libchrome_main_dll.dylib            0x00000001061dbacb _ZN23PermissionBubbleManager6AcceptEv + 1067
30  libchrome_main_dll.dylib            0x00000001061dc39a _ZThn32_N23PermissionBubbleManager6AcceptEv + 42
31  libchrome_main_dll.dylib            0x0000000105eb4cfd -[PermissionBubbleController onAllow:] + 317

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? N/A 

Does this work in other browsers? N/A 

Chrome version: 51.0.2695.0 (Developer Build) (64-bit)  Channel: dev
OS Version: OS X 10.11.3
Flash Version: Shockwave Flash 20.0 r0

Permission 6 is PermissionType::MIDI. NOTREACHED() for this permission in the PermissionTypeToContentSetting was introduced in https://chromium.googlesource.com/chromium/src/+/83c807aae22f28b152ff5b59f146ac8c0e017015%5E%21/chrome/browser/permissions/permission_manager.cc
 
Components: UI>Browser>Permissions
Owner: mlamouri@chromium.org
Status: Assigned (was: Unconfirmed)
I reproduced this crash locally with a matching stack trace. mlamouri@, can you take a look at this? (from chrome/browser/permissions/OWNERS)
Cc: raymes@chromium.org
raymes@, is the UI doing something it shouldn't here?

Comment 4 by raymes@chromium.org, Apr 12 2016

It looks like someone set up a subscription for the midi (constant) permission which doesn't have a corresponding content setting type (and never changes anyway). We should probably put a check for that in OnContentSettingChanged for now I guess?

Comment 5 by raymes@chromium.org, Apr 13 2016

Cc: mlamouri@chromium.org
Owner: lshang@chromium.org
lshang said she would help with a patch :)
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 14 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c02c9483d9b17a50f9a9dd45a72f8da4a7c4c73

commit 3c02c9483d9b17a50f9a9dd45a72f8da4a7c4c73
Author: lshang <lshang@chromium.org>
Date: Thu Apr 14 00:36:00 2016

Fix bug: MIDI causes crash on onContentSettingChanged()

MIDI subscription will cause crash on onContentSettingChanged() because there
isn't corresponding content setting. Skip it because MIDI is constant permission
and it never changes anyway.

BUG= 599060 

Review URL: https://codereview.chromium.org/1885823002

Cr-Commit-Position: refs/heads/master@{#387174}

[modify] https://crrev.com/3c02c9483d9b17a50f9a9dd45a72f8da4a7c4c73/chrome/browser/permissions/permission_manager.cc
[modify] https://crrev.com/3c02c9483d9b17a50f9a9dd45a72f8da4a7c4c73/chrome/browser/permissions/permission_manager_unittest.cc

Comment 7 by lshang@chromium.org, Apr 19 2016

Status: Fixed (was: Assigned)

Sign in to add a comment