New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 599049 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , iOS , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Adding account hits NOTREACHED in LogChannelIDAndCookieStores

Project Member Reported by bzanotti@chromium.org, Mar 30 2016

Issue description

On iOS, when adding a new account on the device, the cookie store is ephemeral (adding an account shouldn't override the current signin cookies) but the channel id store is persistent (it is still the default one).

Due to https://codereview.chromium.org/1818603002/, this is now hitting a NOTREACHED (ephemerality is CID_PERSISTENT_COOKIE_EPHEMERAL).

I don't know what is the correct thing to do.

David: I'm assigning to you because you probably have more context on this.

 
Labels: -Pri-0 Pri-1
Cc: nhar...@chromium.org
+nharper who's been taking over channel id work. I assume this is for non-web content?
It is the GAIA sign-in page, so web content, but not arbitrary web content.
Components: -Internals>Network Internals>Network>Cookies
Adding a more refined network label just to get it out of the triager's various searches.  If that somehow makes the bug less useful, feel free to revert the label change.

Comment 5 by s...@chromium.org, Mar 30 2016

I'm also hitting this on OSX, when trying to sign into Chrome.
I confirmed that the NOTREACHED (for CID_PERSISTENT_COOKIE_EPHEMERAL) is also reached on OS X and linux. Repro steps are to click the sign-in button in the upper right, and then click "Sign in to Chromium". It crashes when loading the sign-in webview.

From looking at the crash in gdb, it looks like https://codereview.chromium.org/1814543002/ should fix that crash. I checked by adding the NOTREACHED to that CL, and it does not crash anymore (when trying to sign in to chromium).
Cc: -nhar...@chromium.org droger@chromium.org bzanotti@chromium.org
Labels: OS-Linux OS-Mac
Owner: nhar...@chromium.org
Summary: Adding account hits NOTREACHED in LogChannelIDAndCookieStores (was: Adding account hits NOTREACHED in LogChannelIDAndCookieStores on iOS)
Re-assigning to Nick.

Nick: Can you modify the code in iOS as well? The code is very similar and we have no-one working on iOS that knows much about Channel IDs.

The code lives in ios/chrome/browser/browser_state (off_the_record_profile_io_data.cc is off_the_record_chrome_browser_state_io_data.mm, profile_io_data.h is chrome_browser_state_io_data.h and we don't have safe browsing), and if you send me a change I'd be happy to check whether it works on iOS.
Any updates here? It's been 2 weeks and this will block the release of our M51 beta.
The NOTREACHED was disabled in the CL landed in comment 7, so I think things are "working", or at least no less broken than before.
Correct, the NOTREACHED was disabled in comment 6/7, and is not blocking M51. The NOTREACHED was checking for behavior that we thought shouldn't happen, but apparently has been happening for a long time.
Labels: -ReleaseBlock-Beta
Status: Fixed (was: Assigned)
The NOTREACHED was added back in over two weeks ago and I haven't heard any reports of it crashing.
I an using CEF (the version that follows the 2704 branch) and the NOTREACHED is triggered when used on Windows.
The website is the same https://accounts.google.com

There is a bug opened in CEF: https://bitbucket.org/chromiumembedded/cef/issues/1912/crash-with-cef-2704-on-windows-10

Let me knnow if you need more info on this bug


Sign in to add a comment