Adding account hits NOTREACHED in LogChannelIDAndCookieStores |
||||||
Issue descriptionOn iOS, when adding a new account on the device, the cookie store is ephemeral (adding an account shouldn't override the current signin cookies) but the channel id store is persistent (it is still the default one). Due to https://codereview.chromium.org/1818603002/, this is now hitting a NOTREACHED (ephemerality is CID_PERSISTENT_COOKIE_EPHEMERAL). I don't know what is the correct thing to do. David: I'm assigning to you because you probably have more context on this.
,
Mar 30 2016
+nharper who's been taking over channel id work. I assume this is for non-web content?
,
Mar 30 2016
It is the GAIA sign-in page, so web content, but not arbitrary web content.
,
Mar 30 2016
Adding a more refined network label just to get it out of the triager's various searches. If that somehow makes the bug less useful, feel free to revert the label change.
,
Mar 30 2016
I'm also hitting this on OSX, when trying to sign into Chrome.
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7 commit 6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7 Author: bzanotti <bzanotti@chromium.org> Date: Wed Mar 30 16:43:40 2016 Disable LogChannelIDAndCookieStores NOTREACHED. The NOTREACHED is actually reached on iOS. Disable it for now. Also implement on iOS the ChannelIDService tracking logic as it was not done in http://crrev.com/1818603002. BUG= 599049 Review URL: https://codereview.chromium.org/1842933003 Cr-Commit-Position: refs/heads/master@{#384001} [modify] https://crrev.com/6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm [modify] https://crrev.com/6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm [modify] https://crrev.com/6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7/ios/chrome/browser/ios_chrome_io_thread.mm [modify] https://crrev.com/6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7/net/url_request/url_request_http_job.cc
,
Mar 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7 commit 6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7 Author: bzanotti <bzanotti@chromium.org> Date: Wed Mar 30 16:43:40 2016 Disable LogChannelIDAndCookieStores NOTREACHED. The NOTREACHED is actually reached on iOS. Disable it for now. Also implement on iOS the ChannelIDService tracking logic as it was not done in http://crrev.com/1818603002. BUG= 599049 Review URL: https://codereview.chromium.org/1842933003 Cr-Commit-Position: refs/heads/master@{#384001} [modify] https://crrev.com/6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm [modify] https://crrev.com/6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7/ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm [modify] https://crrev.com/6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7/ios/chrome/browser/ios_chrome_io_thread.mm [modify] https://crrev.com/6daab6767d6470bbeadbdc2b7cacf4d6ba4709f7/net/url_request/url_request_http_job.cc
,
Mar 30 2016
I confirmed that the NOTREACHED (for CID_PERSISTENT_COOKIE_EPHEMERAL) is also reached on OS X and linux. Repro steps are to click the sign-in button in the upper right, and then click "Sign in to Chromium". It crashes when loading the sign-in webview. From looking at the crash in gdb, it looks like https://codereview.chromium.org/1814543002/ should fix that crash. I checked by adding the NOTREACHED to that CL, and it does not crash anymore (when trying to sign in to chromium).
,
Mar 31 2016
Re-assigning to Nick. Nick: Can you modify the code in iOS as well? The code is very similar and we have no-one working on iOS that knows much about Channel IDs. The code lives in ios/chrome/browser/browser_state (off_the_record_profile_io_data.cc is off_the_record_chrome_browser_state_io_data.mm, profile_io_data.h is chrome_browser_state_io_data.h and we don't have safe browsing), and if you send me a change I'd be happy to check whether it works on iOS.
,
Apr 13 2016
Any updates here? It's been 2 weeks and this will block the release of our M51 beta.
,
Apr 13 2016
The NOTREACHED was disabled in the CL landed in comment 7, so I think things are "working", or at least no less broken than before.
,
Apr 13 2016
Correct, the NOTREACHED was disabled in comment 6/7, and is not blocking M51. The NOTREACHED was checking for behavior that we thought shouldn't happen, but apparently has been happening for a long time.
,
Apr 18 2016
,
Apr 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4912248549948586848885a5b3eccff2ea16c104 commit 4912248549948586848885a5b3eccff2ea16c104 Author: nharper <nharper@chromium.org> Date: Fri Apr 29 18:00:58 2016 Fix URLRequestContext::CopyFrom in ios code BUG= 599049 Review-Url: https://codereview.chromium.org/1930233002 Cr-Commit-Position: refs/heads/master@{#390694} [modify] https://crrev.com/4912248549948586848885a5b3eccff2ea16c104/ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm [modify] https://crrev.com/4912248549948586848885a5b3eccff2ea16c104/ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc [modify] https://crrev.com/4912248549948586848885a5b3eccff2ea16c104/ios/chrome/browser/browser_state/chrome_browser_state_io_data.h [modify] https://crrev.com/4912248549948586848885a5b3eccff2ea16c104/net/url_request/url_request_http_job.cc
,
May 18 2016
The NOTREACHED was added back in over two weeks ago and I haven't heard any reports of it crashing.
,
Jun 6 2016
I an using CEF (the version that follows the 2704 branch) and the NOTREACHED is triggered when used on Windows. The website is the same https://accounts.google.com There is a bug opened in CEF: https://bitbucket.org/chromiumembedded/cef/issues/1912/crash-with-cef-2704-on-windows-10 Let me knnow if you need more info on this bug |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bzanotti@chromium.org
, Mar 30 2016