Alt+Left/Right page navigation doesn't work with focus on radio buttons
Reported by
joolscha...@gmail.com,
Mar 30 2016
|
||||||||
Issue descriptionChrome Version : 49.0.2623.110 m (64-bit) URLs (if applicable) : https://jsfiddle.net/JoolsCaesar/j3sp8wp5/ Other browsers tested: Add OK or FAIL, along with the version, after other browsers where you have tested this issue: Safari: n/a (Different shortcut) Firefox: OK IE: OK What steps will reproduce the problem? (1) Navigate to URL^ (2) Focus a radio button group (3) Hit Alt+Left What is the expected result? Navigate you to previous page What happens instead? Moves radio button selection, as though Alt wasn't held. Please provide any additional information below. Attach a screenshot if possible.
,
Mar 31 2016
,
Mar 31 2016
The regression points to https://chromium.googlesource.com/chromium/blink/+/6dbbd4fca9826c13c3d528ba779a5d655c5f2c1b We should likely be checking the modifier states before handling the keydown. Thoughts?
,
Mar 31 2016
> We should likely be checking the modifier states before handling the keydown. Indeed.
,
Apr 2 2016
Added a check before handling key down in RadioInputType: https://codereview.chromium.org/1849273003.
,
Apr 29 2016
Any idea when this fix will make a release?
,
May 3 2016
,
May 4 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/336ebfae1a3dec77c73c4d545965941d935f1b99 commit 336ebfae1a3dec77c73c4d545965941d935f1b99 Author: paritosh <paritosh@chromium.org> Date: Wed May 04 20:12:23 2016 Fix for Alt+Left/Right page navigation with focus on radio buttons. Added a condition for modifier state before handling keydown event. BUG= 599009 Review-Url: https://codereview.chromium.org/1944923002 Cr-Commit-Position: refs/heads/master@{#391621} [add] https://crrev.com/336ebfae1a3dec77c73c4d545965941d935f1b99/third_party/WebKit/LayoutTests/fast/forms/radio/radio-arrow-with-modifier-keys-expected.txt [add] https://crrev.com/336ebfae1a3dec77c73c4d545965941d935f1b99/third_party/WebKit/LayoutTests/fast/forms/radio/radio-arrow-with-modifier-keys.html [modify] https://crrev.com/336ebfae1a3dec77c73c4d545965941d935f1b99/third_party/WebKit/LayoutTests/fast/forms/radio/radio-group-arrow-cycle-edge.html [modify] https://crrev.com/336ebfae1a3dec77c73c4d545965941d935f1b99/third_party/WebKit/Source/core/html/forms/RadioInputType.cpp
,
May 4 2016
,
May 4 2016
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by msrchandra@chromium.org
, Mar 31 2016Components: Blink>JavaScript
Labels: M-51 OS-All
Status: Untriaged (was: Unconfirmed)