New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598985 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : 'Cookies set by this page' text appears weird in 'view site information' overlay.

Reported by mni...@etouch.net, Mar 30 2016

Issue description

Chrome Version : 50.0.2661.57 31761a6af4781d5cfd8ab5673f485a256dd5fe12-refs/branch-heads/2661@{#425} (32/64-bit)
OS : Windows(Win 7 aero enabled).
Url : http://www.pepsicoindia.co.in/

What steps will reproduce the problem?
1. Launch chrome and navigate to above url.
2. Now click on 'view site information' icon in 'address bar' and click on cookies link and overlay will open.
3. Now 'Minimize' the browser window and again open it and observe the text 'Cookies set by this page' on top of the overlay

Actual: 'Cookies set by this page' text appears weird after minimizing the browser window and again opening it.
Expected: 'Cookies set by this page' text should be seen properly.

This is a regression issue broken in 'M-50' and below is the manual regression and will soon update other info :
Good Build: 50.0.2640.0
Bad Build:  50.0.2641.0


 
Actual_video.mp4
780 KB Download
Actual_screenshot.png
460 KB View Download
Expected_video.mp4
771 KB Download
Expected_screenshot.png
510 KB View Download

Comment 1 by mni...@etouch.net, Mar 30 2016

Labels: hasbisect
Owner: est...@chromium.org
Status: Assigned (was: Unconfirmed)
Narrow bisect info :
Narrow bisect :
https://chromium.googlesource.com/chromium/src/+log/f75d97e7c5f8942f70b2fe2a5dfe8e9bb6b709b3..600b32e3aab92b65e375af32cf1406e454f28f04?pretty=fuller&n=10000

Suspecting: r373682  from Narrow bisect

@estade : Kindly help to re-assign, if your changes are not cause for this issue.

Note : 1). Issue is not reproduced in Mac and Linux OS.
       2). Issue is observed on all urls.

Comment 2 by mni...@etouch.net, Mar 30 2016

Cc: pbomm...@chromium.org
Owner: mni...@etouch.net
Unable to reproduce the issue on latest Chrome beta 50.0.2661.57, even the video which was provided looks ok to me.  mnikam@ please check this again and let 

Comment 4 by mni...@etouch.net, Mar 31 2016

Owner: est...@chromium.org
With response to comment #3 :
Able to reproduce the above issue on latest Chrome beta 50.0.2661.57.Please refer the attached video.
Actual result : Text appears to be chopped.(i.e 'Cookies' appears as 'Co','this' is seen as 'thi').Please refer the attached screenshot.
Actual_video_latest_Chrome_beta_50.0.2661.57.mp4
1.1 MB Download
Actual_screenshot_latest_Chrome_beta_50.0.2661.57.png
628 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63302b696824ab46a212de5bc1a1cf80b678a88a

commit 63302b696824ab46a212de5bc1a1cf80b678a88a
Author: estade <estade@chromium.org>
Date: Fri Apr 01 23:49:32 2016

Handle bubble title resizing (growth) by reworking title layout

The easiest way to demonstrate the bug is to shrink the browser window
horizontally until the title starts to wrap, then drag it larger again.
Without this patch, the title doesn't unwrap.

I also noticed that one of the labels was jiggling in the collected cookies view during resize; left-aligning the text fixes that.

BUG= 598985 
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1849703004

Cr-Commit-Position: refs/heads/master@{#384722}

[modify] https://crrev.com/63302b696824ab46a212de5bc1a1cf80b678a88a/chrome/browser/ui/views/collected_cookies_views.cc
[modify] https://crrev.com/63302b696824ab46a212de5bc1a1cf80b678a88a/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/63302b696824ab46a212de5bc1a1cf80b678a88a/ui/views/window/dialog_delegate_unittest.cc

Labels: Merge-Request-50

Comment 7 by tin...@google.com, Apr 4 2016

Labels: -Merge-Request-50 Merge-Approved-50 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M50 (branch: 2661)
Please merge your change to M50 branch 2661 by 5:00 PM PST today, 04/04/16 so we can take it for this week beta. Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 4 2016

Labels: -merge-approved-50 merge-merged-2661
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d9c9aa306d3ba4e7feeeee8fabbca79034d00ac

commit 5d9c9aa306d3ba4e7feeeee8fabbca79034d00ac
Author: Evan Stade <estade@chromium.org>
Date: Mon Apr 04 22:16:34 2016

Handle bubble title resizing (growth) by reworking title layout

The easiest way to demonstrate the bug is to shrink the browser window
horizontally until the title starts to wrap, then drag it larger again.
Without this patch, the title doesn't unwrap.

I also noticed that one of the labels was jiggling in the collected cookies view during resize; left-aligning the text fixes that.

BUG= 598985 
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/1849703004

Cr-Commit-Position: refs/heads/master@{#384722}
(cherry picked from commit 63302b696824ab46a212de5bc1a1cf80b678a88a)

Review URL: https://codereview.chromium.org/1860723003 .

Cr-Commit-Position: refs/branch-heads/2661@{#484}
Cr-Branched-From: ef6f6ae5e4c96622286b563658d5cd62a6cf1197-refs/heads/master@{#378081}

[modify] https://crrev.com/5d9c9aa306d3ba4e7feeeee8fabbca79034d00ac/chrome/browser/ui/views/collected_cookies_views.cc
[modify] https://crrev.com/5d9c9aa306d3ba4e7feeeee8fabbca79034d00ac/ui/views/bubble/bubble_frame_view.cc
[modify] https://crrev.com/5d9c9aa306d3ba4e7feeeee8fabbca79034d00ac/ui/views/window/dialog_delegate_unittest.cc

Status: Fixed (was: Assigned)
Labels: TE-Verified-M50 TE-Verified-50.0.2661.66
Tested the issue on windows 7 using chrome version 50.0.2661.66.Observed "Cookies set by this page" text rendering is fine.
Please find the attached screen cast for the same.

Adding TE-Verified label.

Thanks,

598985.mp4
1.1 MB Download

Sign in to add a comment