New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598980 link

Starred by 1 user

Issue metadata

Status: WontFix
Merged: issue 51703
Owner:
Closed: Mar 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: ----
Type: ----



Sign in to add a comment

rialto-services use of ReadFileToString needs updating

Project Member Reported by kitching@chromium.org, Mar 30 2016

Issue description

veyron-b-release-group failing:

https://uberchromegw.corp.google.com/i/chromeos/builders/veyron-b-release-group/builds/1408


Update to base/files/file_util.cc seems to change argument signature of ReadFileToString (and creates ReadFileToStringWithMaxSize):

https://chromium.googlesource.com/chromium/src/+/6da2fef05a6d503710e5f9b6f1363d94eac7c633%5E%21/


See logs:

https://uberchromegw.corp.google.com/i/chromeos/builders/veyron-b-release-group/builds/1408/steps/BuildPackages%20%5Bveyron_rialto%5D%20%5Bafdo_use%5D/logs/stdio


Example:

rialto-services-0.0.1-r16: /build/veyron_rialto/tmp/portage/chromeos-base/rialto-services-0.0.1-r16/work/src/rialto_daemon/rialto_daemon.cc:65:45: error: 
rialto-services-0.0.1-r16:       too many arguments to function call, expected 2, have 3
rialto-services-0.0.1-r16:                               &config_data, kDaemonConfigMaxSize)) {
rialto-services-0.0.1-r16:                                             ^~~~~~~~~~~~~~~~~~~~
rialto-services-0.0.1-r16: /build/veyron_rialto/usr/include/base-381699/base/files/file_util.h:146:13: note: 
rialto-services-0.0.1-r16:       'ReadFileToString' declared here
rialto-services-0.0.1-r16: BASE_EXPORT bool ReadFileToString(const FilePath& path, std::string* contents);
rialto-services-0.0.1-r16:             ^
rialto-services-0.0.1-r16: 1 error generated.
rialto-services-0.0.1-r16: common.mk:587: recipe for target 'rialto_daemon.pic.o' failed
 

Comment 1 by joth@chromium.org, Mar 30 2016

Cc: joth@chromium.org
Owner: amstan@chromium.org
Duplicate of https://code.google.com/p/chrome-os-partner/issues/detail?id=51703


Mergedinto: 51703
Status: Duplicate (was: Assigned)
amstan@, I missed that bug, thanks for pointing that out!

Comment 3 by joth@chromium.org, Mar 30 2016

Status: WontFix (was: Duplicate)
note https://code.google.com/p/chrome-os-partner/issues/detail?id=51703 is a chrome-os-partner issue, so not actually a dup of 51703 in this bug DB.
(I'm never sure which issue tracker private overlay bugs are supposed to go to)

Sign in to add a comment