Issue 598967 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ de...@chromium.org Last visit > 30 days ago
Closed:	May 2016
Cc:	█ senj@chromium.org
EstimatedDays:	----
NextAction:	----
OS:	Android , Chrome
Pri:	----
Type:	Bug-Regression

LeakSanitizer: detected memory leaks in update_engine-0.0.3-r1895 UnitTest

Project Member Reported by kitching@chromium.org, Mar 30 2016

Issue description

update_engine-0.0.3-r1895:  * ==17==ERROR: LeakSanitizer: detected memory leaks
update_engine-0.0.3-r1895:  * 
update_engine-0.0.3-r1895:  * Direct leak of 64144 byte(s) in 1 object(s) allocated from:
update_engine-0.0.3-r1895:  *     #0 0x7fbcc611b798 in __interceptor_malloc (/var/cache/portage/chromeos-base/update_engine/out/Default/update_engine_unittests+0x1d7d798)
update_engine-0.0.3-r1895:  *     #1 0x7fbcc41aaf03 in BZ2_bzDecompressInit /build/amd64-generic/tmp/portage/app-arch/bzip2-1.0.6-r7/work/bzip2-1.0.6-.amd64/../bzip2-1.0.6/bzlib.c:508
update_engine-0.0.3-r1895:  * 
update_engine-0.0.3-r1895:  * SUMMARY: AddressSanitizer: 64144 byte(s) leaked in 1 allocation(s).


Occurs in UnitTest for builds #16231 #16232

Builds: https://build.chromium.org/p/chromiumos/builders/amd64-generic-asan/builds/16231 https://build.chromium.org/p/chromiumos/builders/amd64-generic-asan/builds/16232

Logs: https://build.chromium.org/p/chromiumos/builders/amd64-generic-asan/builds/16232/steps/UnitTest/logs/stdio


deymo@, looks like you bumped the revision of update_engine to r1895 in this CL: https://chromium-review.googlesource.com/#/c/335602

The logs of builds running on r1894 don't seem to have this problem. I'm not sure if something went wrong on the chromiumos/platform2 or the platform/system/update_engine source trees in between the CROS_WORKON_COMMITs, or if something else is at play.

Comment 1 by de...@chromium.org, Mar 30 2016

Status: Started (was: Assigned)

It is likely a bug in our end since I cleaned up some bzip2 code recently. I'll take a look.

Comment 2 by de...@chromium.org, Mar 30 2016

https://android-review.googlesource.com/211480

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f49a355ab7d6b617af7ab309e2df53d886a6c459

commit f49a355ab7d6b617af7ab309e2df53d886a6c459
Author: Alex Deymo <deymo@chromium.org>
Date: Wed Mar 30 06:41:52 2016

Marking set of ebuilds as stable

Marking the following ebuilds as stable:
 * chromeos-base/apmanager
 * chromeos-base/attestation
 * chromeos-base/chromeos-dbus-bindings
 * chromeos-base/firewalld
 * chromeos-base/libbrillo
 * chromeos-base/shill
 * chromeos-base/shill-client
 * chromeos-base/shill-test-scripts
 * chromeos-base/tpm_manager
 * chromeos-base/trunks
 * chromeos-base/update_engine
 * chromeos-base/update_engine-client
 * chromeos-base/webserver

Pulled 2 new changes from platform/system/connectivity/shill:
  919aa73 Add ThirdPartyVpn suspend/resume events
  642dd96 Handle VPN reconnections on link down/up/changed

Pulled 1 new changes from platform/system/tpm:
  5b90435 trunks: Fix MIPS policy syscall names.

Pulled 2 new changes from platform/system/update_engine:
  d3251ef Fix memory leak in unittests with malformed data.
  6e30bc5 Handle AllowKioskAppControlChromeVersion device policy

Pulled 3 new changes from chromiumos/platform2:
  ec3139f crash: Relax UID filtering for ARC crashes
  a607cd5 cros-disks: mark VID/PID 05e3:0747 as SD card drive
  e5d02c2 crash: Label ARC crashes in chrome://crashes

BUG= chromium:577783 
BUG= chromium:598967 
TEST=trybots

Change-Id: I7169cb218923680b7f03618b652d5627b88b038c
Reviewed-on: https://chromium-review.googlesource.com/335665
Commit-Ready: Alex Deymo <deymo@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>

[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/attestation/attestation-0.0.1-r1063.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/shill-client/shill-client-0.0.1-r53.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/shill-test-scripts/shill-test-scripts-0.0.1-r1803.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/tpm_manager/tpm_manager-0.0.1-r345.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/firewalld/firewalld-0.0.1-r857.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/shill/shill-0.0.3-r9.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/update_engine/update_engine-0.0.3-r1896.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/webserver/webserver-0.0.1-r679.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/apmanager/apmanager-0.0.1-r1068.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/chromeos-dbus-bindings/chromeos-dbus-bindings-0.0.1-r1079.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/libbrillo/libbrillo-0.0.1-r20.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/trunks/trunks-0.0.1-r1194.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/update_engine-client/update_engine-client-0.0.1-r36.ebuild

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 30 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/f49a355ab7d6b617af7ab309e2df53d886a6c459

commit f49a355ab7d6b617af7ab309e2df53d886a6c459
Author: Alex Deymo <deymo@chromium.org>
Date: Wed Mar 30 06:41:52 2016

Marking set of ebuilds as stable

Marking the following ebuilds as stable:
 * chromeos-base/apmanager
 * chromeos-base/attestation
 * chromeos-base/chromeos-dbus-bindings
 * chromeos-base/firewalld
 * chromeos-base/libbrillo
 * chromeos-base/shill
 * chromeos-base/shill-client
 * chromeos-base/shill-test-scripts
 * chromeos-base/tpm_manager
 * chromeos-base/trunks
 * chromeos-base/update_engine
 * chromeos-base/update_engine-client
 * chromeos-base/webserver

Pulled 2 new changes from platform/system/connectivity/shill:
  919aa73 Add ThirdPartyVpn suspend/resume events
  642dd96 Handle VPN reconnections on link down/up/changed

Pulled 1 new changes from platform/system/tpm:
  5b90435 trunks: Fix MIPS policy syscall names.

Pulled 2 new changes from platform/system/update_engine:
  d3251ef Fix memory leak in unittests with malformed data.
  6e30bc5 Handle AllowKioskAppControlChromeVersion device policy

Pulled 3 new changes from chromiumos/platform2:
  ec3139f crash: Relax UID filtering for ARC crashes
  a607cd5 cros-disks: mark VID/PID 05e3:0747 as SD card drive
  e5d02c2 crash: Label ARC crashes in chrome://crashes

BUG= chromium:577783 
BUG= chromium:598967 
TEST=trybots

Change-Id: I7169cb218923680b7f03618b652d5627b88b038c
Reviewed-on: https://chromium-review.googlesource.com/335665
Commit-Ready: Alex Deymo <deymo@chromium.org>
Tested-by: Alex Deymo <deymo@chromium.org>
Reviewed-by: Alex Deymo <deymo@chromium.org>

[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/attestation/attestation-0.0.1-r1063.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/shill-client/shill-client-0.0.1-r53.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/shill-test-scripts/shill-test-scripts-0.0.1-r1803.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/tpm_manager/tpm_manager-0.0.1-r345.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/firewalld/firewalld-0.0.1-r857.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/shill/shill-0.0.3-r9.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/update_engine/update_engine-0.0.3-r1896.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/webserver/webserver-0.0.1-r679.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/apmanager/apmanager-0.0.1-r1068.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/chromeos-dbus-bindings/chromeos-dbus-bindings-0.0.1-r1079.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/libbrillo/libbrillo-0.0.1-r20.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/trunks/trunks-0.0.1-r1194.ebuild
[rename] https://crrev.com/f49a355ab7d6b617af7ab309e2df53d886a6c459/chromeos-base/update_engine-client/update_engine-client-0.0.1-r36.ebuild

Comment 5 by de...@chromium.org, May 7 2016

Status: Fixed (was: Started)

►

Issue 598967 link

Issue metadata

LeakSanitizer: detected memory leaks in update_engine-0.0.3-r1895 UnitTest

Issue description

Comment 1 by de...@chromium.org, Mar 30 2016

Comment 1 Deleted

Comment 2 by de...@chromium.org, Mar 30 2016

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Mar 30 2016

Comment 3 Deleted

Comment 4 by bugdroid1@chromium.org, Mar 30 2016

Comment 4 Deleted

Comment 5 by de...@chromium.org, May 7 2016

Comment 5 Deleted

Sign in to add a comment