New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 598964 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

content/browser/media/encrypted_media_browsertest.cc needs a scrubbing after Spitzer.

Project Member Reported by dalecur...@chromium.org, Mar 30 2016

Issue description

There are several tests in there which should run after Spitzer is enabled (some even run now on the right platforms). Notably:
- All the opus tests should use media::PlatformHasOpusSupport().
- Some of the SRC_ClearKey tests should be enabled now?
 

Comment 1 by ti...@chromium.org, Mar 30 2016

Owner: ti...@chromium.org
Status: Assigned (was: Available)

Comment 2 by xhw...@chromium.org, Mar 30 2016

Cc: -xhw...@chromium.org
Owner: xhw...@chromium.org
Status: Started (was: Assigned)
I'll give it a try.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5375fcbbcbe570f2f08c445a88aadc120ccc009a

commit 5375fcbbcbe570f2f08c445a88aadc120ccc009a
Author: xhwang <xhwang@chromium.org>
Date: Fri Apr 01 05:52:42 2016

media: Enable SRC content EncryptedMediaTest on Android

As part of Spitzer project, now EME is supported using SRC on Android.

This also add a flag so that we'll always use unified media pipeline when
running these tests.

BUG= 598964 , 455905 
TEST=This CL enables more tests on Android. Tested on Nexus 7 v2 with Android M.

Review URL: https://codereview.chromium.org/1849593002

Cr-Commit-Position: refs/heads/master@{#384498}

[modify] https://crrev.com/5375fcbbcbe570f2f08c445a88aadc120ccc009a/content/browser/media/encrypted_media_browsertest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Apr 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/939e5dc0d0f2a330c903eeee6e00db5edb01a354

commit 939e5dc0d0f2a330c903eeee6e00db5edb01a354
Author: xhwang <xhwang@chromium.org>
Date: Fri Apr 01 06:26:38 2016

media: Enable Opus tests on Android in content EncryptedMediaTest

When Opus is supported (PlatformHasOpusSupport() returns true) we should
be able to run these tests.

BUG= 598964 , 318436 
TEST=Tested Opus tests on Nexus 7 v2.

Review URL: https://codereview.chromium.org/1846743002

Cr-Commit-Position: refs/heads/master@{#384502}

[modify] https://crrev.com/939e5dc0d0f2a330c903eeee6e00db5edb01a354/content/browser/media/encrypted_media_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment